From: Mike Galbraith <efault@gmx.de>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Subject: Re: [Patch net] net_sched: replace yield() with cond_resched()
Date: Wed, 05 Apr 2017 05:55:45 +0200 [thread overview]
Message-ID: <1491364545.4536.90.camel@gmx.de> (raw)
In-Reply-To: <1491357139-27108-1-git-send-email-xiyou.wangcong@gmail.com>
On Tue, 2017-04-04 at 18:52 -0700, Cong Wang wrote:
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index 1a2f9e9..4725d2f 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -925,7 +925,7 @@ void dev_deactivate_many(struct list_head *head)
> /* Wait for outstanding qdisc_run calls. */
> list_for_each_entry(dev, head, close_list)
> while (some_qdisc_is_busy(dev))
> - yield();
> + cond_resched();
> }
That won't help, cond_resched() has the same impact upon a lone
SCHED_FIFO task as yield() does.. none.
-Mike
next prev parent reply other threads:[~2017-04-05 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 1:52 [Patch net] net_sched: replace yield() with cond_resched() Cong Wang
2017-04-05 3:55 ` Mike Galbraith [this message]
2017-04-05 5:19 ` Cong Wang
2017-04-05 5:56 ` Mike Galbraith
2017-04-05 23:42 ` Cong Wang
2017-04-06 1:54 ` Mike Galbraith
2017-04-06 22:13 ` Stephen Hemminger
2017-04-07 3:59 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491364545.4536.90.camel@gmx.de \
--to=efault@gmx.de \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.