From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: "Weinehall, David" <david.weinehall@intel.com>
Subject: Re: [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend
Date: Wed, 05 Apr 2017 15:54:27 +0300 [thread overview]
Message-ID: <1491396867.3078.20.camel@linux.intel.com> (raw)
In-Reply-To: <1491387710-20553-1-git-send-email-sagar.a.kamble@intel.com>
On ke, 2017-04-05 at 15:51 +0530, Sagar Arun Kamble wrote:
> i915 is currently doing Full GPU reset at the end of suspend followed by
> GuC suspend. This reset bypasses the GuC. We need to tell the GuC to
> suspend before we do a direct intel_gpu_reset, Otherwise the gpu state will
> no longer match the GuC's expectations and its suspend will not be
> successful. With this change, i915 suspends GuC after suspending GEM and
> before doing Full GPU reset.
+ David, Oscar and Michel
My understanding is that reloading GuC firmware after each resume is a
major bottleneck in resume time, and we instead should be telling GuC
to suspend and not reset the GPU, at most only reset the engines.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-04-05 12:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 10:21 [PATCH v2 1/1] drm/i915: Suspend GuC prior to GPU Reset during GEM suspend Sagar Arun Kamble
2017-04-05 10:39 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/1] " Patchwork
2017-04-05 12:24 ` [PATCH v2 1/1] " Chris Wilson
2017-04-05 16:38 ` Daniele Ceraolo Spurio
2017-04-06 10:12 ` Chris Wilson
2017-04-05 12:54 ` Joonas Lahtinen [this message]
2017-04-05 12:59 ` Chris Wilson
2017-04-05 13:02 ` David Weinehall
2017-04-05 15:46 ` Kamble, Sagar A
2017-04-05 15:51 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491396867.3078.20.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=david.weinehall@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.