From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "osandov@osandov.com" <osandov@osandov.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>
Cc: "kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH v2 8/8] blk-mq: clean up direct issue blk_mq_queue_data initialization
Date: Wed, 5 Apr 2017 18:35:58 +0000 [thread overview]
Message-ID: <1491417357.2787.13.camel@sandisk.com> (raw)
In-Reply-To: <e0eac74e541e9f85403fd4cf887a7f288768f00e.1491416593.git.osandov@fb.com>
On Wed, 2017-04-05 at 11:28 -0700, Omar Sandoval wrote:
> From: Omar Sandoval <osandov@fb.com>
>=20
> Trivial cleanup.
>=20
> Signed-off-by: Omar Sandoval <osandov@fb.com>
> ---
> block/blk-mq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/block/blk-mq.c b/block/blk-mq.c
> index 71dc8608f3a8..779249a5999b 100644
> --- a/block/blk-mq.c
> +++ b/block/blk-mq.c
> @@ -1451,8 +1451,7 @@ static void __blk_mq_try_issue_directly(struct requ=
est *rq, blk_qc_t *cookie,
> struct request_queue *q =3D rq->q;
> struct blk_mq_queue_data bd =3D {
> .rq =3D rq,
> - .list =3D NULL,
> - .last =3D 1
> + .last =3D true,
> };
> struct blk_mq_hw_ctx *hctx;
> blk_qc_t new_cookie;
Hello Omar,
Although this patch looks fine to me I'm afraid that since this morning
it no longer applies to Jens' for-next branch.
Bart.=
next prev parent reply other threads:[~2017-04-05 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 18:28 [PATCH v2 0/8] blk-mq: various fixes and cleanups Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 1/8] blk-mq: use the right hctx when getting a driver tag fails Omar Sandoval
2017-04-05 18:33 ` Bart Van Assche
2017-04-05 18:42 ` Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 2/8] blk-mq-sched: refactor scheduler initialization Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 3/8] blk-mq-sched: set up scheduler tags when bringing up new queues Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 4/8] blk-mq-sched: fix crash in switch error path Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 5/8] blk-mq: remap queues when adding/removing hardware queues Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 6/8] blk-mq-sched: provide hooks for initializing hardware queue data Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 7/8] blk-mq: make driver tag failure path easier to follow Omar Sandoval
2017-04-05 18:28 ` [PATCH v2 8/8] blk-mq: clean up direct issue blk_mq_queue_data initialization Omar Sandoval
2017-04-05 18:35 ` Bart Van Assche [this message]
2017-04-05 18:37 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491417357.2787.13.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.