From: Joe Perches <joe@perches.com>
To: Valerio Genovese <valerio.click@gmail.com>, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: ieee80211: Fix space required after }.
Date: Wed, 05 Apr 2017 16:57:38 -0700 [thread overview]
Message-ID: <1491436658.27353.85.camel@perches.com> (raw)
In-Reply-To: <1491420188-9482-1-git-send-email-valerio.click@gmail.com>
On Wed, 2017-04-05 at 21:23 +0200, Valerio Genovese wrote:
> This was reported by checkpatch.pl:
> ERROR: space required after that close brace '}'
>
> Signed-off-by: Valerio Genovese <valerio.click@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> index 2c398ca..5218f27 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
> @@ -31,7 +31,7 @@ typedef union _SEQUENCE_CONTROL{
> struct {
> u16 FragNum:4;
> u16 SeqNum:12;
> - }field;
> + } field;
> }SEQUENCE_CONTROL, *PSEQUENCE_CONTROL;
What about the one on the next line?
$ ./scripts/checkpatch.pl -f drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h --types=spacing --terse
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:29: WARNING: missing space after union definition
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:34: ERROR: space required after that close brace '}'
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h:35: ERROR: space required after that close brace '}'
next prev parent reply other threads:[~2017-04-05 23:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 19:23 [PATCH] staging: rtl8192u: ieee80211: Fix space required after } Valerio Genovese
2017-04-05 23:57 ` Joe Perches [this message]
2017-04-06 21:25 ` Valerio G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491436658.27353.85.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valerio.click@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.