diff for duplicates of <1491444359.50673.4.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 64e0e11..e0d7213 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ On Wed, 2017-04-05 at 18:59 -0700, Wesley Terpstra wrote: > On Wed, Apr 5, 2017 at 6:11 PM, Ley Foon Tan <ley.foon.tan@intel.com> > wrote: -> > +> >=20 > > We have fixed this in last year. > Right, for host/pcie-altera.c > However, the problem persists in host/pcie-xilinx.c and host/pcie- @@ -10,71 +10,91 @@ On Wed, 2017-04-05 at 18:59 -0700, Wesley Terpstra wrote: It hasn't integrated to mainline yet. https://lkml.org/lkml/2016/8/30/198 -> -> > +>=20 +> >=20 > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ > > comm > > it/drivers/pci/host/pcie- -> > altera.c?id=99496bd2971fc378226ad4413e5b72c4545714bd -> > -> > > -> > > -> > > > -> > > > +> > altera.c?id=3D99496bd2971fc378226ad4413e5b72c4545714bd +> >=20 +> > >=20 +> > >=20 +> > > >=20 +> > > >=20 > > > > Without it I see: -> > > > -> > > > [ 6.230000] ------------[ cut here ]------------ -> > > > [ 6.230000] WARNING: CPU: 0 PID: 1 at +> > > >=20 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.230000] ------------[ cut here ]--------= +---- +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.230000] WARNING: CPU: 0 PID: 1 at > > > > /scratch/terpstra/freedom-u- > > > > sdk/linux/kernel/irq/irqdomain.c:365 > > > > irq_domain_associate+0x190/0x200 -> > > > [ 6.240000] error: hwirq 0x4 is too large for dummy -> > > > [ 6.250000] CPU: 0 PID: 1 Comm: swapper Not tainted +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.240000] error: hwirq 0x4 is too large fo= +r dummy +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.250000] CPU: 0 PID: 1 Comm: swapper Not = +tainted > > > > 4.11.0-rc1-661305-g4f97179 #12 -> > > > [ 6.250000] Call Trace: -> > > > [ 6.260000] [<ffffffff80288660>] walk_stackframe+0x0/0x104 -> > > > [ 6.260000] [<ffffffff80288800>] show_stack+0x38/0x50 -> > > > [ 6.270000] [<ffffffff803c6e30>] dump_stack+0x2c/0x40 -> > > > [ 6.270000] [<ffffffff8028c600>] __warn+0x118/0x130 -> > > > [ 6.280000] [<ffffffff8028c658>] warn_slowpath_fmt+0x40/0x54 -> > > > [ 6.280000] [<ffffffff802c02a8>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.250000] Call Trace: +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.260000] [<ffffffff80288660>] walk_stackf= +rame+0x0/0x104 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.260000] [<ffffffff80288800>] show_stack+= +0x38/0x50 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.270000] [<ffffffff803c6e30>] dump_stack+= +0x2c/0x40 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.270000] [<ffffffff8028c600>] __warn+0x11= +8/0x130 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.280000] [<ffffffff8028c658>] warn_slowpa= +th_fmt+0x40/0x54 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.280000] [<ffffffff802c02a8>] > > > > irq_domain_associate+0x18c/0x200 -> > > > [ 6.290000] [<ffffffff802c0a3c>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.290000] [<ffffffff802c0a3c>] > > > > irq_create_mapping+0x90/0xe4 -> > > > [ 6.300000] [<ffffffff802c0be4>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.300000] [<ffffffff802c0be4>] > > > > irq_create_fwspec_mapping+0x154/0x288 -> > > > [ 6.300000] [<ffffffff802c0d7c>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.300000] [<ffffffff802c0d7c>] > > > > irq_create_of_mapping+0x64/0x84 -> > > > [ 6.310000] [<ffffffff804f9cb8>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.310000] [<ffffffff804f9cb8>] > > > > of_irq_parse_and_map_pci+0x38/0x50 -> > > > [ 6.310000] [<ffffffff80407e00>] pci_fixup_irqs+0x6c/0x114 -> > > > [ 6.320000] [<ffffffff80408e64>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.310000] [<ffffffff80407e00>] pci_fixup_i= +rqs+0x6c/0x114 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.320000] [<ffffffff80408e64>] > > > > xilinx_pcie_probe+0x308/0x3f0 -> > > > [ 6.330000] [<ffffffff8042cba4>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.330000] [<ffffffff8042cba4>] > > > > platform_drv_probe+0x3c/0x88 -> > > > [ 6.330000] [<ffffffff8042aec0>] really_probe+0xbc/0x260 -> > > > [ 6.340000] [<ffffffff8042b138>] __driver_attach+0xd4/0xdc -> > > > [ 6.340000] [<ffffffff80429200>] bus_for_each_dev+0x68/0xb8 -> > > > [ 6.350000] [<ffffffff8042b640>] driver_attach+0x24/0x38 -> > > > [ 6.350000] [<ffffffff80429db8>] bus_add_driver+0x1b4/0x22c -> > > > [ 6.360000] [<ffffffff8042bdc0>] driver_register+0x68/0x12c -> > > > [ 6.360000] [<ffffffff8042da78>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.330000] [<ffffffff8042aec0>] really_prob= +e+0xbc/0x260 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.340000] [<ffffffff8042b138>] __driver_at= +tach+0xd4/0xdc +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.340000] [<ffffffff80429200>] bus_for_eac= +h_dev+0x68/0xb8 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.350000] [<ffffffff8042b640>] driver_atta= +ch+0x24/0x38 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.350000] [<ffffffff80429db8>] bus_add_dri= +ver+0x1b4/0x22c +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.360000] [<ffffffff8042bdc0>] driver_regi= +ster+0x68/0x12c +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.360000] [<ffffffff8042da78>] > > > > __platform_driver_register+0x48/0x5c -> > > > [ 6.370000] [<ffffffff8000db38>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.370000] [<ffffffff8000db38>] > > > > xilinx_pcie_driver_init+0x20/0x34 -> > > > [ 6.380000] [<ffffffff80000d48>] do_one_initcall+0x98/0x140 -> > > > [ 6.380000] [<ffffffff80000f38>] +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.380000] [<ffffffff80000d48>] do_one_init= +call+0x98/0x140 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.380000] [<ffffffff80000f38>] > > > > kernel_init_freeable+0x148/0x218 -> > > > [ 6.390000] [<ffffffff805ad19c>] kernel_init+0x18/0x114 -> > > > [ 6.390000] [<ffffffff80286cac>] ret_from_syscall+0xc/0x10 -> > > > [ 6.400000] ---[ end trace 8023adf5befc91e0 ]--- -> > > > +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.390000] [<ffffffff805ad19c>] kernel_init= ++0x18/0x114 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.390000] [<ffffffff80286cac>] ret_from_sy= +scall+0xc/0x10 +> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.400000] ---[ end trace 8023adf5befc91e0 = +]--- +> > > >=20 > > > > ... that said, I am not confident my patch is the right fix. So > > > > consider this a bug report + work-around only. :) -> > > > -> > > > > -> > > > > -> > > > > Yeah, everything seems mostly working. The "invalid BAR" +> > > >=20 +> > > > >=20 +> > > > >=20 +> > > > > Yeah, everything seems mostly working.=C2=A0=C2=A0The "invalid BA= +R" > > > > > things > > > > > *could* be an issue -- those registers are not what the PCI > > > > > spec @@ -87,7 +107,7 @@ https://lkml.org/lkml/2016/8/30/198 > > > > 06:00.0 SATA controller: Marvell Technology Group Ltd. 88SE9230 > > > > PCIe > > > > SATA 6Gb/s Controller (rev 11) -> > > > +> > > >=20 > > > > I am going to plug them in to an Intel machine with 4.11 and > > > > see if > > > > I diff --git a/a/content_digest b/N1/content_digest index bfc1626..ef1952b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,7 +18,7 @@ "On Wed, 2017-04-05 at 18:59 -0700, Wesley Terpstra wrote:\n" "> On Wed, Apr 5, 2017 at 6:11 PM, Ley Foon Tan <ley.foon.tan@intel.com>\n" "> wrote:\n" - "> > \n" + "> >=20\n" "> > We have fixed this in last year.\n" "> Right, for host/pcie-altera.c\n" "> However, the problem persists in host/pcie-xilinx.c and host/pcie-\n" @@ -27,71 +27,91 @@ "It hasn't integrated to mainline yet.\n" "https://lkml.org/lkml/2016/8/30/198\n" "\n" - "> \n" - "> > \n" + ">=20\n" + "> >=20\n" "> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/\n" "> > comm\n" "> > it/drivers/pci/host/pcie-\n" - "> > altera.c?id=99496bd2971fc378226ad4413e5b72c4545714bd\n" - "> > \n" - "> > > \n" - "> > > \n" - "> > > > \n" - "> > > > \n" + "> > altera.c?id=3D99496bd2971fc378226ad4413e5b72c4545714bd\n" + "> >=20\n" + "> > >=20\n" + "> > >=20\n" + "> > > >=20\n" + "> > > >=20\n" "> > > > Without it I see:\n" - "> > > > \n" - "> > > > [\302\240\302\240\302\240\302\2406.230000] ------------[ cut here ]------------\n" - "> > > > [\302\240\302\240\302\240\302\2406.230000] WARNING: CPU: 0 PID: 1 at\n" + "> > > >=20\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.230000] ------------[ cut here ]--------=\n" + "----\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.230000] WARNING: CPU: 0 PID: 1 at\n" "> > > > /scratch/terpstra/freedom-u-\n" "> > > > sdk/linux/kernel/irq/irqdomain.c:365\n" "> > > > irq_domain_associate+0x190/0x200\n" - "> > > > [\302\240\302\240\302\240\302\2406.240000] error: hwirq 0x4 is too large for dummy\n" - "> > > > [\302\240\302\240\302\240\302\2406.250000] CPU: 0 PID: 1 Comm: swapper Not tainted\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.240000] error: hwirq 0x4 is too large fo=\n" + "r dummy\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.250000] CPU: 0 PID: 1 Comm: swapper Not =\n" + "tainted\n" "> > > > 4.11.0-rc1-661305-g4f97179 #12\n" - "> > > > [\302\240\302\240\302\240\302\2406.250000] Call Trace:\n" - "> > > > [\302\240\302\240\302\240\302\2406.260000] [<ffffffff80288660>] walk_stackframe+0x0/0x104\n" - "> > > > [\302\240\302\240\302\240\302\2406.260000] [<ffffffff80288800>] show_stack+0x38/0x50\n" - "> > > > [\302\240\302\240\302\240\302\2406.270000] [<ffffffff803c6e30>] dump_stack+0x2c/0x40\n" - "> > > > [\302\240\302\240\302\240\302\2406.270000] [<ffffffff8028c600>] __warn+0x118/0x130\n" - "> > > > [\302\240\302\240\302\240\302\2406.280000] [<ffffffff8028c658>] warn_slowpath_fmt+0x40/0x54\n" - "> > > > [\302\240\302\240\302\240\302\2406.280000] [<ffffffff802c02a8>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.250000] Call Trace:\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.260000] [<ffffffff80288660>] walk_stackf=\n" + "rame+0x0/0x104\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.260000] [<ffffffff80288800>] show_stack+=\n" + "0x38/0x50\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.270000] [<ffffffff803c6e30>] dump_stack+=\n" + "0x2c/0x40\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.270000] [<ffffffff8028c600>] __warn+0x11=\n" + "8/0x130\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.280000] [<ffffffff8028c658>] warn_slowpa=\n" + "th_fmt+0x40/0x54\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.280000] [<ffffffff802c02a8>]\n" "> > > > irq_domain_associate+0x18c/0x200\n" - "> > > > [\302\240\302\240\302\240\302\2406.290000] [<ffffffff802c0a3c>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.290000] [<ffffffff802c0a3c>]\n" "> > > > irq_create_mapping+0x90/0xe4\n" - "> > > > [\302\240\302\240\302\240\302\2406.300000] [<ffffffff802c0be4>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.300000] [<ffffffff802c0be4>]\n" "> > > > irq_create_fwspec_mapping+0x154/0x288\n" - "> > > > [\302\240\302\240\302\240\302\2406.300000] [<ffffffff802c0d7c>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.300000] [<ffffffff802c0d7c>]\n" "> > > > irq_create_of_mapping+0x64/0x84\n" - "> > > > [\302\240\302\240\302\240\302\2406.310000] [<ffffffff804f9cb8>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.310000] [<ffffffff804f9cb8>]\n" "> > > > of_irq_parse_and_map_pci+0x38/0x50\n" - "> > > > [\302\240\302\240\302\240\302\2406.310000] [<ffffffff80407e00>] pci_fixup_irqs+0x6c/0x114\n" - "> > > > [\302\240\302\240\302\240\302\2406.320000] [<ffffffff80408e64>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.310000] [<ffffffff80407e00>] pci_fixup_i=\n" + "rqs+0x6c/0x114\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.320000] [<ffffffff80408e64>]\n" "> > > > xilinx_pcie_probe+0x308/0x3f0\n" - "> > > > [\302\240\302\240\302\240\302\2406.330000] [<ffffffff8042cba4>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.330000] [<ffffffff8042cba4>]\n" "> > > > platform_drv_probe+0x3c/0x88\n" - "> > > > [\302\240\302\240\302\240\302\2406.330000] [<ffffffff8042aec0>] really_probe+0xbc/0x260\n" - "> > > > [\302\240\302\240\302\240\302\2406.340000] [<ffffffff8042b138>] __driver_attach+0xd4/0xdc\n" - "> > > > [\302\240\302\240\302\240\302\2406.340000] [<ffffffff80429200>] bus_for_each_dev+0x68/0xb8\n" - "> > > > [\302\240\302\240\302\240\302\2406.350000] [<ffffffff8042b640>] driver_attach+0x24/0x38\n" - "> > > > [\302\240\302\240\302\240\302\2406.350000] [<ffffffff80429db8>] bus_add_driver+0x1b4/0x22c\n" - "> > > > [\302\240\302\240\302\240\302\2406.360000] [<ffffffff8042bdc0>] driver_register+0x68/0x12c\n" - "> > > > [\302\240\302\240\302\240\302\2406.360000] [<ffffffff8042da78>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.330000] [<ffffffff8042aec0>] really_prob=\n" + "e+0xbc/0x260\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.340000] [<ffffffff8042b138>] __driver_at=\n" + "tach+0xd4/0xdc\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.340000] [<ffffffff80429200>] bus_for_eac=\n" + "h_dev+0x68/0xb8\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.350000] [<ffffffff8042b640>] driver_atta=\n" + "ch+0x24/0x38\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.350000] [<ffffffff80429db8>] bus_add_dri=\n" + "ver+0x1b4/0x22c\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.360000] [<ffffffff8042bdc0>] driver_regi=\n" + "ster+0x68/0x12c\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.360000] [<ffffffff8042da78>]\n" "> > > > __platform_driver_register+0x48/0x5c\n" - "> > > > [\302\240\302\240\302\240\302\2406.370000] [<ffffffff8000db38>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.370000] [<ffffffff8000db38>]\n" "> > > > xilinx_pcie_driver_init+0x20/0x34\n" - "> > > > [\302\240\302\240\302\240\302\2406.380000] [<ffffffff80000d48>] do_one_initcall+0x98/0x140\n" - "> > > > [\302\240\302\240\302\240\302\2406.380000] [<ffffffff80000f38>]\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.380000] [<ffffffff80000d48>] do_one_init=\n" + "call+0x98/0x140\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.380000] [<ffffffff80000f38>]\n" "> > > > kernel_init_freeable+0x148/0x218\n" - "> > > > [\302\240\302\240\302\240\302\2406.390000] [<ffffffff805ad19c>] kernel_init+0x18/0x114\n" - "> > > > [\302\240\302\240\302\240\302\2406.390000] [<ffffffff80286cac>] ret_from_syscall+0xc/0x10\n" - "> > > > [\302\240\302\240\302\240\302\2406.400000] ---[ end trace 8023adf5befc91e0 ]---\n" - "> > > > \n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.390000] [<ffffffff805ad19c>] kernel_init=\n" + "+0x18/0x114\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.390000] [<ffffffff80286cac>] ret_from_sy=\n" + "scall+0xc/0x10\n" + "> > > > [=C2=A0=C2=A0=C2=A0=C2=A06.400000] ---[ end trace 8023adf5befc91e0 =\n" + "]---\n" + "> > > >=20\n" "> > > > ... that said, I am not confident my patch is the right fix. So\n" "> > > > consider this a bug report + work-around only. :)\n" - "> > > > \n" - "> > > > > \n" - "> > > > > \n" - "> > > > > Yeah, everything seems mostly working.\302\240\302\240The \"invalid BAR\"\n" + "> > > >=20\n" + "> > > > >=20\n" + "> > > > >=20\n" + "> > > > > Yeah, everything seems mostly working.=C2=A0=C2=A0The \"invalid BA=\n" + "R\"\n" "> > > > > things\n" "> > > > > *could* be an issue -- those registers are not what the PCI\n" "> > > > > spec\n" @@ -104,7 +124,7 @@ "> > > > 06:00.0 SATA controller: Marvell Technology Group Ltd. 88SE9230\n" "> > > > PCIe\n" "> > > > SATA 6Gb/s Controller (rev 11)\n" - "> > > > \n" + "> > > >=20\n" "> > > > I am going to plug them in to an Intel machine with 4.11 and\n" "> > > > see if\n" "> > > > I\n" @@ -112,4 +132,4 @@ "> > Regards\n" > > Ley Foon -9e70c0d5f4a31b103f81d3453951f4fc1fa601f11baedb195d7e18245dda4492 +cdefc57578150228d67d6306552dd8d259501ca621273a24aaa2a076413489ba
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.