From mboxrd@z Thu Jan 1 00:00:00 1970 From: Your Name Subject: [PATCH v4 12/12] drm/drm_ioctl.c: Break ioctl when drm device not registered Date: Thu, 6 Apr 2017 20:22:23 +0800 Message-ID: <1491481343-11025-13-git-send-email-you@example.com> References: <1491481343-11025-1-git-send-email-you@example.com> Return-path: In-Reply-To: <1491481343-11025-1-git-send-email-you@example.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-kernel@vger.kernel.org Cc: briannorris@chromium.org, dianders@chromium.org, tfiga@chromium.org, seanpaul@chromium.org, zyw@rock-chips.com, mark.yao@rock-chips.com, Jeffy Chen , Your Name , Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, David Airlie List-Id: dri-devel@lists.freedesktop.org From: Jeffy Chen After unbinding drm, the user space may still owns the drm dev fd, and may still be able to call drm ioctl. Add a sanity check here to prevent that from happening. Signed-off-by: Jeffy Chen Signed-off-by: Your Name --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/gpu/drm/drm_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 7d6deaa..15beb11 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -674,7 +674,7 @@ long drm_ioctl(struct file *filp, dev = file_priv->minor->dev; - if (drm_device_is_unplugged(dev)) + if (drm_device_is_unplugged(dev) || !dev->registered) return -ENODEV; is_driver_ioctl = nr >= DRM_COMMAND_BASE && nr < DRM_COMMAND_END; -- 2.1.4