From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 5/7] xen: credit1: increase efficiency and scalability of load balancing. Date: Fri, 7 Apr 2017 17:26:16 +0200 Message-ID: <1491578776.3287.18.camel@citrix.com> References: <149146456487.21348.8554211499146017782.stgit@Solace.fritz.box> <149146660655.21348.13071925386790562321.stgit@Solace.fritz.box> <1568f464-29a4-6330-3902-a36f3eb62775@citrix.com> <1491576546.3287.16.camel@citrix.com> <6f4e282c-ee7d-0715-5177-999da533ae46@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1316647292698119821==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cwVmL-0001fO-R2 for xen-devel@lists.xenproject.org; Fri, 07 Apr 2017 15:26:25 +0000 In-Reply-To: <6f4e282c-ee7d-0715-5177-999da533ae46@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap , xen-devel@lists.xenproject.org Cc: George Dunlap , Andrew Cooper , Anshul Makkar List-Id: xen-devel@lists.xenproject.org --===============1316647292698119821== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-w7x/ZpKGyfKnXfZCfmTy" --=-w7x/ZpKGyfKnXfZCfmTy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2017-04-07 at 16:17 +0100, George Dunlap wrote: > On 07/04/17 15:49, Dario Faggioli wrote: > > Ok. I'm not sure I see what you mean with 'accounting' in this > > context, > > but, yeah, go ahead and let me know. :-) >=20 > Well I don't like having the increase_* and decrease_* all over the > place, *almost* corresponding with __runq_insert() and > __runq_remove(), > but not quite.=C2=A0=C2=A0 > Ah, I see what you mean now. Personally, I don't dislike it, but most important, I'm not sure I can do much better. :-/ > It seems like trying to sort out most of the refcounting > inside fo those two functions (perhaps with runq_insert() which did > reference counting, and __runq_insert() that didn't, or > something=C2=A0=C2=A0like > that) would be a better approach. > Right. I've tried already, but without success, and I had to stop an resort to what's in this patch. As I said, I am ok with this approach, so I just went for it. I can try to think harder at whether it is really possible to do something like you suggest above... lemme try. > If you're going to re-send the series, maybe it would be best if you > sent this patch last, so we can commit the rest? >=20 Yep, will do. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-w7x/ZpKGyfKnXfZCfmTy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJY56+ZAAoJEBZCeImluHPu0toQAKYx524J0p/eyd4zGwnAb8qT BZaLqGnsk2F9s4CtcJ4dwHobFMmcWfZB2AUW13zpK/aquknlZbdAzCQJhftT7qhS 3a5iwhVeoU5s2OM2lIACf0OWyseooJwxKihg6IkNXnivsgZCuUSqZKys4NL6L5xi 8O8YpcH6YhEcqL8sIV5tEjPbaJDtatHAdwEl5iHJBQXdyR/XkSGGRk/7n4CEKgkK oLL/n9kATZDJDH0Z2wR5MN0Ku9tHlSuNMFObJxw6JzTWgdHWx9s0x/1ykE/sptqE W2+tKaTBALz5SdTDvdzbyhFOY2KBKbK9xjEgGEvVgVjz/XIYw5mwa1K+gkzkC2oL JwwPG5tG4qsSZJtfW3gSPB0aU++HHFiP+DwJZegGME1kppxI18/IMN1Cpx6Lc0uO HdWhfS9TfMsWPUvG1IdXqHm3O+zLdqegjSBVPngECPQgg65GXgjwOQ9AxiU5iiel fHVqF+5V5wVulncD4XEZ5vcYUFoESeNJsTPlhzW8o3PjjE+e1hdlLXBGgy/nt+Z9 8ccS0WzpgON5/Q6HqsTQqvi1ml2T2xoIZCkcTIz99d43vCWgpPT1Qpf5+ZxBrpKt NXw8XfPl6UMgp5EggoA662KXMt8kt24qMYOgz2lUPNn1mrM+Du9yokN8ve88UI15 Uyx9gmL4ZG/3toZHDRYQ =HKhK -----END PGP SIGNATURE----- --=-w7x/ZpKGyfKnXfZCfmTy-- --===============1316647292698119821== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1316647292698119821==--