diff for duplicates of <1491586160.2505.87.camel@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b99ea14..91548dc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -56,7 +56,7 @@ FCoE. > > +static inline void skb_set_crc32c_ipsummed(struct sk_buff *skb, > > + const u8 ip_summed) > > +{ -> > + skb->csum_algo = ip_summed = CHECKSUM_PARTIAL ? CRC32C_CHECKSUM : +> > + skb->csum_algo = ip_summed == CHECKSUM_PARTIAL ? CRC32C_CHECKSUM : > > + INTERNET_CHECKSUM; > > + skb->ip_summed = ip_summed; > @@ -94,7 +94,7 @@ the SCTP CRC32c is computed. > > The old code is better. CHECKSUM_UNNECESSARY already applies to non IP > checksums. There is nothing special about crc32 in this regard and -> skb->csum_algo should only be valid when skb->ip_summed = +> skb->csum_algo should only be valid when skb->ip_summed == > CHECKSUM_PARTIAL so no need to set it here. This point should also be > in documentation. @@ -110,5 +110,3 @@ to explicitly set csum_algo to 0 (INTERNET_CHECKSUM) in SCTP-related code. Do yo thank you in advance, regards --- -davide diff --git a/a/content_digest b/N1/content_digest index 1cb7735..9b84782 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\0CALx6S34DdGZo7e1e37UCtpZ48jgdvHJ5nR=keyGFq3O3-b2_YQ@mail.gmail.com\0" "From\0Davide Caratti <dcaratti@redhat.com>\0" "Subject\0Re: [PATCH RFC net-next v3 4/7] net: use skb->csum_algo to identify packets needing crc32c\0" - "Date\0Fri, 07 Apr 2017 17:29:20 +0000\0" + "Date\0Fri, 07 Apr 2017 19:29:20 +0200\0" "To\0Tom Herbert <tom@herbertland.com>\0" "Cc\0Alexander Duyck <alexander.duyck@gmail.com>" David Laight <David.Laight@aculab.com> @@ -72,7 +72,7 @@ "> > +static inline void skb_set_crc32c_ipsummed(struct sk_buff *skb,\n" "> > + const u8 ip_summed)\n" "> > +{\n" - "> > + skb->csum_algo = ip_summed = CHECKSUM_PARTIAL ? CRC32C_CHECKSUM :\n" + "> > + skb->csum_algo = ip_summed == CHECKSUM_PARTIAL ? CRC32C_CHECKSUM :\n" "> > + INTERNET_CHECKSUM;\n" "> > + skb->ip_summed = ip_summed;\n" "> \n" @@ -110,7 +110,7 @@ "> \n" "> The old code is better. CHECKSUM_UNNECESSARY already applies to non IP\n" "> checksums. There is nothing special about crc32 in this regard and\n" - "> skb->csum_algo should only be valid when skb->ip_summed =\n" + "> skb->csum_algo should only be valid when skb->ip_summed ==\n" "> CHECKSUM_PARTIAL so no need to set it here. This point should also be\n" "> in documentation.\n" "\n" @@ -125,8 +125,6 @@ "to explicitly set csum_algo to 0 (INTERNET_CHECKSUM) in SCTP-related code. Do you agree?\n" "\n" "thank you in advance,\n" - "regards\n" - "--\n" - davide + regards -950aae361cdf285459fcf368aaa4c29513023da69bc003f0b9a7cff6094440a2 +39189d98f852af5016a31e38c9080b75c22a027c5de5d6d92b5d3c48eca85eef
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.