diff for duplicates of <1491591975.39459.1.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 98e75fb..6507656 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,69 +1,62 @@ On Wed, 2017-04-05 at 15:46 +0200, Corinna Vinschen wrote: -> ? Before libvirt modifies the MAC address and vlan tag for an SRIOV +> Before libvirt modifies the MAC address and vlan tag for an SRIOV > VF -> ? for use by a virtual machine (either using vfio device assignment +> for use by a virtual machine (either using vfio device assignment > or -> ? macvtap passthru mode), it saves the current MAC address and vlan +> macvtap passthru mode), it saves the current MAC address and vlan > tag -> ? so that it can reset them to their original value when the guest is -> ? done.? Libvirt can't leave the VF MAC set to the value used by the -> ? now-defunct guest since it may be started again later using a -> ? different VF, but it certainly shouldn't just pick any random +> so that it can reset them to their original value when the guest is +> done. Libvirt can't leave the VF MAC set to the value used by the +> now-defunct guest since it may be started again later using a +> different VF, but it certainly shouldn't just pick any random > value, -> ? either. So it saves the state of everything prior to using the VF, +> either. So it saves the state of everything prior to using the VF, > and -> ? resets it to that. +> resets it to that. > -> ? The igb driver initializes the MAC addresses of all VFs to -> ? 00:00:00:00:00:00, and reports that when asked (via an RTM_GETLINK -> ? netlink message, also visible in the list of VFs in the output of +> The igb driver initializes the MAC addresses of all VFs to +> 00:00:00:00:00:00, and reports that when asked (via an RTM_GETLINK +> netlink message, also visible in the list of VFs in the output of > "ip -> ? link show"). But when libvirt attempts to restore the MAC address +> link show"). But when libvirt attempts to restore the MAC address > back -> ? to 00:00:00:00:00:00 (using an RTM_SETLINK netlink message) the +> to 00:00:00:00:00:00 (using an RTM_SETLINK netlink message) the > kernel -> ? responds with "Invalid argument". +> responds with "Invalid argument". > -> ? Forbidding a reset back to the original value leaves the VF MAC at +> Forbidding a reset back to the original value leaves the VF MAC at > the -> ? value set for the now-defunct virtual machine. Especially on a +> value set for the now-defunct virtual machine. Especially on a > system -> ? with NetworkManager enabled, this has very bad consequences, since -> ? NetworkManager forces all interfacess to be IFF_UP all the time - +> with NetworkManager enabled, this has very bad consequences, since +> NetworkManager forces all interfacess to be IFF_UP all the time - > if -> ? the same virtual machine is restarted using a different VF (or even +> the same virtual machine is restarted using a different VF (or even > on -> ? a different host), there will be multiple interfaces watching for -> ? traffic with the same MAC address. +> a different host), there will be multiple interfaces watching for +> traffic with the same MAC address. > -> ? To allow libvirt to revert to the original state, we need a way to -> ? remove the administrative set MAC on a VF, to allow normal host -> ? operation again, and to reset/overwrite the VF MAC via VF netdev. +> To allow libvirt to revert to the original state, we need a way to +> remove the administrative set MAC on a VF, to allow normal host +> operation again, and to reset/overwrite the VF MAC via VF netdev. > -> ? This patch implements the outlined scenario by allowing to set the -> ? VF MAC to 00:00:00:00:00:00 via RTM_SETLINK on the PF. -> ? igb_ndo_set_vf_mac resets the IGB_VF_FLAG_PF_SET_MAC flag to 0, -> ? so it's possible to reset the VF MAC back to the original value via -> ? the VF netdev. +> This patch implements the outlined scenario by allowing to set the +> VF MAC to 00:00:00:00:00:00 via RTM_SETLINK on the PF. +> igb_ndo_set_vf_mac resets the IGB_VF_FLAG_PF_SET_MAC flag to 0, +> so it's possible to reset the VF MAC back to the original value via +> the VF netdev. > -> ? Note: Recent patches to libvirt allow for a workaround if the NIC -> ? isn't capable of resetting the administrative MAC back to all 0, +> Note: Recent patches to libvirt allow for a workaround if the NIC +> isn't capable of resetting the administrative MAC back to all 0, > but -> ? in theory the NIC should allow resetting the MAC in the first +> in theory the NIC should allow resetting the MAC in the first > place. > > Signed-off-by: Corinna Vinschen <vinschen@redhat.com> > --- -> ?drivers/net/ethernet/intel/igb/igb_main.c | 42 +> drivers/net/ethernet/intel/igb/igb_main.c | 42 > +++++++++++++++++++++++-------- -> ?1 file changed, 31 insertions(+), 11 deletions(-) +> 1 file changed, 31 insertions(+), 11 deletions(-) This patch does not apply (not even close). Please make sure to base you patch off my dev-queue branch of my next-queue tree on kernel.org. --------------- next part -------------- -A non-text attachment was scrubbed... -Name: signature.asc -Type: application/pgp-signature -Size: 833 bytes -Desc: This is a digitally signed message part -URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170407/33afc844/attachment.asc> diff --git a/N1/2.bin b/N1/2.bin new file mode 100644 index 0000000..c784920 --- /dev/null +++ b/N1/2.bin @@ -0,0 +1,16 @@ +-----BEGIN PGP SIGNATURE----- + +iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAljn4ycACgkQ5W/vlVpL +7c4VOxAAiEWwVnNnsH1rosTUQYBfGG93IHA0ReBgwXIuYR6F+PcMYRaersa86Fk/ +4WctkLrqvc64lTvmaZXe2Z4LCF97FpuDOejwpZNbjoUoe1L1lBJglbvrAa0A9zXX +dFAD7e8u+BZ9BnrVd2lH3ZHoiIreTUvWDrKRqqkzYz63PImuByRW8Y1nZKchZVtj +IOsXSOq/d5+fSWrPhmyN3URw278JleoVifvCwLkEz+zT4B3pOnnUefQhGR8Fl+sc +QKfnUJMGLxkIcqq+wuRg7UTt49vNgxlDdXf2UlchrL97KfJgcrzM4SxEOnErhnPP +QrSoXMmOCkJnzIchutNeWO1YdVpTFc/lxC6rm+/MKlTvrlLP7VSmz1e+H0tdfHAQ +VOQLM77X8bVHaHoBC3DxCjuwqDgNSIVNIbV9Lhlfp+wtUVgZzW5kr3ivVRnbkeOb +xVLpNB6n41ZHntLyjKnHzB901lkLynIOvzOB5cIPTBOz2DE6Ry2fVS9A+/5eApQc +ym9w1QQHGaMo9l2Lyp1HFIrghSow1T2ri8wKUYiVBfcY3LxGewsGFcqckKUbEs3s +oqYYwIzoULQjqffimuu+NxlNtkv9iDiU7YoMTHkqffjEPnDzxS1SpTA+sgI067X3 +ue/RrvbE8pbhgKGMV2jXoGf9Pk/ALfufVEgmAVBlGlxB2OrJSPk= +=8Uhq +-----END PGP SIGNATURE----- diff --git a/N1/2.hdr b/N1/2.hdr new file mode 100644 index 0000000..da6d245 --- /dev/null +++ b/N1/2.hdr @@ -0,0 +1,3 @@ +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: This is a digitally signed message part +Content-Transfer-Encoding: 7bit diff --git a/a/content_digest b/N1/content_digest index 32921af..71619da 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,79 +1,97 @@ "ref\0CAKgT0UdHbfSL-5QM6sfH=j7adQLAscUss1GzN2oYZsLM1CgV3g@mail.gmail.com\0" "ref\020170405134622.12227-1-vinschen@redhat.com\0" "From\0Jeff Kirsher <jeffrey.t.kirsher@intel.com>\0" - "Subject\0[Intel-wired-lan] [PATCH v2] igb: Allow to remove administratively set MAC on VFs\0" + "Subject\0Re: [Intel-wired-lan] [PATCH v2] igb: Allow to remove administratively set MAC on VFs\0" "Date\0Fri, 07 Apr 2017 12:06:15 -0700\0" - "To\0intel-wired-lan@osuosl.org\0" - "\00:1\0" + "To\0Corinna Vinschen <vinschen@redhat.com>" + intel-wired-lan@lists.osuosl.org + netdev@vger.kernel.org + Alexander Duyck <alexander.duyck@gmail.com> + Duyck@vinschen.de + " Alexander H <alexander.h.duyck@intel.com>\0" + "\01:1\0" "b\0" "On Wed, 2017-04-05 at 15:46 +0200, Corinna Vinschen wrote:\n" - "> ? Before libvirt modifies the MAC address and vlan tag for an SRIOV\n" + "> \302\240 Before libvirt modifies the MAC address and vlan tag for an SRIOV\n" "> VF\n" - "> ? for use by a virtual machine (either using vfio device assignment\n" + "> \302\240 for use by a virtual machine (either using vfio device assignment\n" "> or\n" - "> ? macvtap passthru mode), it saves the current MAC address and vlan\n" + "> \302\240 macvtap passthru mode), it saves the current MAC address and vlan\n" "> tag\n" - "> ? so that it can reset them to their original value when the guest is\n" - "> ? done.? Libvirt can't leave the VF MAC set to the value used by the\n" - "> ? now-defunct guest since it may be started again later using a\n" - "> ? different VF, but it certainly shouldn't just pick any random\n" + "> \302\240 so that it can reset them to their original value when the guest is\n" + "> \302\240 done.\302\240 Libvirt can't leave the VF MAC set to the value used by the\n" + "> \302\240 now-defunct guest since it may be started again later using a\n" + "> \302\240 different VF, but it certainly shouldn't just pick any random\n" "> value,\n" - "> ? either. So it saves the state of everything prior to using the VF,\n" + "> \302\240 either. So it saves the state of everything prior to using the VF,\n" "> and\n" - "> ? resets it to that.\n" + "> \302\240 resets it to that.\n" "> \n" - "> ? The igb driver initializes the MAC addresses of all VFs to\n" - "> ? 00:00:00:00:00:00, and reports that when asked (via an RTM_GETLINK\n" - "> ? netlink message, also visible in the list of VFs in the output of\n" + "> \302\240 The igb driver initializes the MAC addresses of all VFs to\n" + "> \302\240 00:00:00:00:00:00, and reports that when asked (via an RTM_GETLINK\n" + "> \302\240 netlink message, also visible in the list of VFs in the output of\n" "> \"ip\n" - "> ? link show\"). But when libvirt attempts to restore the MAC address\n" + "> \302\240 link show\"). But when libvirt attempts to restore the MAC address\n" "> back\n" - "> ? to 00:00:00:00:00:00 (using an RTM_SETLINK netlink message) the\n" + "> \302\240 to 00:00:00:00:00:00 (using an RTM_SETLINK netlink message) the\n" "> kernel\n" - "> ? responds with \"Invalid argument\".\n" + "> \302\240 responds with \"Invalid argument\".\n" "> \n" - "> ? Forbidding a reset back to the original value leaves the VF MAC at\n" + "> \302\240 Forbidding a reset back to the original value leaves the VF MAC at\n" "> the\n" - "> ? value set for the now-defunct virtual machine. Especially on a\n" + "> \302\240 value set for the now-defunct virtual machine. Especially on a\n" "> system\n" - "> ? with NetworkManager enabled, this has very bad consequences, since\n" - "> ? NetworkManager forces all interfacess to be IFF_UP all the time -\n" + "> \302\240 with NetworkManager enabled, this has very bad consequences, since\n" + "> \302\240 NetworkManager forces all interfacess to be IFF_UP all the time -\n" "> if\n" - "> ? the same virtual machine is restarted using a different VF (or even\n" + "> \302\240 the same virtual machine is restarted using a different VF (or even\n" "> on\n" - "> ? a different host), there will be multiple interfaces watching for\n" - "> ? traffic with the same MAC address.\n" + "> \302\240 a different host), there will be multiple interfaces watching for\n" + "> \302\240 traffic with the same MAC address.\n" "> \n" - "> ? To allow libvirt to revert to the original state, we need a way to\n" - "> ? remove the administrative set MAC on a VF, to allow normal host\n" - "> ? operation again, and to reset/overwrite the VF MAC via VF netdev.\n" + "> \302\240 To allow libvirt to revert to the original state, we need a way to\n" + "> \302\240 remove the administrative set MAC on a VF, to allow normal host\n" + "> \302\240 operation again, and to reset/overwrite the VF MAC via VF netdev.\n" "> \n" - "> ? This patch implements the outlined scenario by allowing to set the\n" - "> ? VF MAC to 00:00:00:00:00:00 via RTM_SETLINK on the PF.\n" - "> ? igb_ndo_set_vf_mac resets the IGB_VF_FLAG_PF_SET_MAC flag to 0,\n" - "> ? so it's possible to reset the VF MAC back to the original value via\n" - "> ? the VF netdev.\n" + "> \302\240 This patch implements the outlined scenario by allowing to set the\n" + "> \302\240 VF MAC to 00:00:00:00:00:00 via RTM_SETLINK on the PF.\n" + "> \302\240 igb_ndo_set_vf_mac resets the IGB_VF_FLAG_PF_SET_MAC flag to 0,\n" + "> \302\240 so it's possible to reset the VF MAC back to the original value via\n" + "> \302\240 the VF netdev.\n" "> \n" - "> ? Note: Recent patches to libvirt allow for a workaround if the NIC\n" - "> ? isn't capable of resetting the administrative MAC back to all 0,\n" + "> \302\240 Note: Recent patches to libvirt allow for a workaround if the NIC\n" + "> \302\240 isn't capable of resetting the administrative MAC back to all 0,\n" "> but\n" - "> ? in theory the NIC should allow resetting the MAC in the first\n" + "> \302\240 in theory the NIC should allow resetting the MAC in the first\n" "> place.\n" "> \n" "> Signed-off-by: Corinna Vinschen <vinschen@redhat.com>\n" "> ---\n" - "> ?drivers/net/ethernet/intel/igb/igb_main.c | 42\n" + "> \302\240drivers/net/ethernet/intel/igb/igb_main.c | 42\n" "> +++++++++++++++++++++++--------\n" - "> ?1 file changed, 31 insertions(+), 11 deletions(-)\n" + "> \302\2401 file changed, 31 insertions(+), 11 deletions(-)\n" "\n" "This patch does not apply (not even close). Please make sure to base\n" - "you patch off my dev-queue branch of my next-queue tree on kernel.org.\n" - "-------------- next part --------------\n" - "A non-text attachment was scrubbed...\n" - "Name: signature.asc\n" - "Type: application/pgp-signature\n" - "Size: 833 bytes\n" - "Desc: This is a digitally signed message part\n" - URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170407/33afc844/attachment.asc> + you patch off my dev-queue branch of my next-queue tree on kernel.org. + "\01:2\0" + "fn\0signature.asc\0" + "d\0This is a digitally signed message part\0" + "b\0" + "-----BEGIN PGP SIGNATURE-----\n" + "\n" + "iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAljn4ycACgkQ5W/vlVpL\n" + "7c4VOxAAiEWwVnNnsH1rosTUQYBfGG93IHA0ReBgwXIuYR6F+PcMYRaersa86Fk/\n" + "4WctkLrqvc64lTvmaZXe2Z4LCF97FpuDOejwpZNbjoUoe1L1lBJglbvrAa0A9zXX\n" + "dFAD7e8u+BZ9BnrVd2lH3ZHoiIreTUvWDrKRqqkzYz63PImuByRW8Y1nZKchZVtj\n" + "IOsXSOq/d5+fSWrPhmyN3URw278JleoVifvCwLkEz+zT4B3pOnnUefQhGR8Fl+sc\n" + "QKfnUJMGLxkIcqq+wuRg7UTt49vNgxlDdXf2UlchrL97KfJgcrzM4SxEOnErhnPP\n" + "QrSoXMmOCkJnzIchutNeWO1YdVpTFc/lxC6rm+/MKlTvrlLP7VSmz1e+H0tdfHAQ\n" + "VOQLM77X8bVHaHoBC3DxCjuwqDgNSIVNIbV9Lhlfp+wtUVgZzW5kr3ivVRnbkeOb\n" + "xVLpNB6n41ZHntLyjKnHzB901lkLynIOvzOB5cIPTBOz2DE6Ry2fVS9A+/5eApQc\n" + "ym9w1QQHGaMo9l2Lyp1HFIrghSow1T2ri8wKUYiVBfcY3LxGewsGFcqckKUbEs3s\n" + "oqYYwIzoULQjqffimuu+NxlNtkv9iDiU7YoMTHkqffjEPnDzxS1SpTA+sgI067X3\n" + "ue/RrvbE8pbhgKGMV2jXoGf9Pk/ALfufVEgmAVBlGlxB2OrJSPk=\n" + "=8Uhq\n" + "-----END PGP SIGNATURE-----\n" -4f7134d39891f7130330fd9fb64aeee089cccf8d2304dfce690734c0c7b0c89b +7822108a753396daae50107be3837bbb799519a0b525685405e5746abfa8e6c2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.