All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Ohly <patrick.ohly@intel.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: OpenEmbedded <openembedded-core@lists.openembedded.org>
Subject: Re: go-cross: incorrect dependency on tune-specific libgcc
Date: Mon, 10 Apr 2017 15:09:52 +0200	[thread overview]
Message-ID: <1491829792.10884.115.camel@intel.com> (raw)
In-Reply-To: <CADkTA4PQHE0w9=kvr5EyeQvG-Vm8SPQFh9NqM2Jofp_Ec99fKA@mail.gmail.com>

On Mon, 2017-04-10 at 08:59 -0400, Bruce Ashfield wrote:
> 
> 
> On Mon, Apr 10, 2017 at 8:49 AM, Patrick Ohly <patrick.ohly@intel.com>
> wrote:
[...]
>         diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
>         index 85f71a2e9a6..ac41c80d377 100644
>         --- a/meta/classes/go.bbclass
>         +++ b/meta/classes/go.bbclass
>         @@ -26,7 +26,7 @@ export CGO_CPPFLAGS = "${TARGET_CPPFLAGS}"
>          export CGO_CXXFLAGS = "${TARGET_CC_ARCH}${TOOLCHAIN_OPTIONS}
>         ${TARGET_CXXFLAGS}"
>          export CGO_LDFLAGS = "${TARGET_CC_ARCH}${TOOLCHAIN_OPTIONS}
>         ${TARGET_LDFLAGS}"
>         
>         -DEPENDS += "go-cross-${TARGET_ARCH}"
>         +DEPENDS += "go-cross-${TUNE_PKGARCH}"
>          DEPENDS_class-native += "go-native"
>         
>          FILES_${PN}-staticdev += "${GOSRC_FINAL}/${GO_IMPORT}"
[...]

> This requires any layers with existing DEPENDS on go-cross-${TARGET}
> to be updated,

"inherit go" hides that detail, so only recipes which depend on
go-cross-${TARGET_ARCH} directly instead of using go.bbclass need to be
updated (and perhaps should be changed to use go.bbclass instead?).

But I'm not a go expert, so let's hear from those first ;-}

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.





  reply	other threads:[~2017-04-10 13:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 12:49 go-cross: incorrect dependency on tune-specific libgcc Patrick Ohly
2017-04-10 12:59 ` Bruce Ashfield
2017-04-10 13:09   ` Patrick Ohly [this message]
2017-04-10 13:16     ` Bruce Ashfield
2017-04-10 14:44       ` Patrick Ohly
2017-04-11 16:34 ` Patrick Ohly
2017-04-11 16:39   ` Khem Raj
2017-04-11 16:52     ` Patrick Ohly
2017-04-11 17:01       ` Khem Raj
2017-04-11 18:26         ` Patrick Ohly
2017-04-11 16:57     ` Richard Purdie
2017-04-11 18:22       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491829792.10884.115.camel@intel.com \
    --to=patrick.ohly@intel.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.