From: perry <perry.hooker@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
aditya.shankar@microchip.com, linux-kernel@vger.kernel.org,
ganesh.krishna@microchip.com
Subject: Re: [PATCH] staging: wilc1000: use kernel define byte order macros
Date: Mon, 10 Apr 2017 15:36:26 -0400 [thread overview]
Message-ID: <1491852986.2188.0.camel@gmail.com> (raw)
In-Reply-To: <20170324085749.GQ32449@mwanda>
Hi Dan,
Can you clarify why the rx_buffer always holds little-endian data? It looks to me like this buffer is filled by
wilc_sdio_cmd53(), which uses sdio_memcpy_toio(), which ultimately sets the data with sg_set_buf(). This function
appears to use host-endian byte ordering.
Regards,
Perry
On Fri, 2017-03-24 at 11:57 +0300, Dan Carpenter wrote:
> On Thu, Mar 23, 2017 at 04:15:06PM -0600, Robert Perry Hooker wrote:
> > Well, yes, all data is 'endian' one way or another, right? I guess the byte order of the tx/rx_buffers is host
> > -endian
> > (which could be big), or _maybe_ network-endian...
>
> The good news is this code is Open Source[tm] so we don't need to guess.
> It's full of little endian data.
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2017-04-10 19:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 19:55 [PATCH] staging: wilc1000: use kernel define byte order macros Perry Hooker
2017-03-21 20:19 ` Dan Carpenter
2017-03-21 21:40 ` Robert Perry Hooker
2017-03-22 9:24 ` Dan Carpenter
2017-03-23 1:53 ` Robert Perry Hooker
2017-03-23 8:33 ` Dan Carpenter
2017-03-23 22:15 ` Robert Perry Hooker
2017-03-24 8:57 ` Dan Carpenter
2017-04-10 19:36 ` perry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491852986.2188.0.camel@gmail.com \
--to=perry.hooker@gmail.com \
--cc=aditya.shankar@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.