From: Balbir Singh <bsingharora@gmail.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman <mpe@ellerman.id.au>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
Greg Kurz <groug@kaod.org>, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
#@ozlabs.ru, v4.9+@ozlabs.ru
Subject: Re: [PATCH kernel v2] powerpc/iommu: Do not call PageTransHuge() on tail pages
Date: Tue, 11 Apr 2017 18:20:18 +1000 [thread overview]
Message-ID: <1491898818.8380.3.camel@gmail.com> (raw)
In-Reply-To: <20170411075457.28020-1-aik@ozlabs.ru>
On Tue, 2017-04-11 at 17:54 +1000, Alexey Kardashevskiy wrote:
> The CMA pages migration code does not support compound pages at
> the moment so it performs few tests before proceeding to actual page
> migration.
>
> One of the tests - PageTransHuge() - has VM_BUG_ON_PAGE(PageTail()) as
> it is designed to be called on head pages only. Since we also test for
> PageCompound(), and it contains PageTail() and PageHead(), we can
> simplify the check by leaving just PageCompound() and therefore avoid
> possible VM_BUG_ON_PAGE.
>
> Fixes: 2e5bbb5461f1 ("KVM: PPC: Book3S HV: Migrate pinned pages out of CMA")
> Cc: stable@vger.kernel.org # v4.9+
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> Acked-by: Balbir Singh <bsingharora@gmail.com>
> ---
>
> Changes:
> v2:
> * instead of moving PageCompound() to the beginning, this just drops
> PageHuge() and PageTransHuge()
>
Looks good! My Acked-by is already present
Balbir Singh.
next prev parent reply other threads:[~2017-04-11 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 7:54 [PATCH kernel v2] powerpc/iommu: Do not call PageTransHuge() on tail pages Alexey Kardashevskiy
2017-04-11 8:20 ` Balbir Singh [this message]
2017-04-19 22:04 ` [kernel, " Michael Ellerman
2017-04-19 22:04 ` [kernel,v2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491898818.8380.3.camel@gmail.com \
--to=bsingharora@gmail.com \
--cc=#@ozlabs.ru \
--cc=aik@ozlabs.ru \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=groug@kaod.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=stable@vger.kernel.org \
--cc=v4.9+@ozlabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.