All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Zhixiong Chi <zhixiong.chi@windriver.com>,
	bitbake-devel@lists.openembedded.org
Subject: Re: bitbake-layers: add signal hander to avoid exception
Date: Tue, 11 Apr 2017 15:47:17 +0100	[thread overview]
Message-ID: <1491922037.12091.20.camel@linuxfoundation.org> (raw)
In-Reply-To: <1491816164-18274-1-git-send-email-zhixiong.chi@windriver.com>

On Mon, 2017-04-10 at 17:22 +0800, Zhixiong Chi wrote:
> Fixed:
> bitbake-layers show-recipes | less
> press "q" to exit
> 
> There will be a Broken pipe error output as follows:
> "BrokenPipeError: [Errno 32] Broken pipe"
> 
> Signed-off-by: Zhixiong Chi <zhixiong.chi@windriver.com>
> ---
>  bin/bitbake-layers | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/bin/bitbake-layers b/bin/bitbake-layers
> index 390ad05..d58022d 100755
> --- a/bin/bitbake-layers
> +++ b/bin/bitbake-layers
> @@ -20,6 +20,7 @@
>  # with this program; if not, write to the Free Software Foundation,
> Inc.,
>  # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
>  
> +from signal import signal, SIGPIPE, SIG_DFL

Stylistically, we tend to do:

import signal

signal.signal(signal.SIGPIPE, signal.SIG_DFL)

so I've a small preference for that. I discussed this with Paul and we
think other bitbake tools may also have this issue. We wondered if it
was possible to do something more centrally in bitbake, and/or fix the
other tools at the same time.

Any thoughts on that?

Cheers,

Richard

>  import logging
>  import os
>  import sys
> @@ -35,6 +36,7 @@ import bb.msg
>  logger = bb.msg.logger_create('bitbake-layers', sys.stdout)
>  
>  def main():
> +    signal(SIGPIPE, SIG_DFL)
>      parser = argparse.ArgumentParser(
>          description="BitBake layers utility",
>          epilog="Use %(prog)s <subcommand> --help to get help on a
> specific command",
> -- 
> 1.9.1
> 


  reply	other threads:[~2017-04-11 15:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10  9:22 bitbake-layers: add signal hander to avoid exception Zhixiong Chi
2017-04-11 14:47 ` Richard Purdie [this message]
2017-04-12  3:27   ` Zhixiong Chi
2017-04-12 10:07     ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491922037.12091.20.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=zhixiong.chi@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.