All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ley Foon Tan <ley.foon.tan@intel.com>
To: Julien Beraud <julien.beraud@spectracom.orolia.com>,
	linux-kernel@vger.kernel.org, nios2-dev@lists.rocketboards.org
Subject: Re: [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock
Date: Tue, 11 Apr 2017 23:50:07 +0800	[thread overview]
Message-ID: <1491925807.2545.0.camel@intel.com> (raw)
In-Reply-To: <20170403111110.5442-1-julien.beraud@spectracom.orolia.com>

On Mon, 2017-04-03 at 13:11 +0200, Julien Beraud wrote:
> Use spin_lock/unlock_irq instead of doing nothing. This fixes
> corruptions
> of the vma_interval_tree causing the kernel to be stuck in an
> infinite loop in vma_interval_tree_foreach.
> 
> Signed-off-by: Julien Beraud <julien.beraud@spectracom.orolia.com>
> ---
>  arch/nios2/include/asm/cacheflush.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/nios2/include/asm/cacheflush.h
> b/arch/nios2/include/asm/cacheflush.h
> index 52abba973dc2..55e383c173f7 100644
> --- a/arch/nios2/include/asm/cacheflush.h
> +++ b/arch/nios2/include/asm/cacheflush.h
> @@ -46,7 +46,9 @@ extern void copy_from_user_page(struct
> vm_area_struct *vma, struct page *page,
>  extern void flush_dcache_range(unsigned long start, unsigned long
> end);
>  extern void invalidate_dcache_range(unsigned long start, unsigned
> long end);
> 
> -#define flush_dcache_mmap_lock(mapping)                do { } while
> (0)
> -#define flush_dcache_mmap_unlock(mapping)      do { } while (0)
> +#define flush_dcache_mmap_lock(mapping) \
> +       spin_lock_irq(&(mapping)->tree_lock)
> +#define flush_dcache_mmap_unlock(mapping) \
> +       spin_unlock_irq(&(mapping)->tree_lock)
> 
>  #endif /* _ASM_NIOS2_CACHEFLUSH_H */
> --
> 2.11.0
> 
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>

Regards
Ley Foon

      reply	other threads:[~2017-04-11  7:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-03 11:11 [PATCH 1/1] nios2: implement flush_dcache_mmap_lock/unlock Julien Beraud
2017-04-11 15:50 ` Ley Foon Tan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1491925807.2545.0.camel@intel.com \
    --to=ley.foon.tan@intel.com \
    --cc=julien.beraud@spectracom.orolia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nios2-dev@lists.rocketboards.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.