diff for duplicates of <1491931159.31718.16.camel@nxp.com> diff --git a/a/1.txt b/N1/1.txt index f76fea2..fd9555b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,23 +9,23 @@ On Wed, 2017-04-12 at 12:03 +0800, Dong Aisheng wrote: > + */ > +int clk_bulk_enable(int num_clks, struct clk_bulk_data *clks) > +{ -> + int ret; -> + int i; +> +???????int ret; +> +???????int i; > + -> + for (i = 0; i < num_clks; i++) { -> + ret = clk_enable(clks[i].clk); -> + if (ret) { -> + pr_err("Failed to enable clk '%s': %d\n", -> + clks[i].id, ret); -> + goto err; -> + } -> + } +> +???????for (i = 0; i < num_clks; i++) { +> +???????????????ret = clk_enable(clks[i].clk); +> +???????????????if (ret) { +> +???????????????????????pr_err("Failed to enable clk '%s': %d\n", +> +???????????????????????????????clks[i].id, ret); +> +???????????????????????goto err; +> +???????????????} +> +???????} > + -> + return 0; +> +???????return 0; > + > +err: -> + while (--i >= 0) -> + clk_put(clks[i].clk); +> +???????while (--i >= 0) +> +???????????????clk_put(clks[i].clk); Shouldn't this be clk_disable? diff --git a/a/content_digest b/N1/content_digest index 41ef4fd..e57441b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,9 @@ "ref\01491969809-20154-1-git-send-email-aisheng.dong@nxp.com\0" "ref\01491969809-20154-2-git-send-email-aisheng.dong@nxp.com\0" - "From\0Leonard Crestez <leonard.crestez@nxp.com>\0" - "Subject\0Re: [RFC PATCH 1/3] clk: add clk_bulk_get accessories\0" + "From\0leonard.crestez@nxp.com (Leonard Crestez)\0" + "Subject\0[RFC PATCH 1/3] clk: add clk_bulk_get accessories\0" "Date\0Tue, 11 Apr 2017 20:19:19 +0300\0" - "To\0Dong Aisheng <aisheng.dong@nxp.com>\0" - "Cc\0<linux-kernel@vger.kernel.org>" - <linux-arm-kernel@lists.infradead.org> - <kernel@pengutronix.de> - <broonie@kernel.org> - <yibin.gong@nxp.com> - <rjw@rjwysocki.net> - <viresh.kumar@linaro.org> - <mturquette@baylibre.com> - <sboyd@codeaurora.org> - <shawnguo@kernel.org> - <fabio.estevam@nxp.com> - <anson.huang@nxp.com> - <ping.bai@nxp.com> - <octavian.purdila@nxp.com> - " <linux-clk@vger.kernel.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Wed, 2017-04-12 at 12:03 +0800, Dong Aisheng wrote:\n" @@ -32,26 +17,26 @@ "> + */\n" "> +int clk_bulk_enable(int num_clks, struct clk_bulk_data *clks)\n" "> +{\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240int ret;\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240int i;\n" + "> +???????int ret;\n" + "> +???????int i;\n" "> +\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240for (i = 0; i < num_clks; i++) {\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ret = clk_enable(clks[i].clk);\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (ret) {\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pr_err(\"Failed to enable clk '%s': %d\\n\",\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clks[i].id, ret);\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240goto err;\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> +???????for (i = 0; i < num_clks; i++) {\n" + "> +???????????????ret = clk_enable(clks[i].clk);\n" + "> +???????????????if (ret) {\n" + "> +???????????????????????pr_err(\"Failed to enable clk '%s': %d\\n\",\n" + "> +???????????????????????????????clks[i].id, ret);\n" + "> +???????????????????????goto err;\n" + "> +???????????????}\n" + "> +???????}\n" "> +\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240return 0;\n" + "> +???????return 0;\n" "> +\n" "> +err:\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240while (--i >= 0)\n" - "> +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240clk_put(clks[i].clk);\n" + "> +???????while (--i >= 0)\n" + "> +???????????????clk_put(clks[i].clk);\n" "\n" "Shouldn't this be clk_disable?\n" "\n" And you can probably use clk_bulk_disable(i, clks) instead -601ccf6fea792df9e28f45beb7bb09f42e00d531cd999c0c546270f1b6f1a0d7 +94a84ca3aa780143ae3e9cbd303e8080a89182ee0588b886788624739a0b9646
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.