All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Cc: aviya.erenfeld@intel.com
Subject: Re: [PATCH 6/6] mac80211: use common code for monitor options in add/change
Date: Wed, 12 Apr 2017 16:20:34 +0200	[thread overview]
Message-ID: <1492006834.2855.7.camel@sipsolutions.net> (raw)
In-Reply-To: <20170412110621.8981-6-johannes@sipsolutions.net> (sfid-20170412_130634_643028_12035135)

This crashes, need

> +	if (!monitor_sdata &&
> +	    (params->vht_mumimo_groups || params-
> >vht_mumimo_follow_addr))
> +		return -EOPNOTSUPP;
> +
> +	/* apply all changes now - no failures allowed */
> +

if (monitor_sdata)

> +	ieee80211_set_mu_mimo_follow(monitor_sdata, params);
> 
[...]

johannes

      reply	other threads:[~2017-04-12 14:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-12 11:06 [PATCH 1/6] mac80211: drop frames too short for FCS earlier Johannes Berg
2017-04-12 11:06 ` [PATCH 2/6] cfg80211: allow leaving MU-MIMO monitor configuration unchanged Johannes Berg
2017-04-12 11:06 ` [PATCH 3/6] mac80211: correct MU-MIMO monitor follow functionality Johannes Berg
2017-04-12 11:06 ` [PATCH 4/6] cfg80211: move add/change interface monitor flags into params Johannes Berg
2017-04-12 11:06 ` [PATCH 5/6] cfg80211: refactor nl80211 monitor option parsing Johannes Berg
2017-04-12 11:06 ` [PATCH 6/6] mac80211: use common code for monitor options in add/change Johannes Berg
2017-04-12 14:20   ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492006834.2855.7.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=aviya.erenfeld@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.