From: Johannes Berg <johannes@sipsolutions.net>
To: David Ahern <dsa@cumulusnetworks.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: pablo@netfilter.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Jiri Benc <jbenc@redhat.com>,
jiri@resnulli.us
Subject: Re: [PATCH net-next v5 1/5] netlink: extended ACK reporting
Date: Wed, 12 Apr 2017 17:21:43 +0200 [thread overview]
Message-ID: <1492010503.2855.14.camel@sipsolutions.net> (raw)
In-Reply-To: <dbc81431-487b-f218-a4c6-2caa44783d97@cumulusnetworks.com> (sfid-20170412_170649_644527_0ED3DE34)
On Wed, 2017-04-12 at 09:06 -0600, David Ahern wrote:
>
> There was a discussion about side effects of adding strings (bloat,
> internationalization). Should ATTR_MSG be removed until that is
> ironed out? Leaving it in suggests it is ok to start adding strings.
I really do want the strings; this is why I named the struct member
"_msg" and added the NL_SET_ERR_MSG() macro, that will easily allow
both making the strings optional with Kconfig (bloat) and collecting
them into a separate data section (translation).
johannes
next prev parent reply other threads:[~2017-04-12 15:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 12:34 [PATCH net-next v5 0/5] netlink extended ACK reporting Johannes Berg
2017-04-12 12:34 ` [PATCH net-next v5 1/5] netlink: " Johannes Berg
2017-04-12 13:41 ` Jiri Pirko
2017-04-12 13:41 ` Jiri Pirko
2017-04-12 15:06 ` David Ahern
2017-04-12 15:13 ` Jiri Pirko
2017-04-12 15:13 ` Jiri Pirko
2017-04-12 15:28 ` David Miller
2017-04-12 15:21 ` Johannes Berg [this message]
2017-04-12 15:30 ` David Miller
2017-04-12 15:30 ` David Miller
2017-04-12 15:32 ` David Ahern
2017-04-12 15:32 ` David Ahern
2017-04-12 12:34 ` [PATCH net-next v5 2/5] genetlink: pass extended ACK report down Johannes Berg
2017-04-12 14:01 ` Jiri Pirko
2017-04-12 12:34 ` [PATCH net-next v5 3/5] netlink: allow sending extended ACK with cookie on success Johannes Berg
2017-04-12 13:47 ` Jiri Pirko
2017-04-12 13:47 ` Jiri Pirko
2017-04-12 13:54 ` Johannes Berg
2017-04-12 12:34 ` [PATCH net-next v5 4/5] netlink: pass extended ACK struct to parsing functions Johannes Berg
2017-04-12 12:34 ` Johannes Berg
2017-04-12 13:17 ` Jiri Pirko
2017-04-12 13:20 ` Johannes Berg
2017-04-12 13:20 ` Johannes Berg
2017-04-12 13:24 ` Jiri Pirko
2017-04-12 14:02 ` Kalle Valo
2017-04-12 14:08 ` Jiri Pirko
2017-04-12 13:56 ` Jiri Pirko
2017-04-12 13:56 ` Jiri Pirko
2017-04-12 12:34 ` [PATCH net-next v5 5/5] netlink: pass extended ACK struct where available Johannes Berg
2017-04-12 12:34 ` Johannes Berg
2017-04-12 14:00 ` Jiri Pirko
2017-04-12 14:55 ` David Ahern
2017-04-12 14:55 ` David Ahern
2017-04-12 15:15 ` Jiri Pirko
2017-04-12 15:29 ` David Miller
2017-04-12 14:57 ` [PATCH net-next v5 0/5] netlink extended ACK reporting David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492010503.2855.14.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=dsa@cumulusnetworks.com \
--cc=jbenc@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.