From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5C55C21A0483A for ; Wed, 12 Apr 2017 13:27:07 -0700 (PDT) From: "Verma, Vishal L" Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Date: Wed, 12 Apr 2017 20:27:05 +0000 Message-ID: <1492028744.2738.14.camel@intel.com> References: <20170411224457.24777-1-vishal.l.verma@intel.com> <20170412091442.dwonfr4dwyta7nvx@pd.tnic> <20170412195903.GA29506@omniknight.lm.intel.com> <20170412202238.5d327vmwjqvbzzop@pd.tnic> In-Reply-To: <20170412202238.5d327vmwjqvbzzop@pd.tnic> Content-Language: en-US Content-ID: MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "bp@suse.de" Cc: "Luck, Tony" , "linux-nvdimm@lists.01.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" List-ID: T24gV2VkLCAyMDE3LTA0LTEyIGF0IDIyOjIyICswMjAwLCBCb3Jpc2xhdiBQZXRrb3Ygd3JvdGU6 DQo+IE9uIFdlZCwgQXByIDEyLCAyMDE3IGF0IDAxOjU5OjAzUE0gLTA2MDAsIFZpc2hhbCBWZXJt YSB3cm90ZToNCj4gPiBJIGRvbid0IHRoaW5rIHdlIGNhbiBkbyBhbnl0aGluZyBhYm91dCB0aGUg cGFuaWMgcGF0aCBlcnJvcnMuDQo+IA0KPiBUaGVuIHRoZSBmaXggc2hvdWxkIGJlIGEgbG90IGVh c2llcjoNCj4gDQo+IC0tLQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL25maXQvbWNlLmMg Yi9kcml2ZXJzL2FjcGkvbmZpdC9tY2UuYw0KPiBpbmRleCAzYmExYzM0NzJjZjkuLjQ0YzA5MmVj MmFjOSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9hY3BpL25maXQvbWNlLmMNCj4gKysrIGIvZHJp dmVycy9hY3BpL25maXQvbWNlLmMNCj4gQEAgLTI1LDYgKzI1LDkgQEAgc3RhdGljIGludCBuZml0 X2hhbmRsZV9tY2Uoc3RydWN0IG5vdGlmaWVyX2Jsb2NrDQo+ICpuYiwgdW5zaWduZWQgbG9uZyB2 YWwsDQo+IMKgCXN0cnVjdCBhY3BpX25maXRfZGVzYyAqYWNwaV9kZXNjOw0KPiDCoAlzdHJ1Y3Qg bmZpdF9zcGEgKm5maXRfc3BhOw0KPiDCoA0KPiArCWlmIChpbl9hdG9taWMoKSkNCj4gKwkJcmV0 dXJuIE5PVElGWV9ET05FOw0KDQpCdXQgaXNuJ3QgdGhlIGF0b21pYyBub3RpZmllciBjYWxsIGNo YWluIGFsd2F5cyBjYWxsZWQgaW4gYXRvbWljDQpjb250ZXh0Pw0KDQo+ICsNCj4gwqAJLyogV2Ug b25seSBjYXJlIGFib3V0IG1lbW9yeSBlcnJvcnMgKi8NCj4gwqAJaWYgKCEobWNlLT5zdGF0dXMg JiBNQ0FDT0QpKQ0KPiDCoAkJcmV0dXJuIE5PVElGWV9ET05FOw0KPiANCj4gDQo+IC0twqANCj4g UmVnYXJkcy9HcnVzcywNCj4gwqDCoMKgwqBCb3Jpcy4NCj4gDQo+IFNVU0UgTGludXggR21iSCwg R0Y6IEZlbGl4IEltZW5kw7ZyZmZlciwgSmFuZSBTbWl0aGFyZCwgR3JhaGFtIE5vcnRvbiwNCj4g SFJCIDIxMjg0IChBRyBOw7xybmJlcmcpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxpc3QKTGludXgtbnZkaW1tQGxp c3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW52 ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755380AbdDLU1K (ORCPT ); Wed, 12 Apr 2017 16:27:10 -0400 Received: from mga01.intel.com ([192.55.52.88]:46005 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdDLU1H (ORCPT ); Wed, 12 Apr 2017 16:27:07 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,191,1488873600"; d="scan'208";a="76678497" From: "Verma, Vishal L" To: "bp@suse.de" CC: "Williams, Dan J" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@lists.01.org" , "Luck, Tony" , "ross.zwisler@linux.intel.com" , "x86@kernel.org" Subject: Re: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Thread-Topic: [RFC PATCH] x86, mce: change the mce notifier to 'blocking' from 'atomic' Thread-Index: AQHSsxV3s/VS0/ZISkGoKwFEXJsIM6HB6Z0AgABPc4CAAGssAIAAAN0A Date: Wed, 12 Apr 2017 20:27:05 +0000 Message-ID: <1492028744.2738.14.camel@intel.com> References: <20170411224457.24777-1-vishal.l.verma@intel.com> <20170412091442.dwonfr4dwyta7nvx@pd.tnic> <20170412195903.GA29506@omniknight.lm.intel.com> <20170412202238.5d327vmwjqvbzzop@pd.tnic> In-Reply-To: <20170412202238.5d327vmwjqvbzzop@pd.tnic> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.232.112.53] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3CKRFub024398 On Wed, 2017-04-12 at 22:22 +0200, Borislav Petkov wrote: > On Wed, Apr 12, 2017 at 01:59:03PM -0600, Vishal Verma wrote: > > I don't think we can do anything about the panic path errors. > > Then the fix should be a lot easier: > > --- > diff --git a/drivers/acpi/nfit/mce.c b/drivers/acpi/nfit/mce.c > index 3ba1c3472cf9..44c092ec2ac9 100644 > --- a/drivers/acpi/nfit/mce.c > +++ b/drivers/acpi/nfit/mce.c > @@ -25,6 +25,9 @@ static int nfit_handle_mce(struct notifier_block > *nb, unsigned long val, >   struct acpi_nfit_desc *acpi_desc; >   struct nfit_spa *nfit_spa; >   > + if (in_atomic()) > + return NOTIFY_DONE; But isn't the atomic notifier call chain always called in atomic context? > + >   /* We only care about memory errors */ >   if (!(mce->status & MCACOD)) >   return NOTIFY_DONE; > > > --  > Regards/Gruss, >     Boris. > > SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, > HRB 21284 (AG Nürnberg)