From: Dario Faggioli <dario.faggioli@citrix.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>
Subject: Re: [for-4.9 PATCH] xen: credit: change an ASSERT on nr_runnable so that it makes sense.
Date: Thu, 13 Apr 2017 12:00:15 +0200 [thread overview]
Message-ID: <1492077615.3287.37.camel@citrix.com> (raw)
In-Reply-To: <87daa520-a69d-3b74-2b7d-eb11f17bd46d@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1120 bytes --]
On Thu, 2017-04-13 at 10:42 +0100, Julien Grall wrote:
> Hi Dario,
>
> On 13/04/17 08:49, Dario Faggioli wrote:
> > Since the counter is unsigned, it's pointless/bogous to check
> > for if to be above zero.
> >
> > Check that it is at least one before it's decremented, instead.
> >
> > Spotted by Coverity.
>
> Do you have the Coverity-ID? :)
>
This comes from the Citrix internal instance, so the ID wouldn't make
any sense.
I don't know if the XenProject instance has also caught it. I guess
it's likely, but I don't have access, so I can't check.
Adding the above line is what Andrew suggested doing (saying he does it
himself) when things like this happens, to better reflect the reality.
Let me know if I should do anything different (of feel free to add or
change anything related to this upon commit).
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-04-13 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 7:49 [for-4.9 PATCH] xen: credit: change an ASSERT on nr_runnable so that it makes sense Dario Faggioli
2017-04-13 9:42 ` Julien Grall
2017-04-13 9:45 ` Wei Liu
2017-04-13 10:00 ` Dario Faggioli [this message]
2017-04-13 10:17 ` Andrew Cooper
2017-04-13 14:09 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492077615.3287.37.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.