From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org"
<hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH rdma-core 1/3] srp_daemon/srp_daemon.c: Don't rely on attribute offset, in get_shared_pkeys
Date: Thu, 13 Apr 2017 15:24:47 +0000 [thread overview]
Message-ID: <1492097083.3298.3.camel@sandisk.com> (raw)
In-Reply-To: <b3cbb29e-25bf-1785-7a60-8e8d7cab74e3-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Thu, 2017-04-13 at 10:48 -0400, Hal Rosenstock wrote:
> get_shared_pkeys has been using SubAdmGet rather than SubAdmGetTable since
> commit 2ad09524931dbf98d412e1912c1bdbf22f8ac81d
> srp_daemon: Work around SM bug over non-default P_Key support
>
> so RMPP is no longer used in response so it's not safe to
> rely on AttributeOffset field. Good MAD status is sufficient
> to say that valid PathRecord was returned.
>
> Found-by: Honggang LI <honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> using embedded subnet manager running on an Intel True Scale
> Edge Switch 12300.
>
> This has been broken since srptools-1.0.1 which was first
> release containing commit mentioned above.
Reviewed-by: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-13 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 14:48 [PATCH rdma-core 1/3] srp_daemon/srp_daemon.c: Don't rely on attribute offset, in get_shared_pkeys Hal Rosenstock
[not found] ` <b3cbb29e-25bf-1785-7a60-8e8d7cab74e3-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-04-13 15:24 ` Bart Van Assche [this message]
2017-04-14 0:33 ` Honggang LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492097083.3298.3.camel@sandisk.com \
--to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=honli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.