All of lore.kernel.org
 help / color / mirror / Atom feed
From: TeLeMan <geleman@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] i386 hard interrupt generation bug fix
Date: Thu, 17 Jan 2008 07:17:29 -0800 (PST)	[thread overview]
Message-ID: <14921171.post@talk.nabble.com> (raw)


in cpu-exe.c:
intno=cpu_get_pic_interrupt(env);

intno may be -1, we have to skip this error code.

http://www.nabble.com/file/p14921171/hard_int.patch hard_int.patch: 

--- qemu.orig/cpu-exec.c	Mon Jan 14 11:11:02 2008
+++ qemu/cpu-exec.c	Thu Jan 17 23:03:00 2008
@@ -449,16 +449,18 @@ int cpu_exec(CPUState *env1)
                         (env->eflags & IF_MASK || env->hflags &
HF_HIF_MASK) &&
                         !(env->hflags & HF_INHIBIT_IRQ_MASK)) {
                         int intno;
-                        svm_check_intercept(SVM_EXIT_INTR);
                         env->interrupt_request &= ~(CPU_INTERRUPT_HARD |
CPU_INTERRUPT_VIRQ);
                         intno = cpu_get_pic_interrupt(env);
-                        if (loglevel & CPU_LOG_TB_IN_ASM) {
-                            fprintf(logfile, "Servicing hardware
INT=0x%02x\n", intno);
-                        }
-                        do_interrupt(intno, 0, 0, 0, 1);
-                        /* ensure that no TB jump will be modified as
-                           the program flow was changed */
-                        BREAK_CHAIN;
+	                     if(intno>=0) {
+                            svm_check_intercept(SVM_EXIT_INTR);
+                            if (loglevel & CPU_LOG_TB_IN_ASM) {
+                                fprintf(logfile, "Servicing hardware
INT=0x%02x\n", intno);
+                            }
+                            do_interrupt(intno, 0, 0, 0, 1);
+                           /* ensure that no TB jump will be modified as
+                              the program flow was changed */
+                            BREAK_CHAIN;
+                        }
 #if !defined(CONFIG_USER_ONLY)
                     } else if ((interrupt_request & CPU_INTERRUPT_VIRQ) &&
                         (env->eflags & IF_MASK) && !(env->hflags &
HF_INHIBIT_IRQ_MASK)) {

-- 
View this message in context: http://www.nabble.com/-PATCH--i386-hard-interrupt-generation-bug-fix-tp14921171p14921171.html
Sent from the QEMU - Dev mailing list archive at Nabble.com.

                 reply	other threads:[~2008-01-17 15:17 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14921171.post@talk.nabble.com \
    --to=geleman@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.