From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>
Cc: "hch@lst.de" <hch@lst.de>, "osandov@fb.com" <osandov@fb.com>
Subject: Re: [PATCH 1/3] blk-mq: unify hctx delayed_run_work and run_work
Date: Fri, 14 Apr 2017 20:56:09 +0000 [thread overview]
Message-ID: <1492203368.2644.16.camel@sandisk.com> (raw)
In-Reply-To: <146849ab-b865-0ba7-b434-7101e013eafb@fb.com>
On Fri, 2017-04-14 at 14:02 -0600, Jens Axboe wrote:
> I was waiting for further comments on patch 3/3.
Hello Jens,
Patch 3/3 is probably fine but I hope that you understand that the introduc=
tion
of a new race condition does not make me enthusiast. Should your explanatio=
n of
why that race is harmless perhaps be added as a comment?
Bart.=
next prev parent reply other threads:[~2017-04-14 20:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 15:54 [PATCH 0/3] blk-mq: unify hardware queue run handlers Jens Axboe
2017-04-10 15:54 ` [PATCH 1/3] blk-mq: unify hctx delayed_run_work and run_work Jens Axboe
2017-04-10 16:09 ` Christoph Hellwig
2017-04-10 16:17 ` Bart Van Assche
2017-04-11 18:00 ` Bart Van Assche
2017-04-14 20:02 ` Jens Axboe
2017-04-14 20:56 ` Bart Van Assche [this message]
2017-04-28 2:12 ` Ming Lei
2017-04-10 15:54 ` [PATCH 2/3] block: add kblock_mod_delayed_work_on() Jens Axboe
2017-04-10 16:10 ` Christoph Hellwig
2017-04-10 16:17 ` Bart Van Assche
2017-04-10 15:54 ` [PATCH 3/3] blk-mq: unify hctx delay_work and run_work Jens Axboe
2017-04-10 16:21 ` Bart Van Assche
2017-04-10 16:53 ` Jens Axboe
2017-04-10 17:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492203368.2644.16.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.