From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752371AbdDOFRQ (ORCPT ); Sat, 15 Apr 2017 01:17:16 -0400 Received: from smtprelay0066.hostedemail.com ([216.40.44.66]:36652 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751476AbdDOFRO (ORCPT ); Sat, 15 Apr 2017 01:17:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:4250:4321:5007:6119:9038:9545:10004:10226:10400:10848:10904:11026:11657:11658:11914:12043:12740:12760:12895:13069:13163:13229:13311:13357:13439:14659:21080:21451:30012:30046:30054:30070:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: jelly70_3e9292cde765e X-Filterd-Recvd-Size: 1596 Message-ID: <1492233427.8661.1.camel@perches.com> Subject: Re: [PATCH] remove return statement From: Joe Perches To: surenderpolsani , gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Larry.Finger" Date: Fri, 14 Apr 2017 22:17:07 -0700 In-Reply-To: <1492232735-3516-1-git-send-email-surenderpolsani@gmail.com> References: <1492232735-3516-1-git-send-email-surenderpolsani@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2017-04-15 at 10:35 +0530, surenderpolsani wrote: > staging : rtl8188e : remove return in void function Your patch subject isn't correct. It should be something like: Subject: [PATCH] staging: rtl8188e: Remove void function return > kernel coding style doesn't allow the return statement > in void function. [] > diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c [] > @@ -165,7 +165,6 @@ void rtw_hal_dm_watchdog(struct adapter *Adapter) > skip_dm: > /* Check GPIO to determine current RF on/off and Pbc status. */ > /* Check Hardware Radio ON/OFF or not */ > - return; And the comments? Are those supposed to be reminders of code to write?