From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1czKuL-0008E6-2U
	for mharc-grub-devel@gnu.org; Sat, 15 Apr 2017 06:26:21 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55589)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paulepanter@users.sourceforge.net>)
	id 1czKuI-0008DB-37
	for grub-devel@gnu.org; Sat, 15 Apr 2017 06:26:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paulepanter@users.sourceforge.net>)
	id 1czKuD-0002Iz-6y
	for grub-devel@gnu.org; Sat, 15 Apr 2017 06:26:18 -0400
Received: from mail.gw90.de ([188.40.100.199]:59496)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <paulepanter@users.sourceforge.net>)
	id 1czKuC-00028f-Vc
	for grub-devel@gnu.org; Sat, 15 Apr 2017 06:26:13 -0400
Received: from [2a02:8109:8ac0:1c7f:5e33:e478:c88b:8ec4] (helo=mattotaupa)
	by mail.gw90.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.84_2) (envelope-from <paulepanter@users.sourceforge.net>)
	id 1czKu1-0002Nq-0k
	for grub-devel@gnu.org; Sat, 15 Apr 2017 10:26:01 +0000
Message-ID: <1492251954.3639.117.camel@users.sourceforge.net>
Subject: `all_video.mod` missing loading `grub.cfg` generated by grub-pc in
	GRUB payload (coreboot)
From: Paul Menzel <paulepanter@users.sourceforge.net>
To: grub-devel@gnu.org
Date: Sat, 15 Apr 2017 12:25:54 +0200
Content-Type: multipart/signed; micalg="pgp-sha1";
	protocol="application/pgp-signature"; 
	boundary="=-OOc5LWwZ+YazWezy+WUi"
X-Mailer: Evolution 3.22.6-1 
Mime-Version: 1.0
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
	[fuzzy]
X-Received-From: 188.40.100.199
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel/>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Apr 2017 10:26:19 -0000


--=-OOc5LWwZ+YazWezy+WUi
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Dear GRUB folks,


When using GRUB as a coreboot payload, that means passing `--with-
platform=3Dcoreboot` to configure, and configuring it to load the GRUB
configuration file from disk, `/boot/grub/grub.cfg` in Debian 8.7
(Jessie/stable) and 9 (Stretch/testing), generated by GRUB shipped by
the GNU/Linux distribution, I get a warning about the missing module
`all_video.mod`, and the enter key has to be pressed to continue
booting.

The function `load_video` in `/boot/grub/grub.cfg` is causing this.

```
function load_video {
=C2=A0 if [ x$feature_all_video_module =3D xy ]; then
=C2=A0=C2=A0=C2=A0=C2=A0insmod all_video
=C2=A0 else
=C2=A0=C2=A0=C2=A0=C2=A0insmod efi_gop
=C2=A0=C2=A0=C2=A0=C2=A0insmod efi_uga
=C2=A0=C2=A0=C2=A0=C2=A0insmod ieee1275_fb
=C2=A0=C2=A0=C2=A0=C2=A0insmod vbe
=C2=A0=C2=A0=C2=A0=C2=A0insmod vga
=C2=A0=C2=A0=C2=A0=C2=A0insmod video_bochs
=C2=A0=C2=A0=C2=A0=C2=A0insmod video_cirrus
=C2=A0 fi
}
```

This get added by `update-grub` from `/etc/grub.d/00_header`.

```
cat <<EOF
function load_video {
EOF
if [ -n "${GRUB_VIDEO_BACKEND}" ]; then
=C2=A0=C2=A0=C2=A0=C2=A0cat <<EOF
=C2=A0 insmod ${GRUB_VIDEO_BACKEND}
EOF
else
# If all_video.mod isn't available load all modules available
# with versions prior to introduction of all_video.mod
cat <<EOF
=C2=A0 if [ x\$feature_all_video_module =3D xy ]; then
=C2=A0=C2=A0=C2=A0=C2=A0insmod all_video
=C2=A0 else
=C2=A0=C2=A0=C2=A0=C2=A0insmod efi_gop
=C2=A0=C2=A0=C2=A0=C2=A0insmod efi_uga
=C2=A0=C2=A0=C2=A0=C2=A0insmod ieee1275_fb
=C2=A0=C2=A0=C2=A0=C2=A0insmod vbe
=C2=A0=C2=A0=C2=A0=C2=A0insmod vga
=C2=A0=C2=A0=C2=A0=C2=A0insmod video_bochs
=C2=A0=C2=A0=C2=A0=C2=A0insmod video_cirrus
=C2=A0 fi
EOF
fi
```

Do you know of a way to make that compatible with grub-pc and GRUB
payload? That=E2=80=99s useful, as the hard disk can be connected to a syst=
em
running coreboot with SeaBIOS or GRUB as a payload, or a proprietary
vendor firmware.


Kind regards,

Paul
--=-OOc5LWwZ+YazWezy+WUi
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQQ8+w9d414FAVARIpk9fVorbA4dWAUCWPH1MgAKCRA9fVorbA4d
WBgWAJ4tiRixrWWxlmcM6xSK2NnF0BshnwCePMhu1NarjoroDs4doeRbYU2jE54=
=U6sl
-----END PGP SIGNATURE-----

--=-OOc5LWwZ+YazWezy+WUi--