From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. Date: Tue, 18 Apr 2017 12:14:00 +0200 Message-ID: <1492510440.27392.27.camel@redhat.com> References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <20170411103101.0497fe08@eldfell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Michel =?ISO-8859-1?Q?D=E4nzer?= Cc: Daniel Vetter , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ilia Mirkin , open list ICBIaSwKCj4gPiBRdWl0ZSB0cnVlIHRoYXQgdGhpcyBwcm92ZXMgbm90aGluZy4gSG93ZXZlciBv bmUgc2hvdWxkIG5vdGUgdGhhdAo+ID4gZmJjb24gLT4gZmJkZXYgd29ya3MsCj4gCj4gQlRXLCB0 aGlzIHN1cHBvcnRzIEdlcmQncyBwYXRjaCwgc2luY2UgdGhlIEtNUyBmYmRldiBlbXVsYXRpb24g Y29kZSB1c2VzCj4gZS5nLiBEUk1fRk9STUFUX1hSR0I4ODg4IGZvciBkZXB0aC9icHAgMjQvMzIs IGFuZCB0aGUgZmJkZXYgQVBJIHVzZXMKPiBuYXRpdmUgZW5kaWFuIHBhY2tlZCBjb2xvdXIgdmFs dWVzLgoKU2FtZSBpcyB0cnVlIGZvciBEUk1fSU9DVExfTU9ERV9BRERGQiwgd2l0aCBkZXB0aC9i cHAgMjQvMzIgeW91J2xsIGdldApEUk1fRk9STUFUX1hSR0I4ODg4IChvbmx5IERSTV9JT0NUTF9N T0RFX0FEREZCMiBhbGxvd3MgdXNlcnNwYWNlIHNwZWNpZnkKZm91cmNjIGZvcm1hdHMgZGlyZWN0 bHkpLgoKY2hlZXJzLAogIEdlcmQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1k LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756924AbdDRKON convert rfc822-to-8bit (ORCPT ); Tue, 18 Apr 2017 06:14:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56682 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755138AbdDRKOI (ORCPT ); Tue, 18 Apr 2017 06:14:08 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 755A619D241 Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 755A619D241 Message-ID: <1492510440.27392.27.camel@redhat.com> Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. From: Gerd Hoffmann To: Michel =?ISO-8859-1?Q?D=E4nzer?= Cc: Ilia Mirkin , amd-gfx@lists.freedesktop.org, open list , "dri-devel@lists.freedesktop.org" , Daniel Vetter Date: Tue, 18 Apr 2017 12:14:00 +0200 In-Reply-To: References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <20170411103101.0497fe08@eldfell> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 18 Apr 2017 10:14:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Quite true that this proves nothing. However one should note that > > fbcon -> fbdev works, > > BTW, this supports Gerd's patch, since the KMS fbdev emulation code uses > e.g. DRM_FORMAT_XRGB8888 for depth/bpp 24/32, and the fbdev API uses > native endian packed colour values. Same is true for DRM_IOCTL_MODE_ADDFB, with depth/bpp 24/32 you'll get DRM_FORMAT_XRGB8888 (only DRM_IOCTL_MODE_ADDFB2 allows userspace specify fourcc formats directly). cheers, Gerd