From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932410AbdDRKcu (ORCPT ); Tue, 18 Apr 2017 06:32:50 -0400 Received: from smtprelay0073.hostedemail.com ([216.40.44.73]:55484 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755286AbdDRKcs (ORCPT ); Tue, 18 Apr 2017 06:32:48 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4605:5007:7522:7903:8660:10004:10400:10848:11026:11232:11658:11914:12740:12760:12895:13069:13148:13230:13311:13357:13439:14659:14721:14777:21080:21433:21451:30022:30029:30030:30046:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: color72_51ecb7d108d4a X-Filterd-Recvd-Size: 2129 Message-ID: <1492511561.8661.34.camel@perches.com> Subject: Re: [PATCH 1/1] drivers/staging/vt6656/main_usb.c: usb_device_reset From: Joe Perches To: Greg KH , Chewie Lin Cc: forest@alittletooquiet.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 18 Apr 2017 03:32:41 -0700 In-Reply-To: <20170418083348.GA4366@kroah.com> References: <20170418082437.25451-1-linsh@oregonstate.edu> <20170418082437.25451-2-linsh@oregonstate.edu> <20170418083348.GA4366@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-18 at 10:33 +0200, Greg KH wrote: > On Tue, Apr 18, 2017 at 01:24:37AM -0700, Chewie Lin wrote: > > Removed the usb_device_reset(), replace with call to usb_reset_device() > > directly. Plus it removes the confusing function name and addressed > > the checkpatch warning as well by swap string in the dev_warn() call with > > __func__ argument, instead of explicitly calling the function name in > > the string: > > > > WARNING: Prefer using "%s", __func__ to embedded function names > > #417: FILE: main_usb.c:417: > > + "usb_device_reset fail status=%d\n", status); > > > > total: 0 errors, 1 warnings, 1058 lines checked > > > > And after fix: > > > > main_usb.c has no obvious style problems and is ready for submission. > > > > > > Signed-off-by: Chewie Lin > > Your subject line is odd, don't you think? Compare it to other patches > for this driver and please fix it up and resend. > > And there's never a need for a 0/X email for a single patch submission, > no need to do that again. And __func__ here is vt6656_probe not usb_reset_device. usb_reset_device is the function that failed.