From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755370AbdDRMDQ (ORCPT ); Tue, 18 Apr 2017 08:03:16 -0400 Received: from smtprelay0031.hostedemail.com ([216.40.44.31]:49344 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753061AbdDRMDO (ORCPT ); Tue, 18 Apr 2017 08:03:14 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:7514:7903:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13141:13230:13311:13357:13439:13618:14181:14659:14721:21080:21434:21451:30029:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: bear34_903997874cd1d X-Filterd-Recvd-Size: 1541 Message-ID: <1492516989.8661.36.camel@perches.com> Subject: Re: [PATCH] staging : rtl8188eu : remove void function return From: Joe Perches To: Greg KH , surenderpolsani Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 18 Apr 2017 05:03:09 -0700 In-Reply-To: <20170418115249.GD17911@kroah.com> References: <1492237646-4174-1-git-send-email-surenderpolsani@gmail.com> <20170418115249.GD17911@kroah.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-18 at 13:52 +0200, Greg KH wrote: > On Sat, Apr 15, 2017 at 11:57:26AM +0530, surenderpolsani wrote: > > kernel coding style doesn't allow the return statement > > in void function. > > > > Signed-off-by: surenderpolsani > > I need a "real" name here, and in the from line please. Use what you > use to sign documents. You'll also need a patch that compiles properly. void foo(void) { goto bar; bar: } doesn't compile with gcc. This patch removes the required statement after the label immediately before the function end. It could be replaced by just a semicolon which is done a few places in the kernel or just left as-is.