diff for duplicates of <1492518199.7548.8.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 53e6b90..adee8c9 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ Hello Frank, -On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote: +On Mon, 2017-04-17 at 20:15 -0700, Frank Rowand wrote: > On 04/13/17 05:33, Alexey Brodkin wrote: > > > > DWC3 driver uses of_usb_get_phy_mode() which is @@ -12,38 +12,38 @@ On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote: > > > > On building all ends-up with: > > ---------------------->8------------------ -> > ? Kernel: arch/arm/boot/Image is ready -> > ? Kernel: arch/arm/boot/zImage is ready -> > ? Building modules, stage 2. -> > ? MODPOST 5 modules +> > Kernel: arch/arm/boot/Image is ready +> > Kernel: arch/arm/boot/zImage is ready +> > Building modules, stage 2. +> > MODPOST 5 modules > > ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > ---------------------->8------------------ > > -> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com> -> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> -> > Cc: Masahiro Yamada <yamada.masahiro at socionext.com> -> > Cc: Geert Uytterhoeven <geert+renesas at glider.be> -> > Cc: Nicolas Pitre <nicolas.pitre at linaro.org> -> > Cc: Thomas Gleixner <tglx at linutronix.de> -> > Cc: Felipe Balbi <balbi at kernel.org> -> > Cc: Felix Fietkau <nbd at nbd.name> -> > Cc: Jeremy Kerr <jk at ozlabs.org> -> > Cc: linux-snps-arc at lists.infradead.org -> > Cc: stable at vger.kernel.org +> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> +> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> +> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> +> > Cc: Nicolas Pitre <nicolas.pitre@linaro.org> +> > Cc: Thomas Gleixner <tglx@linutronix.de> +> > Cc: Felipe Balbi <balbi@kernel.org> +> > Cc: Felix Fietkau <nbd@nbd.name> +> > Cc: Jeremy Kerr <jk@ozlabs.org> +> > Cc: linux-snps-arc@lists.infradead.org +> > Cc: stable@vger.kernel.org > > --- -> > ?drivers/Makefile | 1 + -> > ?1 file changed, 1 insertion(+) +> > drivers/Makefile | 1 + +> > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 2eced9afba53..8f8bdc9e3d29 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY) += usb/ -> > ?obj-$(CONFIG_USB) += usb/ -> > ?obj-$(CONFIG_PCI) += usb/ -> > ?obj-$(CONFIG_USB_GADGET) += usb/ +> > obj-$(CONFIG_USB) += usb/ +> > obj-$(CONFIG_PCI) += usb/ +> > obj-$(CONFIG_USB_GADGET) += usb/ > > > > > +obj-$(CONFIG_OF) += usb/ @@ -57,10 +57,22 @@ So I took a look at how components get enabled and saw quite mixed stuff. In "drivers/usb/phy/Makefile" we see: ------------------------->8--------------------------- -obj-$(CONFIG_OF)????????????????????????+= of.o +obj-$(CONFIG_OF)» » » += of.o ------------------------->8--------------------------- In "drivers/usb/Makefile" we see: ------------------------->8--------------------------- -obj-$(CONFIG_USB_SUPPORT)???????+= phy/ +obj-$(CONFIG_USB_SUPPORT)» += phy/ ------------------------->8--------------------------- + +>From above I may conclude that your proposal should work as well +but it's more a question of which approach is safer and more future proof. + +Maybe it even worth adding the following to "drivers/usb/Makefile": +------------------------->8--------------------------- +obj-$(CONFIG_USB_SUPPORT)» += phy/ +------------------------->8--------------------------- + +Any thoughts are more than welcome. + +-Alexey diff --git a/a/content_digest b/N1/content_digest index aabd588..761a05f 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,26 @@ "ref\01492086814-21006-1-git-send-email-abrodkin@synopsys.com\0" "ref\058F584C9.3050607@gmail.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH] usb: Make sure usb/phy/of gets built-in\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH] usb: Make sure usb/phy/of gets built-in\0" "Date\0Tue, 18 Apr 2017 12:23:20 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0frowand.list@gmail.com <frowand.list@gmail.com>\0" + "Cc\0jk@ozlabs.org <jk@ozlabs.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + linux-usb@vger.kernel.org <linux-usb@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + nbd@nbd.name <nbd@nbd.name> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + stable@vger.kernel.org <stable@vger.kernel.org> + nicolas.pitre@linaro.org <nicolas.pitre@linaro.org> + balbi@kernel.org <balbi@kernel.org> + yamada.masahiro@socionext.com <yamada.masahiro@socionext.com> + geert+renesas@glider.be <geert+renesas@glider.be> + " gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>\0" "\00:1\0" "b\0" "Hello Frank,\n" "\n" - "On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote:\n" + "On Mon, 2017-04-17 at 20:15 -0700, Frank Rowand wrote:\n" "> On 04/13/17 05:33, Alexey Brodkin wrote:\n" "> > \n" "> > DWC3 driver uses of_usb_get_phy_mode() which is\n" @@ -20,38 +32,38 @@ "> > \n" "> > On building all ends-up with:\n" "> > ---------------------->8------------------\n" - "> > ? Kernel: arch/arm/boot/Image is ready\n" - "> > ? Kernel: arch/arm/boot/zImage is ready\n" - "> > ? Building modules, stage 2.\n" - "> > ? MODPOST 5 modules\n" + "> > \302\240 Kernel: arch/arm/boot/Image is ready\n" + "> > \302\240 Kernel: arch/arm/boot/zImage is ready\n" + "> > \302\240 Building modules, stage 2.\n" + "> > \302\240 MODPOST 5 modules\n" "> > ERROR: \"of_usb_get_phy_mode\" [drivers/usb/dwc3/dwc3.ko] undefined!\n" "> > make[1]: *** [__modpost] Error 1\n" "> > make: *** [modules] Error 2\n" "> > ---------------------->8------------------\n" "> > \n" - "> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>\n" - "> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>\n" - "> > Cc: Masahiro Yamada <yamada.masahiro at socionext.com>\n" - "> > Cc: Geert Uytterhoeven <geert+renesas at glider.be>\n" - "> > Cc: Nicolas Pitre <nicolas.pitre at linaro.org>\n" - "> > Cc: Thomas Gleixner <tglx at linutronix.de>\n" - "> > Cc: Felipe Balbi <balbi at kernel.org>\n" - "> > Cc: Felix Fietkau <nbd at nbd.name>\n" - "> > Cc: Jeremy Kerr <jk at ozlabs.org>\n" - "> > Cc: linux-snps-arc at lists.infradead.org\n" - "> > Cc: stable at vger.kernel.org\n" + "> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>\n" + "> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n" + "> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>\n" + "> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>\n" + "> > Cc: Nicolas Pitre <nicolas.pitre@linaro.org>\n" + "> > Cc: Thomas Gleixner <tglx@linutronix.de>\n" + "> > Cc: Felipe Balbi <balbi@kernel.org>\n" + "> > Cc: Felix Fietkau <nbd@nbd.name>\n" + "> > Cc: Jeremy Kerr <jk@ozlabs.org>\n" + "> > Cc: linux-snps-arc@lists.infradead.org\n" + "> > Cc: stable@vger.kernel.org\n" "> > ---\n" - "> > ?drivers/Makefile | 1 +\n" - "> > ?1 file changed, 1 insertion(+)\n" + "> > \302\240drivers/Makefile | 1 +\n" + "> > \302\2401 file changed, 1 insertion(+)\n" "> > \n" "> > diff --git a/drivers/Makefile b/drivers/Makefile\n" "> > index 2eced9afba53..8f8bdc9e3d29 100644\n" "> > --- a/drivers/Makefile\n" "> > +++ b/drivers/Makefile\n" "> > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY)\t\t+= usb/\n" - "> > ?obj-$(CONFIG_USB)\t\t+= usb/\n" - "> > ?obj-$(CONFIG_PCI)\t\t+= usb/\n" - "> > ?obj-$(CONFIG_USB_GADGET)\t+= usb/\n" + "> > \302\240obj-$(CONFIG_USB)\t\t+= usb/\n" + "> > \302\240obj-$(CONFIG_PCI)\t\t+= usb/\n" + "> > \302\240obj-$(CONFIG_USB_GADGET)\t+= usb/\n" "> \n" "> > \n" "> > +obj-$(CONFIG_OF)\t\t+= usb/\n" @@ -65,12 +77,24 @@ "\n" "In \"drivers/usb/phy/Makefile\" we see:\n" "------------------------->8---------------------------\n" - "obj-$(CONFIG_OF)????????????????????????+= of.o\n" + "obj-$(CONFIG_OF)\302\273\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\273\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\273\302\240\302\240\302\240\302\240\302\240\302\240\302\240+= of.o\n" "------------------------->8---------------------------\n" "\n" "In \"drivers/usb/Makefile\" we see:\n" "------------------------->8---------------------------\n" - "obj-$(CONFIG_USB_SUPPORT)???????+= phy/\n" - ------------------------->8--------------------------- + "obj-$(CONFIG_USB_SUPPORT)\302\273\302\240\302\240\302\240\302\240\302\240\302\240+= phy/\n" + "------------------------->8---------------------------\n" + "\n" + ">From above I may conclude that your proposal should work as well\n" + "but it's more a question of which approach is safer and more future proof.\n" + "\n" + "Maybe it even worth adding the following to \"drivers/usb/Makefile\":\n" + "------------------------->8---------------------------\n" + "obj-$(CONFIG_USB_SUPPORT)\302\273\302\240\302\240\302\240\302\240\302\240\302\240+= phy/\n" + "------------------------->8---------------------------\n" + "\n" + "Any thoughts are more than welcome.\n" + "\n" + -Alexey -5e715381228d6ed90bb0feb8ad7880868f50c5e152b7ee68b7e719f63cdcf82d +3c554e75e2ffe0c60ed9c956eed2873dc9b879483be76fc689d7a6a336a20c38
diff --git a/a/1.txt b/N2/1.txt index 53e6b90..5e50792 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,6 +1,6 @@ Hello Frank, -On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote: +On Mon, 2017-04-17 at 20:15 -0700, Frank Rowand wrote: > On 04/13/17 05:33, Alexey Brodkin wrote: > > > > DWC3 driver uses of_usb_get_phy_mode() which is @@ -12,38 +12,38 @@ On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote: > > > > On building all ends-up with: > > ---------------------->8------------------ -> > ? Kernel: arch/arm/boot/Image is ready -> > ? Kernel: arch/arm/boot/zImage is ready -> > ? Building modules, stage 2. -> > ? MODPOST 5 modules +> > Kernel: arch/arm/boot/Image is ready +> > Kernel: arch/arm/boot/zImage is ready +> > Building modules, stage 2. +> > MODPOST 5 modules > > ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > ---------------------->8------------------ > > -> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com> -> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org> -> > Cc: Masahiro Yamada <yamada.masahiro at socionext.com> -> > Cc: Geert Uytterhoeven <geert+renesas at glider.be> -> > Cc: Nicolas Pitre <nicolas.pitre at linaro.org> -> > Cc: Thomas Gleixner <tglx at linutronix.de> -> > Cc: Felipe Balbi <balbi at kernel.org> -> > Cc: Felix Fietkau <nbd at nbd.name> -> > Cc: Jeremy Kerr <jk at ozlabs.org> -> > Cc: linux-snps-arc at lists.infradead.org -> > Cc: stable at vger.kernel.org +> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> +> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> +> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com> +> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> +> > Cc: Nicolas Pitre <nicolas.pitre@linaro.org> +> > Cc: Thomas Gleixner <tglx@linutronix.de> +> > Cc: Felipe Balbi <balbi@kernel.org> +> > Cc: Felix Fietkau <nbd@nbd.name> +> > Cc: Jeremy Kerr <jk@ozlabs.org> +> > Cc: linux-snps-arc@lists.infradead.org +> > Cc: stable@vger.kernel.org > > --- -> > ?drivers/Makefile | 1 + -> > ?1 file changed, 1 insertion(+) +> > drivers/Makefile | 1 + +> > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 2eced9afba53..8f8bdc9e3d29 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY) += usb/ -> > ?obj-$(CONFIG_USB) += usb/ -> > ?obj-$(CONFIG_PCI) += usb/ -> > ?obj-$(CONFIG_USB_GADGET) += usb/ +> > obj-$(CONFIG_USB) += usb/ +> > obj-$(CONFIG_PCI) += usb/ +> > obj-$(CONFIG_USB_GADGET) += usb/ > > > > > +obj-$(CONFIG_OF) += usb/ @@ -57,10 +57,22 @@ So I took a look at how components get enabled and saw quite mixed stuff. In "drivers/usb/phy/Makefile" we see: ------------------------->8--------------------------- -obj-$(CONFIG_OF)????????????????????????+= of.o +obj-$(CONFIG_OF)» » » += of.o ------------------------->8--------------------------- In "drivers/usb/Makefile" we see: ------------------------->8--------------------------- -obj-$(CONFIG_USB_SUPPORT)???????+= phy/ +obj-$(CONFIG_USB_SUPPORT)» += phy/ ------------------------->8--------------------------- + +From above I may conclude that your proposal should work as well +but it's more a question of which approach is safer and more future proof. + +Maybe it even worth adding the following to "drivers/usb/Makefile": +------------------------->8--------------------------- +obj-$(CONFIG_USB_SUPPORT)» += phy/ +------------------------->8--------------------------- + +Any thoughts are more than welcome. + +-Alexey diff --git a/a/content_digest b/N2/content_digest index aabd588..f7203dd 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,14 +1,26 @@ "ref\01492086814-21006-1-git-send-email-abrodkin@synopsys.com\0" "ref\058F584C9.3050607@gmail.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH] usb: Make sure usb/phy/of gets built-in\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH] usb: Make sure usb/phy/of gets built-in\0" "Date\0Tue, 18 Apr 2017 12:23:20 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0frowand.list@gmail.com <frowand.list@gmail.com>\0" + "Cc\0jk@ozlabs.org <jk@ozlabs.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + linux-usb@vger.kernel.org <linux-usb@vger.kernel.org> + tglx@linutronix.de <tglx@linutronix.de> + nbd@nbd.name <nbd@nbd.name> + linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> + stable@vger.kernel.org <stable@vger.kernel.org> + nicolas.pitre@linaro.org <nicolas.pitre@linaro.org> + balbi@kernel.org <balbi@kernel.org> + yamada.masahiro@socionext.com <yamada.masahiro@socionext.com> + geert+renesas@glider.be <geert+renesas@glider.be> + " gregkh@linuxfoundation.org <gregkh@linuxfoundation.org>\0" "\00:1\0" "b\0" "Hello Frank,\n" "\n" - "On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote:\n" + "On Mon, 2017-04-17 at 20:15 -0700, Frank Rowand wrote:\n" "> On 04/13/17 05:33, Alexey Brodkin wrote:\n" "> > \n" "> > DWC3 driver uses of_usb_get_phy_mode() which is\n" @@ -20,38 +32,38 @@ "> > \n" "> > On building all ends-up with:\n" "> > ---------------------->8------------------\n" - "> > ? Kernel: arch/arm/boot/Image is ready\n" - "> > ? Kernel: arch/arm/boot/zImage is ready\n" - "> > ? Building modules, stage 2.\n" - "> > ? MODPOST 5 modules\n" + "> > \302\240 Kernel: arch/arm/boot/Image is ready\n" + "> > \302\240 Kernel: arch/arm/boot/zImage is ready\n" + "> > \302\240 Building modules, stage 2.\n" + "> > \302\240 MODPOST 5 modules\n" "> > ERROR: \"of_usb_get_phy_mode\" [drivers/usb/dwc3/dwc3.ko] undefined!\n" "> > make[1]: *** [__modpost] Error 1\n" "> > make: *** [modules] Error 2\n" "> > ---------------------->8------------------\n" "> > \n" - "> > Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>\n" - "> > Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>\n" - "> > Cc: Masahiro Yamada <yamada.masahiro at socionext.com>\n" - "> > Cc: Geert Uytterhoeven <geert+renesas at glider.be>\n" - "> > Cc: Nicolas Pitre <nicolas.pitre at linaro.org>\n" - "> > Cc: Thomas Gleixner <tglx at linutronix.de>\n" - "> > Cc: Felipe Balbi <balbi at kernel.org>\n" - "> > Cc: Felix Fietkau <nbd at nbd.name>\n" - "> > Cc: Jeremy Kerr <jk at ozlabs.org>\n" - "> > Cc: linux-snps-arc at lists.infradead.org\n" - "> > Cc: stable at vger.kernel.org\n" + "> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>\n" + "> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n" + "> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>\n" + "> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>\n" + "> > Cc: Nicolas Pitre <nicolas.pitre@linaro.org>\n" + "> > Cc: Thomas Gleixner <tglx@linutronix.de>\n" + "> > Cc: Felipe Balbi <balbi@kernel.org>\n" + "> > Cc: Felix Fietkau <nbd@nbd.name>\n" + "> > Cc: Jeremy Kerr <jk@ozlabs.org>\n" + "> > Cc: linux-snps-arc@lists.infradead.org\n" + "> > Cc: stable@vger.kernel.org\n" "> > ---\n" - "> > ?drivers/Makefile | 1 +\n" - "> > ?1 file changed, 1 insertion(+)\n" + "> > \302\240drivers/Makefile | 1 +\n" + "> > \302\2401 file changed, 1 insertion(+)\n" "> > \n" "> > diff --git a/drivers/Makefile b/drivers/Makefile\n" "> > index 2eced9afba53..8f8bdc9e3d29 100644\n" "> > --- a/drivers/Makefile\n" "> > +++ b/drivers/Makefile\n" "> > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY)\t\t+= usb/\n" - "> > ?obj-$(CONFIG_USB)\t\t+= usb/\n" - "> > ?obj-$(CONFIG_PCI)\t\t+= usb/\n" - "> > ?obj-$(CONFIG_USB_GADGET)\t+= usb/\n" + "> > \302\240obj-$(CONFIG_USB)\t\t+= usb/\n" + "> > \302\240obj-$(CONFIG_PCI)\t\t+= usb/\n" + "> > \302\240obj-$(CONFIG_USB_GADGET)\t+= usb/\n" "> \n" "> > \n" "> > +obj-$(CONFIG_OF)\t\t+= usb/\n" @@ -65,12 +77,24 @@ "\n" "In \"drivers/usb/phy/Makefile\" we see:\n" "------------------------->8---------------------------\n" - "obj-$(CONFIG_OF)????????????????????????+= of.o\n" + "obj-$(CONFIG_OF)\302\273\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\273\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\273\302\240\302\240\302\240\302\240\302\240\302\240\302\240+= of.o\n" "------------------------->8---------------------------\n" "\n" "In \"drivers/usb/Makefile\" we see:\n" "------------------------->8---------------------------\n" - "obj-$(CONFIG_USB_SUPPORT)???????+= phy/\n" - ------------------------->8--------------------------- + "obj-$(CONFIG_USB_SUPPORT)\302\273\302\240\302\240\302\240\302\240\302\240\302\240+= phy/\n" + "------------------------->8---------------------------\n" + "\n" + "From above I may conclude that your proposal should work as well\n" + "but it's more a question of which approach is safer and more future proof.\n" + "\n" + "Maybe it even worth adding the following to \"drivers/usb/Makefile\":\n" + "------------------------->8---------------------------\n" + "obj-$(CONFIG_USB_SUPPORT)\302\273\302\240\302\240\302\240\302\240\302\240\302\240+= phy/\n" + "------------------------->8---------------------------\n" + "\n" + "Any thoughts are more than welcome.\n" + "\n" + -Alexey -5e715381228d6ed90bb0feb8ad7880868f50c5e152b7ee68b7e719f63cdcf82d +03b4d2a29c235629912ab77e49f5558b4569e78b6516b0789b542aa97a223091
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.