From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Tue, 18 Apr 2017 12:23:20 +0000 Subject: [PATCH] usb: Make sure usb/phy/of gets built-in In-Reply-To: <58F584C9.3050607@gmail.com> References: <1492086814-21006-1-git-send-email-abrodkin@synopsys.com> <58F584C9.3050607@gmail.com> List-ID: Message-ID: <1492518199.7548.8.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hello Frank, On Mon, 2017-04-17@20:15 -0700, Frank Rowand wrote: > On 04/13/17 05:33, Alexey Brodkin wrote: > > > > DWC3 driver uses of_usb_get_phy_mode() which is > > implemented in drivers/usb/phy/of.c and in bare minimal > > configuration it might not be pulled in kernel binary. > > > > In case of ARC or ARM this could be easily reproduced with > > "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m. > > > > On building all ends-up with: > > ---------------------->8------------------ > > ? Kernel: arch/arm/boot/Image is ready > > ? Kernel: arch/arm/boot/zImage is ready > > ? Building modules, stage 2. > > ? MODPOST 5 modules > > ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > ---------------------->8------------------ > > > > Signed-off-by: Alexey Brodkin > > Cc: Greg Kroah-Hartman > > Cc: Masahiro Yamada > > Cc: Geert Uytterhoeven > > Cc: Nicolas Pitre > > Cc: Thomas Gleixner > > Cc: Felipe Balbi > > Cc: Felix Fietkau > > Cc: Jeremy Kerr > > Cc: linux-snps-arc at lists.infradead.org > > Cc: stable at vger.kernel.org > > --- > > ?drivers/Makefile | 1 + > > ?1 file changed, 1 insertion(+) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 2eced9afba53..8f8bdc9e3d29 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY) += usb/ > > ?obj-$(CONFIG_USB) += usb/ > > ?obj-$(CONFIG_PCI) += usb/ > > ?obj-$(CONFIG_USB_GADGET) += usb/ > > > > > +obj-$(CONFIG_OF) += usb/ > > Would CONFIG_USB_SUPPORT make more sense? (And does it work?) Well I'm not really sure here. The problem was in missing "drivers/usb/phy/of.o" in "drivers/usb/built-in.o". So I took a look at how components get enabled and saw quite mixed stuff. In "drivers/usb/phy/Makefile" we see: ------------------------->8--------------------------- obj-$(CONFIG_OF)????????????????????????+= of.o ------------------------->8--------------------------- In "drivers/usb/Makefile" we see: ------------------------->8--------------------------- obj-$(CONFIG_USB_SUPPORT)???????+= phy/ ------------------------->8--------------------------- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755769AbdDRMXa (ORCPT ); Tue, 18 Apr 2017 08:23:30 -0400 Received: from smtprelay.synopsys.com ([198.182.47.9]:60920 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbdDRMX2 (ORCPT ); Tue, 18 Apr 2017 08:23:28 -0400 From: Alexey Brodkin To: "frowand.list@gmail.com" CC: "jk@ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "tglx@linutronix.de" , "nbd@nbd.name" , "linux-snps-arc@lists.infradead.org" , "stable@vger.kernel.org" , "nicolas.pitre@linaro.org" , "balbi@kernel.org" , "yamada.masahiro@socionext.com" , "geert+renesas@glider.be" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH] usb: Make sure usb/phy/of gets built-in Thread-Topic: [PATCH] usb: Make sure usb/phy/of gets built-in Thread-Index: AQHStFIx9N3eCCp1Jkq4gK2YE9IKuqHKWdqAgACZGoA= Date: Tue, 18 Apr 2017 12:23:20 +0000 Message-ID: <1492518199.7548.8.camel@synopsys.com> References: <1492086814-21006-1-git-send-email-abrodkin@synopsys.com> <58F584C9.3050607@gmail.com> In-Reply-To: <58F584C9.3050607@gmail.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.121.8.101] Content-Type: text/plain; charset="utf-8" Content-ID: <1257D743C3A6D0469D54922743527635@internal.synopsys.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3ICNZAI002765 Hello Frank, On Mon, 2017-04-17 at 20:15 -0700, Frank Rowand wrote: > On 04/13/17 05:33, Alexey Brodkin wrote: > > > > DWC3 driver uses of_usb_get_phy_mode() which is > > implemented in drivers/usb/phy/of.c and in bare minimal > > configuration it might not be pulled in kernel binary. > > > > In case of ARC or ARM this could be easily reproduced with > > "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m. > > > > On building all ends-up with: > > ---------------------->8------------------ > >   Kernel: arch/arm/boot/Image is ready > >   Kernel: arch/arm/boot/zImage is ready > >   Building modules, stage 2. > >   MODPOST 5 modules > > ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > ---------------------->8------------------ > > > > Signed-off-by: Alexey Brodkin > > Cc: Greg Kroah-Hartman > > Cc: Masahiro Yamada > > Cc: Geert Uytterhoeven > > Cc: Nicolas Pitre > > Cc: Thomas Gleixner > > Cc: Felipe Balbi > > Cc: Felix Fietkau > > Cc: Jeremy Kerr > > Cc: linux-snps-arc@lists.infradead.org > > Cc: stable@vger.kernel.org > > --- > >  drivers/Makefile | 1 + > >  1 file changed, 1 insertion(+) > > > > diff --git a/drivers/Makefile b/drivers/Makefile > > index 2eced9afba53..8f8bdc9e3d29 100644 > > --- a/drivers/Makefile > > +++ b/drivers/Makefile > > @@ -104,6 +104,7 @@ obj-$(CONFIG_USB_PHY) += usb/ > >  obj-$(CONFIG_USB) += usb/ > >  obj-$(CONFIG_PCI) += usb/ > >  obj-$(CONFIG_USB_GADGET) += usb/ > > > > > +obj-$(CONFIG_OF) += usb/ > > Would CONFIG_USB_SUPPORT make more sense? (And does it work?) Well I'm not really sure here. The problem was in missing "drivers/usb/phy/of.o" in "drivers/usb/built-in.o". So I took a look at how components get enabled and saw quite mixed stuff. In "drivers/usb/phy/Makefile" we see: ------------------------->8--------------------------- obj-$(CONFIG_OF)»       »       »       += of.o ------------------------->8--------------------------- In "drivers/usb/Makefile" we see: ------------------------->8--------------------------- obj-$(CONFIG_USB_SUPPORT)»      += phy/ ------------------------->8--------------------------- >>From above I may conclude that your proposal should work as well but it's more a question of which approach is safer and more future proof. Maybe it even worth adding the following to "drivers/usb/Makefile": ------------------------->8--------------------------- obj-$(CONFIG_USB_SUPPORT)»      += phy/ ------------------------->8--------------------------- Any thoughts are more than welcome. -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtprelay.synopsys.com ([198.182.47.9]:60920 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbdDRMX2 (ORCPT ); Tue, 18 Apr 2017 08:23:28 -0400 From: Alexey Brodkin To: "frowand.list@gmail.com" CC: "jk@ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "tglx@linutronix.de" , "nbd@nbd.name" , "linux-snps-arc@lists.infradead.org" , "stable@vger.kernel.org" , "nicolas.pitre@linaro.org" , "balbi@kernel.org" , "yamada.masahiro@socionext.com" , "geert+renesas@glider.be" , "gregkh@linuxfoundation.org" Subject: Re: [PATCH] usb: Make sure usb/phy/of gets built-in Date: Tue, 18 Apr 2017 12:23:20 +0000 Message-ID: <1492518199.7548.8.camel@synopsys.com> References: <1492086814-21006-1-git-send-email-abrodkin@synopsys.com> <58F584C9.3050607@gmail.com> In-Reply-To: <58F584C9.3050607@gmail.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <1257D743C3A6D0469D54922743527635@internal.synopsys.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: SGVsbG8gRnJhbmssDQoNCk9uIE1vbiwgMjAxNy0wNC0xNyBhdCAyMDoxNSAtMDcwMCwgRnJhbmsg Um93YW5kIHdyb3RlOg0KPiBPbiAwNC8xMy8xNyAwNTozMywgQWxleGV5IEJyb2RraW4gd3JvdGU6 DQo+ID4gDQo+ID4gRFdDMyBkcml2ZXIgdXNlcyBvZl91c2JfZ2V0X3BoeV9tb2RlKCkgd2hpY2gg aXMNCj4gPiBpbXBsZW1lbnRlZCBpbiBkcml2ZXJzL3VzYi9waHkvb2YuYyBhbmQgaW4gYmFyZSBt aW5pbWFsDQo+ID4gY29uZmlndXJhdGlvbiBpdCBtaWdodCBub3QgYmUgcHVsbGVkIGluIGtlcm5l bCBiaW5hcnkuDQo+ID4gDQo+ID4gSW4gY2FzZSBvZiBBUkMgb3IgQVJNIHRoaXMgY291bGQgYmUg ZWFzaWx5IHJlcHJvZHVjZWQgd2l0aA0KPiA+ICJhbGxub2RlZmNvbmZpZyIgK0NPTkZJR19VU0I9 bSArQ09ORklHX1VTQl9EV0MzPW0uDQo+ID4gDQo+ID4gT24gYnVpbGRpbmcgYWxsIGVuZHMtdXAg d2l0aDoNCj4gPiAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0NCj4g PiDCoCBLZXJuZWw6IGFyY2gvYXJtL2Jvb3QvSW1hZ2UgaXMgcmVhZHkNCj4gPiDCoCBLZXJuZWw6 IGFyY2gvYXJtL2Jvb3QvekltYWdlIGlzIHJlYWR5DQo+ID4gwqAgQnVpbGRpbmcgbW9kdWxlcywg c3RhZ2UgMi4NCj4gPiDCoCBNT0RQT1NUIDUgbW9kdWxlcw0KPiA+IEVSUk9SOiAib2ZfdXNiX2dl dF9waHlfbW9kZSIgW2RyaXZlcnMvdXNiL2R3YzMvZHdjMy5rb10gdW5kZWZpbmVkIQ0KPiA+IG1h a2VbMV06ICoqKiBbX19tb2Rwb3N0XSBFcnJvciAxDQo+ID4gbWFrZTogKioqIFttb2R1bGVzXSBF cnJvciAyDQo+ID4gLS0tLS0tLS0tLS0tLS0tLS0tLS0tLT44LS0tLS0tLS0tLS0tLS0tLS0tDQo+ ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogQWxleGV5IEJyb2RraW4gPGFicm9ka2luQHN5bm9wc3lz LmNvbT4NCj4gPiBDYzogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3VuZGF0aW9u Lm9yZz4NCj4gPiBDYzogTWFzYWhpcm8gWWFtYWRhIDx5YW1hZGEubWFzYWhpcm9Ac29jaW9uZXh0 LmNvbT4NCj4gPiBDYzogR2VlcnQgVXl0dGVyaG9ldmVuIDxnZWVydCtyZW5lc2FzQGdsaWRlci5i ZT4NCj4gPiBDYzogTmljb2xhcyBQaXRyZSA8bmljb2xhcy5waXRyZUBsaW5hcm8ub3JnPg0KPiA+ IENjOiBUaG9tYXMgR2xlaXhuZXIgPHRnbHhAbGludXRyb25peC5kZT4NCj4gPiBDYzogRmVsaXBl IEJhbGJpIDxiYWxiaUBrZXJuZWwub3JnPg0KPiA+IENjOiBGZWxpeCBGaWV0a2F1IDxuYmRAbmJk Lm5hbWU+DQo+ID4gQ2M6IEplcmVteSBLZXJyIDxqa0BvemxhYnMub3JnPg0KPiA+IENjOiBsaW51 eC1zbnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnDQo+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5l bC5vcmcNCj4gPiAtLS0NCj4gPiDCoGRyaXZlcnMvTWFrZWZpbGUgfCAxICsNCj4gPiDCoDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L01ha2VmaWxlIGIvZHJpdmVycy9NYWtlZmlsZQ0KPiA+IGluZGV4IDJlY2VkOWFmYmE1My4uOGY4 YmRjOWUzZDI5IDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvTWFrZWZpbGUNCj4gPiArKysgYi9k cml2ZXJzL01ha2VmaWxlDQo+ID4gQEAgLTEwNCw2ICsxMDQsNyBAQCBvYmotJChDT05GSUdfVVNC X1BIWSkJCSs9IHVzYi8NCj4gPiDCoG9iai0kKENPTkZJR19VU0IpCQkrPSB1c2IvDQo+ID4gwqBv YmotJChDT05GSUdfUENJKQkJKz0gdXNiLw0KPiA+IMKgb2JqLSQoQ09ORklHX1VTQl9HQURHRVQp CSs9IHVzYi8NCj4gDQo+ID4gDQo+ID4gK29iai0kKENPTkZJR19PRikJCSs9IHVzYi8NCj4gDQo+ IFdvdWxkIENPTkZJR19VU0JfU1VQUE9SVCBtYWtlIG1vcmUgc2Vuc2U/IChBbmQgZG9lcyBpdCB3 b3JrPykNCg0KV2VsbCBJJ20gbm90IHJlYWxseSBzdXJlIGhlcmUuDQoNClRoZSBwcm9ibGVtIHdh cyBpbiBtaXNzaW5nICJkcml2ZXJzL3VzYi9waHkvb2YubyIgaW4gImRyaXZlcnMvdXNiL2J1aWx0 LWluLm8iLg0KU28gSSB0b29rIGEgbG9vayBhdCBob3cgY29tcG9uZW50cyBnZXQgZW5hYmxlZCBh bmQgc2F3IHF1aXRlIG1peGVkIHN0dWZmLg0KDQpJbiAiZHJpdmVycy91c2IvcGh5L01ha2VmaWxl IiB3ZSBzZWU6DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0NCm9iai0kKENPTkZJR19PRinCu8KgwqDCoMKgwqDCoMKgwrvCoMKgwqDCoMKgwqDC oMK7wqDCoMKgwqDCoMKgwqArPSBvZi5vDQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCg0KSW4gImRyaXZlcnMvdXNiL01ha2VmaWxlIiB3ZSBz ZWU6DQotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0NCm9iai0kKENPTkZJR19VU0JfU1VQUE9SVCnCu8KgwqDCoMKgwqDCoCs9IHBoeS8NCi0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0+OC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KDQpGcm9t IGFib3ZlIEkgbWF5IGNvbmNsdWRlIHRoYXQgeW91ciBwcm9wb3NhbCBzaG91bGQgd29yayBhcyB3 ZWxsDQpidXQgaXQncyBtb3JlIGEgcXVlc3Rpb24gb2Ygd2hpY2ggYXBwcm9hY2ggaXMgc2FmZXIg YW5kIG1vcmUgZnV0dXJlIHByb29mLg0KDQpNYXliZSBpdCBldmVuIHdvcnRoIGFkZGluZyB0aGUg Zm9sbG93aW5nIHRvICJkcml2ZXJzL3VzYi9NYWtlZmlsZSI6DQotLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tPjgtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCm9iai0kKENPTkZJR19VU0JfU1VQ UE9SVCnCu8KgwqDCoMKgwqDCoCs9IHBoeS8NCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0+OC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KDQpBbnkgdGhvdWdodHMgYXJlIG1vcmUgdGhhbiB3 ZWxjb21lLg0KDQotQWxleGV5