From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. Date: Tue, 18 Apr 2017 15:39:53 +0200 Message-ID: <1492522793.27392.55.camel@redhat.com> References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <1492509617.27392.19.camel@redhat.com> <20170418141827.11634103@eldfell> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170418141827.11634103@eldfell> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Pekka Paalanen Cc: Daniel Vetter , amd-gfx@lists.freedesktop.org, open list , dri-devel@lists.freedesktop.org List-Id: amd-gfx.lists.freedesktop.org ICBIaSwKCj4gPiBIaXN0b3JpY2FsIG5vdGU6ICBSSEVMLTYuOSAoZ25vbWUgMikgd29ya3MgZmlu ZS4gIE5vdCBvZiBtdWNoIGludGVyZXN0Cj4gPiBoZXJlLCBpdCBkcml2ZXMgdGhlIHFlbXUgc3Rk dmdhIHdpdGggb2ZmYiwgbm90IGJvY2hzLWRybS4KPiAKPiBJIHN1cHBvc2UgdGhpcyBwcm92ZXMg dGhlIHZpcnR1YWwgbWFjaGluZSBpdHNlbGYgaXMgY29ycmVjdCBhYm91dAo+IGZyYW1lYnVmZmVy IGVuZGlhbmVzcz8gRXhjZXB0IHlvdSBhcmUgcnVubmluZyBpdCBvbiBhIGxpdHRsZS1lbmRpYW4K PiBob3N0IG1hY2hpbmUgSSBwcmVzdW1lLi4uCgpZZXMsIGxpdHRsZSBlbmRpYW4gaG9zdCwgcWVt dSBpbnRlcnByZXRzIHRoZSBmcmFtZWJ1ZmZlciBhcwpQSVhNQU5fYjhnOHI4eDguICBXaGljaCBz aG91bGQgYmUgY29ycmVjdCBmb3IgYSB4cmdiIGJpZ2VuZGlhbgpmcmFtZWJ1ZmZlciBhcyBwaXht YW4gZm9ybWF0cyBhcmUgbmF0aXZlIGVuZGlhbi4KCj4gPiBNb3JlIGludGVyZXN0aW5nOiAgUkhF TC03LjMgKGdub21lIDMuMTQpIHdvcmtzIGZpbmUgdG9vLiAga2VybmVsIDMuMTAsCj4gPiBidXQg ZHJtIGRyaXZlcnMgdXBkYXRlZCB0byByb3VnaGx5IDQuNiBsZXZlbC4gIFJ1bnMgYm9jaHMtZHJt LiAgbWVzYQo+ID4gMTEuMi4yLiAgZ2xhbW91ciBub3QgdXNlZC4KPiA+IAo+ID4gTW9zdCByZWNl bnQ6ICBGZWRvcmEgMjUgKGdub21lIDMuMjIpIGxvb2tzIG1vc3RseSBvaywgYnV0IHRoZXJlIGFy ZQo+ID4gcmVuZGVyaW5nIGdsaXRjaGVzLCBmb3IgZXhhbXBsZSBpbiB0aGUgZ25vbWUgYWN0aXZp dGllcyBzY3JlZW4gKHRoZSBvbmUKPiA+IHlvdSBnZXQgd2hlbiB5b3UgcHJlc3MgdGhlIHdpbmRv d3Mga2V5KS4gIGtlcm5lbCA0LjEwLCBtZXNhIDEzLjAuNC4KPiA+IGdsYW1vciBub3QgdXNlZCwg YnV0IEkgdGhpbmsgZ25vbWUtc2hlbGwgdXNlcyBvcGVuZ2wgKHZpYSBsbHZtcGlwZSkgZm9yCj4g PiBjb21wb3NpdGluZy4KPiAKPiBJIGJlbGlldmUgZ2xpdGNoZXMgYXJlIGlycmVsZXZhbnQgZm9y IHRoaXMgdG9waWMsIHdoYXQgd2UgYXJlCj4gaW50ZXJlc3RlZCBpbiBpcyBpZiB0aGUgY29sb3Jz IGFyZSByaWdodCBvciBieXRlLXN3YXBwZWQgKGFsc28gbWluZAo+IGFscGhhL2JsdWUgZXRjLiBz d2FwcykuCgpXZWxsLCBJIG1lYW4gY29sb3IgZ2xpdGNoZXMuICBCdXQgaXQgaXNuJ3QgY29uc2lz dGVudC4gIEFzIGlmIHNvbWUKb3BlcmF0aW9ucyBvcGVyYXRlIHdpdGggdGhlIGNvcnJlY3QgYnl0 ZW9yZGVyIGFuZCBzb21lIGRvbid0LgphbHBoYS9ibHVlIGJlaW5nIHN3YXBwZWQgaXMgYSBwcm9i bGVtIGluIHNvbWUgYXJlYXMuCgpodHRwczovL3d3dy5rcmF4ZWwub3JnL3RtcC8KCmNoZWVycywK ICBHZXJkCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755430AbdDRNj5 convert rfc822-to-8bit (ORCPT ); Tue, 18 Apr 2017 09:39:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53012 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751197AbdDRNjz (ORCPT ); Tue, 18 Apr 2017 09:39:55 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D8F9EC054905 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D8F9EC054905 Message-ID: <1492522793.27392.55.camel@redhat.com> Subject: Re: [RfC PATCH] drm: fourcc byteorder: brings header file comments in line with reality. From: Gerd Hoffmann To: Pekka Paalanen Cc: dri-devel@lists.freedesktop.org, open list , amd-gfx@lists.freedesktop.org, Daniel Vetter , Ilia Mirkin Date: Tue, 18 Apr 2017 15:39:53 +0200 In-Reply-To: <20170418141827.11634103@eldfell> References: <20170410101202.19229-1-kraxel@redhat.com> <20170410161214.305f5daf@eldfell> <1491833847.30990.77.camel@redhat.com> <20170410180941.43922e25@eldfell> <1492509617.27392.19.camel@redhat.com> <20170418141827.11634103@eldfell> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 18 Apr 2017 13:39:55 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Historical note: RHEL-6.9 (gnome 2) works fine. Not of much interest > > here, it drives the qemu stdvga with offb, not bochs-drm. > > I suppose this proves the virtual machine itself is correct about > framebuffer endianess? Except you are running it on a little-endian > host machine I presume... Yes, little endian host, qemu interprets the framebuffer as PIXMAN_b8g8r8x8. Which should be correct for a xrgb bigendian framebuffer as pixman formats are native endian. > > More interesting: RHEL-7.3 (gnome 3.14) works fine too. kernel 3.10, > > but drm drivers updated to roughly 4.6 level. Runs bochs-drm. mesa > > 11.2.2. glamour not used. > > > > Most recent: Fedora 25 (gnome 3.22) looks mostly ok, but there are > > rendering glitches, for example in the gnome activities screen (the one > > you get when you press the windows key). kernel 4.10, mesa 13.0.4. > > glamor not used, but I think gnome-shell uses opengl (via llvmpipe) for > > compositing. > > I believe glitches are irrelevant for this topic, what we are > interested in is if the colors are right or byte-swapped (also mind > alpha/blue etc. swaps). Well, I mean color glitches. But it isn't consistent. As if some operations operate with the correct byteorder and some don't. alpha/blue being swapped is a problem in some areas. https://www.kraxel.org/tmp/ cheers, Gerd