diff for duplicates of <1492524472.2628.3.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 6ea727f..76af06a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,22 +1,33 @@ -T24gVHVlLCAyMDE3LTA0LTE4IGF0IDA5OjM1ICswMjAwLCBKb2hhbm5lcyBUaHVtc2hpcm4gd3Jv -dGU6DQo+IE9uIE1vbiwgQXByIDE3LCAyMDE3IGF0IDA0OjEwOjAzUE0gLTA3MDAsIEJhcnQgVmFu -IEFzc2NoZSB3cm90ZToNCj4gPiBUaGUgZ2xvYmFsIHZhcmlhYmxlICdyZF9zaXplJyBpcyBkZWNs -YXJlZCBhcyAnaW50JyBpbiBzb3VyY2UgZmlsZQ0KPiA+IGFyY2gvYXJtL2tlcm5lbC9hdGFnc19w -YXJzZS5jIGFuZCBhcyAndW5zaWduZWQgbG9uZycgaW4NCj4gPiBkcml2ZXJzL2Jsb2NrL2JyZC5j -LiBGaXggdGhpcyBpbmNvbnNpc3RlbmN5Lg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEJhcnQg -VmFuIEFzc2NoZSA8YmFydC52YW5hc3NjaGVAc2FuZGlzay5jb20+DQo+ID4gQ2M6IFJ1c3NlbGwg -S2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPg0KPiA+IENjOiBKZW5zIEF4Ym9lIDxheGJvZUBr -ZXJuZWwuZGs+DQo+ID4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+DQo+ID4gQ2M6IDx5YW5h -aWppZUBodWF3ZWkuY29tPg0KPiA+IENjOiA8emhhb2hvbmdqaWFuZ0BodWF3ZWkuY29tPg0KPiA+ -IENjOiA8bWlhb3hpZUBodWF3ZWkuY29tPg0KPiA+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3Rz -LmluZnJhZGVhZC5vcmcNCj4gPiBDYzogbGludXgtYmxvY2tAdmdlci5rZXJuZWwub3JnDQo+ID4g -LS0tDQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvYnJkLmggYi9pbmNsdWRlL2xpbnV4 -L2JyZC5oDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwMDAu -LmRiYjBmOTJmZWZjOA0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4 -L2JyZC5oDQo+ID4gQEAgLTAsMCArMSBAQA0KPiA+ICtleHRlcm4gdW5zaWduZWQgbG9uZyByZF9z -aXplOw0KPiANCj4gU21hbGwgbml0LCBjYW4geW91IGFkZCBhbiBpbmNsdWRlIGd1YXJkIGhlcmUg -YXMgd2VsbD8NCg0KSGVsbG8gSm9oYW5uZXMsDQoNClRoYW5rcyBmb3IgdGhlIHJldmlldy4gQnV0 -IGFyZSB5b3UgYXdhcmUgdGhhdCB3aXRoIHRoZSBjdXJyZW50IGNvbnRlbnQgYW4NCmluY2x1ZGUg -Z3VhcmQgaXMgb3ZlcmtpbGwgYmVjYXVzZSBpdCBpcyBzYWZlIHRvIGV2YWx1YXRlIHRoZSAiZXh0 -ZXJuIHVuc2lnbmVkDQpsb25nIHJkX3NpemUiIGRlY2xhcmF0aW9uIG11bHRpcGxlIHRpbWVzPw0K -DQpCYXJ0Lg== +On Tue, 2017-04-18 at 09:35 +0200, Johannes Thumshirn wrote: +> On Mon, Apr 17, 2017 at 04:10:03PM -0700, Bart Van Assche wrote: +> > The global variable 'rd_size' is declared as 'int' in source file +> > arch/arm/kernel/atags_parse.c and as 'unsigned long' in +> > drivers/block/brd.c. Fix this inconsistency. +> > +> > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> +> > Cc: Russell King <linux@armlinux.org.uk> +> > Cc: Jens Axboe <axboe@kernel.dk> +> > Cc: Jan Kara <jack@suse.cz> +> > Cc: <yanaijie@huawei.com> +> > Cc: <zhaohongjiang@huawei.com> +> > Cc: <miaoxie@huawei.com> +> > Cc: linux-arm-kernel at lists.infradead.org +> > Cc: linux-block at vger.kernel.org +> > --- +> > diff --git a/include/linux/brd.h b/include/linux/brd.h +> > new file mode 100644 +> > index 000000000000..dbb0f92fefc8 +> > --- /dev/null +> > +++ b/include/linux/brd.h +> > @@ -0,0 +1 @@ +> > +extern unsigned long rd_size; +> +> Small nit, can you add an include guard here as well? + +Hello Johannes, + +Thanks for the review. But are you aware that with the current content an +include guard is overkill because it is safe to evaluate the "extern unsigned +long rd_size" declaration multiple times? + +Bart. diff --git a/a/content_digest b/N1/content_digest index 7549144..e93ca4d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,40 +1,43 @@ "ref\020170417231003.7178-1-bart.vanassche@sandisk.com\0" "ref\020170418073526.GA6056@linux-x5ow.site\0" - "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" - "Subject\0Re: [PATCH] ARM: Fix rd_size declaration\0" + "From\0Bart.VanAssche@sandisk.com (Bart Van Assche)\0" + "Subject\0[PATCH] ARM: Fix rd_size declaration\0" "Date\0Tue, 18 Apr 2017 14:07:53 +0000\0" - "To\0jthumshirn@suse.de <jthumshirn@suse.de>\0" - "Cc\0zhaohongjiang@huawei.com <zhaohongjiang@huawei.com>" - linux-block@vger.kernel.org <linux-block@vger.kernel.org> - linux@armlinux.org.uk <linux@armlinux.org.uk> - axboe@kernel.dk <axboe@kernel.dk> - linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org> - yanaijie@huawei.com <yanaijie@huawei.com> - miaoxie@huawei.com <miaoxie@huawei.com> - " jack@suse.cz <jack@suse.cz>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "T24gVHVlLCAyMDE3LTA0LTE4IGF0IDA5OjM1ICswMjAwLCBKb2hhbm5lcyBUaHVtc2hpcm4gd3Jv\n" - "dGU6DQo+IE9uIE1vbiwgQXByIDE3LCAyMDE3IGF0IDA0OjEwOjAzUE0gLTA3MDAsIEJhcnQgVmFu\n" - "IEFzc2NoZSB3cm90ZToNCj4gPiBUaGUgZ2xvYmFsIHZhcmlhYmxlICdyZF9zaXplJyBpcyBkZWNs\n" - "YXJlZCBhcyAnaW50JyBpbiBzb3VyY2UgZmlsZQ0KPiA+IGFyY2gvYXJtL2tlcm5lbC9hdGFnc19w\n" - "YXJzZS5jIGFuZCBhcyAndW5zaWduZWQgbG9uZycgaW4NCj4gPiBkcml2ZXJzL2Jsb2NrL2JyZC5j\n" - "LiBGaXggdGhpcyBpbmNvbnNpc3RlbmN5Lg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEJhcnQg\n" - "VmFuIEFzc2NoZSA8YmFydC52YW5hc3NjaGVAc2FuZGlzay5jb20+DQo+ID4gQ2M6IFJ1c3NlbGwg\n" - "S2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPg0KPiA+IENjOiBKZW5zIEF4Ym9lIDxheGJvZUBr\n" - "ZXJuZWwuZGs+DQo+ID4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+DQo+ID4gQ2M6IDx5YW5h\n" - "aWppZUBodWF3ZWkuY29tPg0KPiA+IENjOiA8emhhb2hvbmdqaWFuZ0BodWF3ZWkuY29tPg0KPiA+\n" - "IENjOiA8bWlhb3hpZUBodWF3ZWkuY29tPg0KPiA+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3Rz\n" - "LmluZnJhZGVhZC5vcmcNCj4gPiBDYzogbGludXgtYmxvY2tAdmdlci5rZXJuZWwub3JnDQo+ID4g\n" - "LS0tDQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvYnJkLmggYi9pbmNsdWRlL2xpbnV4\n" - "L2JyZC5oDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwMDAu\n" - "LmRiYjBmOTJmZWZjOA0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4\n" - "L2JyZC5oDQo+ID4gQEAgLTAsMCArMSBAQA0KPiA+ICtleHRlcm4gdW5zaWduZWQgbG9uZyByZF9z\n" - "aXplOw0KPiANCj4gU21hbGwgbml0LCBjYW4geW91IGFkZCBhbiBpbmNsdWRlIGd1YXJkIGhlcmUg\n" - "YXMgd2VsbD8NCg0KSGVsbG8gSm9oYW5uZXMsDQoNClRoYW5rcyBmb3IgdGhlIHJldmlldy4gQnV0\n" - "IGFyZSB5b3UgYXdhcmUgdGhhdCB3aXRoIHRoZSBjdXJyZW50IGNvbnRlbnQgYW4NCmluY2x1ZGUg\n" - "Z3VhcmQgaXMgb3ZlcmtpbGwgYmVjYXVzZSBpdCBpcyBzYWZlIHRvIGV2YWx1YXRlIHRoZSAiZXh0\n" - "ZXJuIHVuc2lnbmVkDQpsb25nIHJkX3NpemUiIGRlY2xhcmF0aW9uIG11bHRpcGxlIHRpbWVzPw0K\n" - DQpCYXJ0Lg== + "On Tue, 2017-04-18 at 09:35 +0200, Johannes Thumshirn wrote:\n" + "> On Mon, Apr 17, 2017 at 04:10:03PM -0700, Bart Van Assche wrote:\n" + "> > The global variable 'rd_size' is declared as 'int' in source file\n" + "> > arch/arm/kernel/atags_parse.c and as 'unsigned long' in\n" + "> > drivers/block/brd.c. Fix this inconsistency.\n" + "> > \n" + "> > Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>\n" + "> > Cc: Russell King <linux@armlinux.org.uk>\n" + "> > Cc: Jens Axboe <axboe@kernel.dk>\n" + "> > Cc: Jan Kara <jack@suse.cz>\n" + "> > Cc: <yanaijie@huawei.com>\n" + "> > Cc: <zhaohongjiang@huawei.com>\n" + "> > Cc: <miaoxie@huawei.com>\n" + "> > Cc: linux-arm-kernel at lists.infradead.org\n" + "> > Cc: linux-block at vger.kernel.org\n" + "> > ---\n" + "> > diff --git a/include/linux/brd.h b/include/linux/brd.h\n" + "> > new file mode 100644\n" + "> > index 000000000000..dbb0f92fefc8\n" + "> > --- /dev/null\n" + "> > +++ b/include/linux/brd.h\n" + "> > @@ -0,0 +1 @@\n" + "> > +extern unsigned long rd_size;\n" + "> \n" + "> Small nit, can you add an include guard here as well?\n" + "\n" + "Hello Johannes,\n" + "\n" + "Thanks for the review. But are you aware that with the current content an\n" + "include guard is overkill because it is safe to evaluate the \"extern unsigned\n" + "long rd_size\" declaration multiple times?\n" + "\n" + Bart. -3b5e1a4375a354c8942709c25622fa82ad8190fbfc9e5aed8932b56017d48e16 +c8138eb78dcb4beb733c7be08c650daf3d3f353a49ab2880923ab28a2a52f07e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.