From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "jthumshirn@suse.de" CC: "zhaohongjiang@huawei.com" , "linux-block@vger.kernel.org" , "linux@armlinux.org.uk" , "axboe@kernel.dk" , "linux-arm-kernel@lists.infradead.org" , "yanaijie@huawei.com" , "miaoxie@huawei.com" , "jack@suse.cz" Subject: Re: [PATCH] ARM: Fix rd_size declaration Date: Tue, 18 Apr 2017 14:07:53 +0000 Message-ID: <1492524472.2628.3.camel@sandisk.com> References: <20170417231003.7178-1-bart.vanassche@sandisk.com> <20170418073526.GA6056@linux-x5ow.site> In-Reply-To: <20170418073526.GA6056@linux-x5ow.site> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gVHVlLCAyMDE3LTA0LTE4IGF0IDA5OjM1ICswMjAwLCBKb2hhbm5lcyBUaHVtc2hpcm4gd3Jv dGU6DQo+IE9uIE1vbiwgQXByIDE3LCAyMDE3IGF0IDA0OjEwOjAzUE0gLTA3MDAsIEJhcnQgVmFu IEFzc2NoZSB3cm90ZToNCj4gPiBUaGUgZ2xvYmFsIHZhcmlhYmxlICdyZF9zaXplJyBpcyBkZWNs YXJlZCBhcyAnaW50JyBpbiBzb3VyY2UgZmlsZQ0KPiA+IGFyY2gvYXJtL2tlcm5lbC9hdGFnc19w YXJzZS5jIGFuZCBhcyAndW5zaWduZWQgbG9uZycgaW4NCj4gPiBkcml2ZXJzL2Jsb2NrL2JyZC5j LiBGaXggdGhpcyBpbmNvbnNpc3RlbmN5Lg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IEJhcnQg VmFuIEFzc2NoZSA8YmFydC52YW5hc3NjaGVAc2FuZGlzay5jb20+DQo+ID4gQ2M6IFJ1c3NlbGwg S2luZyA8bGludXhAYXJtbGludXgub3JnLnVrPg0KPiA+IENjOiBKZW5zIEF4Ym9lIDxheGJvZUBr ZXJuZWwuZGs+DQo+ID4gQ2M6IEphbiBLYXJhIDxqYWNrQHN1c2UuY3o+DQo+ID4gQ2M6IDx5YW5h aWppZUBodWF3ZWkuY29tPg0KPiA+IENjOiA8emhhb2hvbmdqaWFuZ0BodWF3ZWkuY29tPg0KPiA+ IENjOiA8bWlhb3hpZUBodWF3ZWkuY29tPg0KPiA+IENjOiBsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcNCj4gPiBDYzogbGludXgtYmxvY2tAdmdlci5rZXJuZWwub3JnDQo+ID4g LS0tDQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvYnJkLmggYi9pbmNsdWRlL2xpbnV4 L2JyZC5oDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwMDAwMDAu LmRiYjBmOTJmZWZjOA0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi9pbmNsdWRlL2xpbnV4 L2JyZC5oDQo+ID4gQEAgLTAsMCArMSBAQA0KPiA+ICtleHRlcm4gdW5zaWduZWQgbG9uZyByZF9z aXplOw0KPiANCj4gU21hbGwgbml0LCBjYW4geW91IGFkZCBhbiBpbmNsdWRlIGd1YXJkIGhlcmUg YXMgd2VsbD8NCg0KSGVsbG8gSm9oYW5uZXMsDQoNClRoYW5rcyBmb3IgdGhlIHJldmlldy4gQnV0 IGFyZSB5b3UgYXdhcmUgdGhhdCB3aXRoIHRoZSBjdXJyZW50IGNvbnRlbnQgYW4NCmluY2x1ZGUg Z3VhcmQgaXMgb3ZlcmtpbGwgYmVjYXVzZSBpdCBpcyBzYWZlIHRvIGV2YWx1YXRlIHRoZSAiZXh0 ZXJuIHVuc2lnbmVkDQpsb25nIHJkX3NpemUiIGRlY2xhcmF0aW9uIG11bHRpcGxlIHRpbWVzPw0K DQpCYXJ0Lg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart.VanAssche@sandisk.com (Bart Van Assche) Date: Tue, 18 Apr 2017 14:07:53 +0000 Subject: [PATCH] ARM: Fix rd_size declaration In-Reply-To: <20170418073526.GA6056@linux-x5ow.site> References: <20170417231003.7178-1-bart.vanassche@sandisk.com> <20170418073526.GA6056@linux-x5ow.site> Message-ID: <1492524472.2628.3.camel@sandisk.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2017-04-18 at 09:35 +0200, Johannes Thumshirn wrote: > On Mon, Apr 17, 2017 at 04:10:03PM -0700, Bart Van Assche wrote: > > The global variable 'rd_size' is declared as 'int' in source file > > arch/arm/kernel/atags_parse.c and as 'unsigned long' in > > drivers/block/brd.c. Fix this inconsistency. > > > > Signed-off-by: Bart Van Assche > > Cc: Russell King > > Cc: Jens Axboe > > Cc: Jan Kara > > Cc: > > Cc: > > Cc: > > Cc: linux-arm-kernel at lists.infradead.org > > Cc: linux-block at vger.kernel.org > > --- > > diff --git a/include/linux/brd.h b/include/linux/brd.h > > new file mode 100644 > > index 000000000000..dbb0f92fefc8 > > --- /dev/null > > +++ b/include/linux/brd.h > > @@ -0,0 +1 @@ > > +extern unsigned long rd_size; > > Small nit, can you add an include guard here as well? Hello Johannes, Thanks for the review. But are you aware that with the current content an include guard is overkill because it is safe to evaluate the "extern unsigned long rd_size" declaration multiple times? Bart.