From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "jmoyer@redhat.com" <jmoyer@redhat.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH] ndctl, check: Add a sigbus handler to detect metadata corruption
Date: Tue, 18 Apr 2017 16:09:11 +0000 [thread overview]
Message-ID: <1492531749.3344.1.camel@intel.com> (raw)
In-Reply-To: <x49lgqzqc32.fsf@segfault.boston.devel.redhat.com>
On Mon, 2017-04-17 at 11:37 -0400, Jeff Moyer wrote:
> Vishal Verma <vishal.l.verma@intel.com> writes:
>
> > If we have poison/badblocks in the BTT metadata sections, the mmap-
> > reads
> > happening in the checker will trigger a SIGBUS, and the program
> > will
> > halt abruptly. Add a sigbus handler which notifies the user of
> > this, and
> > prints out a relevant error message:
>
> This isn't much better than just segfaulting. Did you consider
> whether
> it was possible to reconstruct corrupt metadata in any circumstances?
>
The only spot we can actually correct metadata would be for an info
block, if the copy is intact. For any other poison in the map or flog,
I don't think we have any way to recover. Was that (info blocks) what
you meant, or something else?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2017-04-18 16:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-14 0:02 [ndctl PATCH] ndctl, check: Add a sigbus handler to detect metadata corruption Vishal Verma
2017-04-14 0:10 ` Rudoff, Andy
2017-04-14 19:00 ` Verma, Vishal L
2017-04-14 19:04 ` Dan Williams
2017-04-14 19:26 ` Rudoff, Andy
2017-04-14 19:40 ` Verma, Vishal L
2017-04-14 19:52 ` Rudoff, Andy
2017-04-14 20:28 ` Verma, Vishal L
2017-04-14 20:31 ` Rudoff, Andy
2017-04-17 15:37 ` Jeff Moyer
2017-04-18 16:09 ` Verma, Vishal L [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492531749.3344.1.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.