diff for duplicates of <1492556229.2689.22.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index dfa4b58..ca38389 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,17 @@ On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote: > From: Christoph Hellwig <hch@lst.de> -> +>=20 > This is for the legacy floppy and ataflop drivers that currently abuse > ->errors for this purpose. It's stashed away in a union to not grow > the struct size, the other fields are either used by modern drivers > for different purposes or the I/O scheduler before queing the I/O > to drivers. -> +>=20 > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > include/linux/blkdev.h | 1 + > 1 file changed, 1 insertion(+) -> +>=20 > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 5986e1250d7d..e618164462e8 100644 > --- a/include/linux/blkdev.h @@ -22,15 +22,16 @@ On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote: > void *completion_data; > + int error_count; /* for legacy drivers, don't use */ > }; -> +> =20 > /* Hello Christoph, Both blk-mq and the traditional block layer support a .cmd_size field to -make the block layer core allocate driver-specific data at the end of struct +make the block layer core allocate driver-specific data at the end of struc= +t request. Could that mechanism have been used for the error_count field? Thanks, -Bart. +Bart.= diff --git a/a/content_digest b/N1/content_digest index 3d90c64..5d2cd7c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -18,18 +18,18 @@ "b\0" "On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote:\n" "> From: Christoph Hellwig <hch@lst.de>\n" - "> \n" + ">=20\n" "> This is for the legacy floppy and ataflop drivers that currently abuse\n" "> ->errors for this purpose. It's stashed away in a union to not grow\n" "> the struct size, the other fields are either used by modern drivers\n" "> for different purposes or the I/O scheduler before queing the I/O\n" "> to drivers.\n" - "> \n" + ">=20\n" "> Signed-off-by: Christoph Hellwig <hch@lst.de>\n" "> ---\n" "> include/linux/blkdev.h | 1 +\n" "> 1 file changed, 1 insertion(+)\n" - "> \n" + ">=20\n" "> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h\n" "> index 5986e1250d7d..e618164462e8 100644\n" "> --- a/include/linux/blkdev.h\n" @@ -40,17 +40,18 @@ "> \t\tvoid *completion_data;\n" "> +\t\tint error_count; /* for legacy drivers, don't use */\n" "> \t};\n" - "> \n" + "> =20\n" "> \t/*\n" "\n" "Hello Christoph,\n" "\n" "Both blk-mq and the traditional block layer support a .cmd_size field to\n" - "make the block layer core allocate driver-specific data at the end of struct\n" + "make the block layer core allocate driver-specific data at the end of struc=\n" + "t\n" "request. Could that mechanism have been used for the error_count field?\n" "\n" "Thanks,\n" "\n" - Bart. + Bart.= -25d515725fbb06ff9aa71f7a39b4033de5d274d111596f483e490b0be2063610 +0a939dc2d771003978dad0076a49b13f0c6d8ffc3974c20e76579cd26649c485
diff --git a/a/1.txt b/N2/1.txt index dfa4b58..10b72de 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,5 +1,5 @@ -On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote: -> From: Christoph Hellwig <hch@lst.de> +On Tue, 2017-04-18@08:52 -0700, Christoph Hellwig wrote: +> From: Christoph Hellwig <hch at lst.de> > > This is for the legacy floppy and ataflop drivers that currently abuse > ->errors for this purpose. It's stashed away in a union to not grow @@ -7,7 +7,7 @@ On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote: > for different purposes or the I/O scheduler before queing the I/O > to drivers. > -> Signed-off-by: Christoph Hellwig <hch@lst.de> +> Signed-off-by: Christoph Hellwig <hch at lst.de> > --- > include/linux/blkdev.h | 1 + > 1 file changed, 1 insertion(+) diff --git a/a/content_digest b/N2/content_digest index 3d90c64..14b3393 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,23 +1,12 @@ "ref\020170418155229.5977-1-hch@bombadil.infradead.org\0" "ref\020170418155229.5977-18-hch@bombadil.infradead.org\0" - "From\0Bart Van Assche <Bart.VanAssche@sandisk.com>\0" - "Subject\0Re: block: add a error_count field to struct request\0" + "From\0Bart.VanAssche@sandisk.com (Bart Van Assche)\0" + "Subject\0block: add a error_count field to struct request\0" "Date\0Tue, 18 Apr 2017 22:57:11 +0000\0" - "To\0hch@bombadil.infradead.org <hch@bombadil.infradead.org>" - " axboe@kernel.dk <axboe@kernel.dk>\0" - "Cc\0linux-block@vger.kernel.org <linux-block@vger.kernel.org>" - hch@lst.de <hch@lst.de> - konrad.wilk@oracle.com <konrad.wilk@oracle.com> - roger.pau@citrix.com <roger.pau@citrix.com> - linux-scsi@vger.kernel.org <linux-scsi@vger.kernel.org> - linux-nvme@lists.infradead.org <linux-nvme@lists.infradead.org> - jbacik@fb.com <jbacik@fb.com> - james.smart@broadcom.com <james.smart@broadcom.com> - " dm-devel@redhat.com <dm-devel@redhat.com>\0" "\00:1\0" "b\0" - "On Tue, 2017-04-18 at 08:52 -0700, Christoph Hellwig wrote:\n" - "> From: Christoph Hellwig <hch@lst.de>\n" + "On Tue, 2017-04-18@08:52 -0700, Christoph Hellwig wrote:\n" + "> From: Christoph Hellwig <hch at lst.de>\n" "> \n" "> This is for the legacy floppy and ataflop drivers that currently abuse\n" "> ->errors for this purpose. It's stashed away in a union to not grow\n" @@ -25,7 +14,7 @@ "> for different purposes or the I/O scheduler before queing the I/O\n" "> to drivers.\n" "> \n" - "> Signed-off-by: Christoph Hellwig <hch@lst.de>\n" + "> Signed-off-by: Christoph Hellwig <hch at lst.de>\n" "> ---\n" "> include/linux/blkdev.h | 1 +\n" "> 1 file changed, 1 insertion(+)\n" @@ -53,4 +42,4 @@ "\n" Bart. -25d515725fbb06ff9aa71f7a39b4033de5d274d111596f483e490b0be2063610 +671807e0e1566691f262bdb74d212f2bc2366f2ba345de0f1e66e064345e1688
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.