From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH 01/23] pd: don't check blk_execute_rq return value. Date: Wed, 19 Apr 2017 21:02:33 +0000 Message-ID: <1492635752.2543.16.camel@sandisk.com> References: <20170419192708.22098-1-hch@lst.de> <20170419192708.22098-2-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20170419192708.22098-2-hch@lst.de> Content-Language: en-US Content-ID: <3FAF775C736EE541AE35AC0A409F319E@namprd04.prod.outlook.com> Sender: linux-scsi-owner@vger.kernel.org To: "hch@lst.de" , "axboe@kernel.dk" Cc: "linux-block@vger.kernel.org" , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "jbacik@fb.com" , "james.smart@broadcom.com" , "dm-devel@redhat.com" List-Id: dm-devel.ids On Wed, 2017-04-19 at 21:26 +0200, Christoph Hellwig wrote: > The driver never sets req->errors, so blk_execute_rq will always return 0= . Reviewed-by: Bart Van Assche = From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "hch@lst.de" , "axboe@kernel.dk" CC: "linux-block@vger.kernel.org" , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "linux-scsi@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "jbacik@fb.com" , "james.smart@broadcom.com" , "dm-devel@redhat.com" Subject: Re: [PATCH 01/23] pd: don't check blk_execute_rq return value. Date: Wed, 19 Apr 2017 21:02:33 +0000 Message-ID: <1492635752.2543.16.camel@sandisk.com> References: <20170419192708.22098-1-hch@lst.de> <20170419192708.22098-2-hch@lst.de> In-Reply-To: <20170419192708.22098-2-hch@lst.de> Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 List-ID: On Wed, 2017-04-19 at 21:26 +0200, Christoph Hellwig wrote: > The driver never sets req->errors, so blk_execute_rq will always return 0= . Reviewed-by: Bart Van Assche = From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart.VanAssche@sandisk.com (Bart Van Assche) Date: Wed, 19 Apr 2017 21:02:33 +0000 Subject: [PATCH 01/23] pd: don't check blk_execute_rq return value. In-Reply-To: <20170419192708.22098-2-hch@lst.de> References: <20170419192708.22098-1-hch@lst.de> <20170419192708.22098-2-hch@lst.de> Message-ID: <1492635752.2543.16.camel@sandisk.com> On Wed, 2017-04-19@21:26 +0200, Christoph Hellwig wrote: > The driver never sets req->errors, so blk_execute_rq will always return 0. Reviewed-by: Bart Van Assche