From: Johannes Berg <johannes@sipsolutions.net>
To: Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Alexei Starovoitov <ast@kernel.org>, netdev <netdev@vger.kernel.org>
Subject: Re: __sk_buff.data_end
Date: Thu, 20 Apr 2017 08:07:47 +0200 [thread overview]
Message-ID: <1492668467.3109.4.camel@sipsolutions.net> (raw)
In-Reply-To: <58F802EB.9080807@iogearbox.net>
On Thu, 2017-04-20 at 02:38 +0200, Daniel Borkmann wrote:
> > Since wifi skbs have only eth in headlen, there is not much
> > pointing adding support for data/data_end to wifi.
> > Just use ld_abs/ld_ind instructions and load_bytes() helper.
>
> Afaik, the ld_abs/ld_ind are not an option due to the data
> on the wire being in little endian, but the bpf_skb_load_bytes()
> might be the way to go initially, agree.
Oh yeah, we could really only use byte loads which would be even less
efficient, so that's a good argument for not even providing the data
load instructions... :)
johannes
next prev parent reply other threads:[~2017-04-20 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 21:31 __sk_buff.data_end Johannes Berg
2017-04-19 22:20 ` __sk_buff.data_end Johannes Berg
2017-04-20 0:01 ` __sk_buff.data_end Daniel Borkmann
2017-04-20 0:12 ` __sk_buff.data_end Alexei Starovoitov
2017-04-20 0:38 ` __sk_buff.data_end Daniel Borkmann
2017-04-20 6:07 ` Johannes Berg [this message]
2017-04-20 6:06 ` __sk_buff.data_end Johannes Berg
2017-04-20 6:01 ` __sk_buff.data_end Johannes Berg
2017-04-20 14:10 ` __sk_buff.data_end Daniel Borkmann
2017-04-20 14:17 ` __sk_buff.data_end Johannes Berg
2017-04-20 14:28 ` __sk_buff.data_end Daniel Borkmann
2017-04-20 14:32 ` __sk_buff.data_end Johannes Berg
2017-04-20 14:46 ` __sk_buff.data_end Daniel Borkmann
2017-04-20 14:48 ` __sk_buff.data_end Johannes Berg
2017-04-19 23:51 ` __sk_buff.data_end Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492668467.3109.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.