From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sven Van Asbroeck <thesven73@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pwm@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Sven Van Asbroeck <TheSven73@googlemail.com>
Subject: Re: [PATCH v4 1/1] pwm: pca9685: fix gpio-only operation.
Date: Thu, 20 Apr 2017 19:13:11 +0300 [thread overview]
Message-ID: <1492704791.24567.104.camel@linux.intel.com> (raw)
In-Reply-To: <CAGngYiW7wASpqf-h9fieDV8ctd61=8WqBs=8n1NJ-jSm0uULrw@mail.gmail.com>
On Thu, 2017-04-20 at 11:50 -0400, Sven Van Asbroeck wrote:
> > Thus, I would suggest: int sleep -> bool enable (or alike).
> >
> > Would we agree on that?
>
> I would. Perhaps also:
> set_sleep_mode(int sleep) -> enable_sleep_mode(bool enable) ?
I'm okay with a such (don't forget to change 0/1 in call sites to
false/true as well).
> Let's see what Mika and Thierry think.
I suppose Mika's answer is an acknowledge to the change.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-04-20 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 12:58 [PATCH v4 0/1] pwm: pca9685: fix gpio-only operation Sven Van Asbroeck
2017-04-13 12:58 ` [PATCH v4 1/1] " Sven Van Asbroeck
2017-04-13 15:34 ` Thierry Reding
2017-04-18 9:14 ` Andy Shevchenko
2017-04-18 15:52 ` Sven Van Asbroeck
2017-04-19 20:24 ` Mika Westerberg
2017-04-20 7:29 ` Andy Shevchenko
2017-04-20 14:12 ` Sven Van Asbroeck
2017-04-20 15:07 ` Andy Shevchenko
2017-04-20 15:50 ` Sven Van Asbroeck
2017-04-20 16:13 ` Andy Shevchenko [this message]
2017-04-20 15:55 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492704791.24567.104.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=TheSven73@googlemail.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=thesven73@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.