From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality. Date: Fri, 21 Apr 2017 18:14:31 +0200 Message-ID: <1492791271.25675.57.camel@redhat.com> References: <20170421075825.6307-1-kraxel@redhat.com> <20170421092530.GE30290@intel.com> <1492768218.25675.33.camel@redhat.com> <20170421110804.GH30290@intel.com> <1492780323.25675.45.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1492780323.25675.45.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?ISO-8859-1?Q?K=F6nig?= Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, David Airlie , Michel =?ISO-8859-1?Q?D=E4nzer?= , open list , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Pekka Paalanen , Sean Paul , Jani Nikula , Alex Deucher , Daniel Vetter , Ilia Mirkin , Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= ICBIaSwKCj4gPiBNeSBwZXJzb25hbCBvcGluaW9uIGlzIHRoYXQgZm9ybWF0cyBpbiBkcm1fZm91 cmNjLmggc2hvdWxkIGJlIAo+ID4gaW5kZXBlbmRlbnQgb2YgdGhlIENQVSBieXRlIG9yZGVyIGFu ZCB0aGUgZnVuY3Rpb24gCj4gPiBkcm1fbW9kZV9sZWdhY3lfZmJfZm9ybWF0KCkgYW5kIGRyaXZl cnMgZGVwZW5kaW5nIG9uIHRoYXQgaW5jb3JyZWN0IAo+ID4gYXNzdW1wdGlvbiBiZSBmaXhlZCBp bnN0ZWFkLgo+IAo+IFRoZSBwcm9ibGVtIGlzIHRoaXMgaXNuJ3QgYSBrZXJuZWwtaW50ZXJuYWwg dGhpbmcgYW55IG1vcmUuICBXaXRoIHRoZQo+IGFkZGl0aW9uIG9mIHRoZSBBRERGQjIgaW9jdGwg dGhlIGZvdXJjYyBjb2RlcyBiZWNhbWUgcGFydCBvZiB0aGUKPiBrZXJuZWwvdXNlcnNwYWNlIGFi aSAuLi4KCk9rLCBhZGRlZCBzb21lIHByaW50aydzIHRvIHRoZSBBRERGQiBhbmQgQURERkIyIGNv ZGUgcGF0aHMgYW5kIHRlc3RlZCBhCmJpdC4gIEFwcGFyZW50bHkgcHJldHR5IG11Y2ggYWxsIHVz ZXJzcGFjZSBzdGlsbCB1c2VzIHRoZSBBRERGQiBpb2N0bC4KeG9yZyAobW9kZXNldHRpbmcgZHJp dmVyKSBkb2VzLiAgZ25vbWUtc2hlbGwgaW4gd2F5bGFuZCBtb2RlIGRvZXMuClNlZW1zIHRoZSBi aWcgdHJhbnNpdGlvbiB0byBBRERGQjIgZGlkbid0IGhhcHBlbiB5ZXQuCgpJIGd1ZXNzIHRoYXQg bWFrZXMgY2hhbmdpbmcgZHJtX21vZGVfbGVnYWN5X2ZiX2Zvcm1hdCArIGRyaXZlcnMgYQpyZWFz b25hYmxlIG9wdGlvbiAuLi4KCmNoZWVycywKICBHZXJkCgpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162610AbdDUVfW convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2017 17:35:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47668 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162592AbdDUVfS (ORCPT ); Fri, 21 Apr 2017 17:35:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B64348C1B7 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=tempfail smtp.mailfrom=kraxel@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B64348C1B7 Message-ID: <1492791271.25675.57.camel@redhat.com> Subject: Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality. From: Gerd Hoffmann To: Christian =?ISO-8859-1?Q?K=F6nig?= Cc: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Jani Nikula , David Airlie , Michel =?ISO-8859-1?Q?D=E4nzer?= , open list , dri-devel@lists.freedesktop.org, Pekka Paalanen , Sean Paul , amd-gfx@lists.freedesktop.org, Alex Deucher , Daniel Vetter , Ilia Mirkin Date: Fri, 21 Apr 2017 18:14:31 +0200 In-Reply-To: <1492780323.25675.45.camel@redhat.com> References: <20170421075825.6307-1-kraxel@redhat.com> <20170421092530.GE30290@intel.com> <1492768218.25675.33.camel@redhat.com> <20170421110804.GH30290@intel.com> <1492780323.25675.45.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 21 Apr 2017 21:28:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > My personal opinion is that formats in drm_fourcc.h should be > > independent of the CPU byte order and the function > > drm_mode_legacy_fb_format() and drivers depending on that incorrect > > assumption be fixed instead. > > The problem is this isn't a kernel-internal thing any more. With the > addition of the ADDFB2 ioctl the fourcc codes became part of the > kernel/userspace abi ... Ok, added some printk's to the ADDFB and ADDFB2 code paths and tested a bit. Apparently pretty much all userspace still uses the ADDFB ioctl. xorg (modesetting driver) does. gnome-shell in wayland mode does. Seems the big transition to ADDFB2 didn't happen yet. I guess that makes changing drm_mode_legacy_fb_format + drivers a reasonable option ... cheers, Gerd