From: Joe Perches <joe@perches.com>
To: Eric Curtin <ericcurtin17@gmail.com>,
thomas.petazzoni@free-electrons.com, gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc.
Date: Sat, 22 Apr 2017 16:36:34 -0700 [thread overview]
Message-ID: <1492904194.30293.40.camel@perches.com> (raw)
In-Reply-To: <1492874769-14446-1-git-send-email-ericcurtin17@gmail.com>
On Sat, 2017-04-22 at 16:26 +0100, Eric Curtin wrote:
> checkpatch spits out a warning about the 80 character line limit. Split
> the parameters of these functions onto different lines. Put the ; with
> the macro caller instead. Lined up parameters as there was another
> CHECK warning about that.
[]
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
[]
> @@ -24,7 +24,14 @@ void func(struct fbtft_par *par, int len, ...) \
> buf[i] = (type)va_arg(args, unsigned int); \
> } \
> va_end(args); \
> - fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, par->info->device, type, buf, len, "%s: ", __func__); \
> + fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, \
> + par, \
> + par->info->device, \
> + type, \
> + buf, \
> + len, \
> + "%s: ", \
> + __func__); \
> } \
Multiple arguments per line please before 80 columns
fbtft_par_dbg_hex(DEBUG_WRITE_REGISTER, par, \
par->info->device, type, buf, len, \
"%s: ", __func__); \
next prev parent reply other threads:[~2017-04-22 23:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-22 15:26 [PATCH] staging: fbtft: fix character limit, trailing ; warning, etc Eric Curtin
2017-04-22 23:36 ` Joe Perches [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-04-23 14:21 Eric Curtin
2017-04-28 10:07 ` Greg KH
2017-05-25 21:35 ` Eric Curtin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1492904194.30293.40.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=ericcurtin17@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.