From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "martin.petersen@oracle.com" CC: "linux-scsi@vger.kernel.org" , "James.Bottomley@HansenPartnership.com" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "hare@suse.com" , "axboe@kernel.dk" Subject: Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() Date: Mon, 24 Apr 2017 21:49:37 +0000 Message-ID: <1493070575.3394.19.camel@sandisk.com> References: <20170421234026.18970-1-bart.vanassche@sandisk.com> <20170421234026.18970-11-bart.vanassche@sandisk.com> In-Reply-To: Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 List-ID: On Mon, 2017-04-24 at 17:35 -0400, Martin K. Petersen wrote: > > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. >=20 > Why not use SCSI tracing if you are interested in these? Hello Martin, SCSI tracing has to be enabled before a test is started, produces a huge am= ount of data, and deriving state information from a huge trace is far from easy.= The information in debugfs provides an easy to read overview of the current sta= te without having to analyze megabytes of traces, without introducing any slow= down and without having to enable any tracing mechanism from beforehand. Bart.= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v4 10/10] scsi: Implement blk_mq_ops.show_rq() Date: Mon, 24 Apr 2017 21:49:37 +0000 Message-ID: <1493070575.3394.19.camel@sandisk.com> References: <20170421234026.18970-1-bart.vanassche@sandisk.com> <20170421234026.18970-11-bart.vanassche@sandisk.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from esa2.hgst.iphmx.com ([68.232.143.124]:44304 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S977306AbdDXVtl (ORCPT ); Mon, 24 Apr 2017 17:49:41 -0400 In-Reply-To: Content-Language: en-US Content-ID: <198A5D4B76F65F4D82B302DD734D912B@namprd04.prod.outlook.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "martin.petersen@oracle.com" Cc: "linux-scsi@vger.kernel.org" , "James.Bottomley@HansenPartnership.com" , "linux-block@vger.kernel.org" , "osandov@fb.com" , "hare@suse.com" , "axboe@kernel.dk" On Mon, 2017-04-24 at 17:35 -0400, Martin K. Petersen wrote: > > Show the SCSI CDB, .eh_eflags and .result for pending SCSI commands > > in /sys/kernel/debug/block/*/mq/*/dispatch and */rq_list. >=20 > Why not use SCSI tracing if you are interested in these? Hello Martin, SCSI tracing has to be enabled before a test is started, produces a huge am= ount of data, and deriving state information from a huge trace is far from easy.= The information in debugfs provides an easy to read overview of the current sta= te without having to analyze megabytes of traces, without introducing any slow= down and without having to enable any tracing mechanism from beforehand. Bart.=