From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brendan Higgins <brendanhiggins@google.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
joel@jms.id.au, vz@mleia.com, mouse@mayc.ru, clg@kaod.org
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C
Date: Tue, 25 Apr 2017 12:21:04 +1000 [thread overview]
Message-ID: <1493086864.25766.266.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170424181818.2754-5-brendanhiggins@google.com>
On Mon, 2017-04-24 at 11:18 -0700, Brendan Higgins wrote:
> +static int __aspeed_i2c_init_clk(struct aspeed_i2c_bus *bus,
> + struct platform_device *pdev)
> +{
Minor nit ... I'm really not fan of those underscores.
We use __ functions in some cases in the kernel for low level
helpers, usually when it's a low level variant of an existing
function or an "unlocked" variant, but I don't think generalizing
it to pretty much everything in the driver is worthwhile here.
If you want to be explicit about locking, I would suggest you
use a comment in front of the function explaining if it
expects to be called with the lock held.
We tend to only do that when *both* functions exist and one is
implemented in term of the other.
Cheers,
Ben.
next prev parent reply other threads:[~2017-04-25 2:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 18:18 [PATCH v7 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-04-24 18:18 ` Brendan Higgins
[not found] ` <20170424181818.2754-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-04-24 18:18 ` [PATCH v7 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller Brendan Higgins
2017-04-24 18:18 ` Brendan Higgins
[not found] ` <20170424181818.2754-2-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-04-28 18:19 ` Rob Herring
2017-04-28 18:19 ` Rob Herring
2017-04-24 18:18 ` [PATCH v7 2/5] irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed Brendan Higgins
2017-04-24 18:18 ` Brendan Higgins
2017-04-24 18:18 ` [PATCH v7 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins
2017-04-24 18:18 ` Brendan Higgins
2017-04-25 8:35 ` Brendan Higgins
2017-04-24 18:18 ` [PATCH v7 3/5] i2c: aspeed: added documentation " Brendan Higgins
2017-04-28 18:21 ` Rob Herring
2017-04-24 18:18 ` [PATCH v7 4/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-04-25 2:21 ` Benjamin Herrenschmidt [this message]
2017-04-25 8:00 ` Brendan Higgins
2017-05-08 23:28 ` Brendan Higgins
[not found] ` <CAFd5g47VGa=wqeyg5tFjB5xD=YsTuP27hLN3-ZM62MJD8dCP_Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-09 2:21 ` Wolfram Sang
2017-05-09 2:21 ` Wolfram Sang
2017-05-09 7:15 ` Benjamin Herrenschmidt
2017-05-09 7:15 ` Benjamin Herrenschmidt
2017-05-08 23:34 ` Brendan Higgins
[not found] ` <20170424181818.2754-5-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-05-12 7:02 ` Cédric Le Goater
2017-05-12 7:02 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493086864.25766.266.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mouse@mayc.ru \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.