All of lore.kernel.org
 help / color / mirror / Atom feed
diff for duplicates of <1493111272.68612.2.camel@intel.com>

diff --git a/a/1.txt b/N1/1.txt
index 78908e7..9f39b41 100644
--- a/a/1.txt
+++ b/N1/1.txt
@@ -1,11 +1,11 @@
 On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
-> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.
+> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.
 > > org] On
 > > Behalf Of Benjamin Poirier
 > > Sent: Monday, April 24, 2017 12:10 PM
 > > To: Neftin, Sasha <sasha.neftin@intel.com>
-> > Cc: Kirsher at f1.synalogic.ca; Stefan Priebe <s.priebe@profihost.ag>;
-> > netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org
+> > Cc: Kirsher@f1.synalogic.ca; Stefan Priebe <s.priebe@profihost.ag>;
+> > netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org
 > > Subject: Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return
 > > uninitialized
 > > stats
@@ -16,13 +16,13 @@ On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
 > > On 2017/04/24 11:17, Neftin, Sasha wrote:
 > > > On 4/23/2017 15:53, Neftin, Sasha wrote:
 > > > > -----Original Message-----
-> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osu
+> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osu
 > > > > osl.org]
 > > 
 > > On Behalf Of Benjamin Poirier
 > > > > Sent: Saturday, April 22, 2017 00:20
 > > > > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
-> > > > Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;
+> > > > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org;
 > > > > Stefan
 > > 
 > > Priebe <s.priebe@profihost.ag>
@@ -44,8 +44,8 @@ On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
 > > > > Reported-by: Stefan Priebe <s.priebe@profihost.ag>
 > > > > Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
 > > > > ---
-> > > > ?? drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-
-> > > > ?? 1 file changed, 1 insertion(+), 1 deletion(-)
+> > > >    drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-
+> > > >    1 file changed, 1 insertion(+), 1 deletion(-)
 > > > > 
 > > > > diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c
 > > 
@@ -57,16 +57,16 @@ On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
 > > > > e1000_get_ethtool_stats(struct
 > > 
 > > net_device *netdev,
-> > > > ???????????pm_runtime_get_sync(netdev->dev.parent);
-> > > > -?e1000e_get_stats64(netdev, &net_stats);
-> > > > +?dev_get_stats(netdev, &net_stats);
-> > > > ???????????pm_runtime_put_sync(netdev->dev.parent);
+> > > >            pm_runtime_get_sync(netdev->dev.parent);
+> > > > - e1000e_get_stats64(netdev, &net_stats);
+> > > > + dev_get_stats(netdev, &net_stats);
+> > > >            pm_runtime_put_sync(netdev->dev.parent);
 > > > > --
 > > > > 2.12.2
 > > > > 
 > > > > _______________________________________________
 > > > > Intel-wired-lan mailing list
-> > > > Intel-wired-lan at lists.osuosl.org
+> > > > Intel-wired-lan@lists.osuosl.org
 > > > > http://lists.osuosl.org/mailman/listinfo/intel-wired-lan
 > > > 
 > > > Hello,
@@ -83,7 +83,7 @@ On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
 > > No, it's not the same functionality because dev_get_stats() does a
 > > memset on the rtnl_link_stats64 struct.
 > > 
-> > > 5928) calls 'memset' with 0's before update statistics.? Local
+> > > 5928) calls 'memset' with 0's before update statistics.  Local
 > > > sanity check
 > > 
 > > I don't see any memset in e1000e_get_stats64(). What kernel version
@@ -95,13 +95,13 @@ On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
 > -----------------
 > commit 5944701df90d9577658e2354cc27c4ceaeca30fe
 > Author: stephen hemminger <stephen@networkplumber.org>
-> Date:?? Fri Jan 6 19:12:53 2017 -0800
+> Date:   Fri Jan 6 19:12:53 2017 -0800
 > 
-> ??? net: remove useless memset's in drivers get_stats64
+>     net: remove useless memset's in drivers get_stats64
 > 
-> ??? In dev_get_stats() the statistic structure storage has already
+>     In dev_get_stats() the statistic structure storage has already
 > been
-> ??? zeroed. Therefore network drivers do not need to call memset()
+>     zeroed. Therefore network drivers do not need to call memset()
 > again.
 > ...
 > < changes to other drivers snipped out >
@@ -113,21 +113,21 @@ On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:
 > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c
 > @@ -5925,7 +5925,6 @@ void e1000e_get_stats64(struct net_device
 > *netdev,
-> ?{
-> ??????? struct e1000_adapter *adapter = netdev_priv(netdev);
+>  {
+>         struct e1000_adapter *adapter = netdev_priv(netdev);
 > 
-> -?????? memset(stats, 0, sizeof(struct rtnl_link_stats64));
-> ??????? spin_lock(&adapter->stats64_lock);
-> ??????? e1000e_update_stats(adapter);
-> ??????? /* Fill out the OS statistics structure */
+> -       memset(stats, 0, sizeof(struct rtnl_link_stats64));
+>         spin_lock(&adapter->stats64_lock);
+>         e1000e_update_stats(adapter);
+>         /* Fill out the OS statistics structure */
 > -------------------------------------------------------------------
 > -----------------
 > 
 > This also is where the bad counters start to show up for e1000e for
-> my test systems.? From this driver on I see (very) large values for
+> my test systems.  From this driver on I see (very) large values for
 > tx_dropped, rx_over_errors and tx_fifo_errors on driver load (even
-> before bringing the interface up.? It seems the memset is not so
-> useless for this driver after all.? Would simply reverting the e1000e
+> before bringing the interface up.  It seems the memset is not so
+> useless for this driver after all.  Would simply reverting the e1000e
 > portion of this patch resolve the issue?
 
 Looks like Aaron beat me to the punch on pointing out that we had this
@@ -140,10 +140,3 @@ pursue why the stats structure is not zero'd out and resolve that
 instead.  Either way, just want to make sure we are all on the same
 page as to the right solution so that we do not end up repeating this
 in the future.
--------------- next part --------------
-A non-text attachment was scrubbed...
-Name: signature.asc
-Type: application/pgp-signature
-Size: 833 bytes
-Desc: This is a digitally signed message part
-URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170425/81a30234/attachment.asc>
diff --git a/N1/2.bin b/N1/2.bin
new file mode 100644
index 0000000..cbca558
--- /dev/null
+++ b/N1/2.bin
@@ -0,0 +1,16 @@
+-----BEGIN PGP SIGNATURE-----
+
+iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlj/EegACgkQ5W/vlVpL
+7c76Tw//ZoHhqhoM89YYWhFZd/v/Xx6NKulBEvqX922fUyWXUxxtYKX/mPa0rj5V
+VZ2Ui3Ev+oANLSA5F4C51uC+NfvujM0igVovwqDacyb8tqKmepUjqjauQHV/bQ3p
+S8hiGzM+I3AlMOSUF2igHkbGoO5NP0W+ryOQzrA/8xjXWlifvv0jGYSoAW0O5TbZ
+ege2GmC9L7mPaaVR8j3Ii/Le8T8a6ujtFCyvE1DXAg959KzTB4mpbXusVQh9WeAm
+2PBFfpCPRwToziLYAV+1FHwNYmaHc0Ek1tiEnTFBDyPA7NOC973PWrKRuhNhZ7B8
+DBh2t0yfSfNeFo7QCF6DSfcXpVAPnO59DM4N29BI3GcC9BDWpulW1KWYqao25kVV
+ctdw7B3kAWPku1PutMH+H1+YNufBlYMyZBXfCIiZrgaMHI3FglZT5bZMRCv1FlVX
+XIhqHjpV9oKysoC9YxoxO5iCr/AZQ0DqA+E7VXyO2n5b+lbQhMK6kXgfSbZ5whIV
+H9q+kFmVra1OW/Ba5vAeelCIMIYV2W946sANUEK4O4D61Xazro4o2J8Z5msM8Jie
+oawaZCwbZ1pG9rx/ykIjlL0mwnFWFn4BwatYOkvrRrJaI+C7+WMtlJz1YsOIxyjr
+UPKfc4tsOp+QGPGhCjFxLbbRQfByV9EpNNUUqlgfL1j1LkhV/6g=
+=eOkx
+-----END PGP SIGNATURE-----
diff --git a/N1/2.hdr b/N1/2.hdr
new file mode 100644
index 0000000..da6d245
--- /dev/null
+++ b/N1/2.hdr
@@ -0,0 +1,3 @@
+Content-Type: application/pgp-signature; name="signature.asc"
+Content-Description: This is a digitally signed message part
+Content-Transfer-Encoding: 7bit
diff --git a/a/content_digest b/N1/content_digest
index af2357d..a37bdde 100644
--- a/a/content_digest
+++ b/N1/content_digest
@@ -4,19 +4,29 @@
  "ref\020170424191026.wpnpyhdaurfjixl7@f1.synalogic.ca\0"
  "ref\0309B89C4C689E141A5FF6A0C5FB2118B8C5EF4F7@ORSMSX101.amr.corp.intel.com\0"
  "From\0Jeff Kirsher <jeffrey.t.kirsher@intel.com>\0"
- "Subject\0[Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats\0"
+ "Subject\0Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return uninitialized stats\0"
  "Date\0Tue, 25 Apr 2017 02:07:52 -0700\0"
- "To\0intel-wired-lan@osuosl.org\0"
- "\00:1\0"
+ "To\0Brown"
+  Aaron F <aaron.f.brown@intel.com>
+  Benjamin Poirier <bpoirier@suse.com>
+  Neftin
+  Sasha <sasha.neftin@intel.com>
+  David S Miller <davem@davemloft.net>
+ " stephen@networkplumber.org\0"
+ "Cc\0netdev@vger.kernel.org <netdev@vger.kernel.org>"
+  intel-wired-lan@lists.osuosl.org <intel-wired-lan@lists.osuosl.org>
+  Kirsher@f1.synalogic.ca <Kirsher@f1.synalogic.ca>
+ " Stefan Priebe <s.priebe@profihost.ag>\0"
+ "\01:1\0"
  "b\0"
  "On Tue, 2017-04-25 at 07:10 +0000, Brown, Aaron F wrote:\n"
- "> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.\n"
+ "> > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.\n"
  "> > org] On\n"
  "> > Behalf Of Benjamin Poirier\n"
  "> > Sent: Monday, April 24, 2017 12:10 PM\n"
  "> > To: Neftin, Sasha <sasha.neftin@intel.com>\n"
- "> > Cc: Kirsher at f1.synalogic.ca; Stefan Priebe <s.priebe@profihost.ag>;\n"
- "> > netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org\n"
+ "> > Cc: Kirsher@f1.synalogic.ca; Stefan Priebe <s.priebe@profihost.ag>;\n"
+ "> > netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org\n"
  "> > Subject: Re: [Intel-wired-lan] [PATCH 1/2] e1000e: Don't return\n"
  "> > uninitialized\n"
  "> > stats\n"
@@ -27,13 +37,13 @@
  "> > On 2017/04/24 11:17, Neftin, Sasha wrote:\n"
  "> > > On 4/23/2017 15:53, Neftin, Sasha wrote:\n"
  "> > > > -----Original Message-----\n"
- "> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osu\n"
+ "> > > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osu\n"
  "> > > > osl.org]\n"
  "> > \n"
  "> > On Behalf Of Benjamin Poirier\n"
  "> > > > Sent: Saturday, April 22, 2017 00:20\n"
  "> > > > To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>\n"
- "> > > > Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org;\n"
+ "> > > > Cc: netdev@vger.kernel.org; intel-wired-lan@lists.osuosl.org;\n"
  "> > > > Stefan\n"
  "> > \n"
  "> > Priebe <s.priebe@profihost.ag>\n"
@@ -55,8 +65,8 @@
  "> > > > Reported-by: Stefan Priebe <s.priebe@profihost.ag>\n"
  "> > > > Signed-off-by: Benjamin Poirier <bpoirier@suse.com>\n"
  "> > > > ---\n"
- "> > > > ?? drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-\n"
- "> > > > ?? 1 file changed, 1 insertion(+), 1 deletion(-)\n"
+ "> > > > \302\240\302\240 drivers/net/ethernet/intel/e1000e/ethtool.c | 2 +-\n"
+ "> > > > \302\240\302\240 1 file changed, 1 insertion(+), 1 deletion(-)\n"
  "> > > > \n"
  "> > > > diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c\n"
  "> > \n"
@@ -68,16 +78,16 @@
  "> > > > e1000_get_ethtool_stats(struct\n"
  "> > \n"
  "> > net_device *netdev,\n"
- "> > > > ???????????pm_runtime_get_sync(netdev->dev.parent);\n"
- "> > > > -?e1000e_get_stats64(netdev, &net_stats);\n"
- "> > > > +?dev_get_stats(netdev, &net_stats);\n"
- "> > > > ???????????pm_runtime_put_sync(netdev->dev.parent);\n"
+ "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pm_runtime_get_sync(netdev->dev.parent);\n"
+ "> > > > -\302\240e1000e_get_stats64(netdev, &net_stats);\n"
+ "> > > > +\302\240dev_get_stats(netdev, &net_stats);\n"
+ "> > > > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240pm_runtime_put_sync(netdev->dev.parent);\n"
  "> > > > --\n"
  "> > > > 2.12.2\n"
  "> > > > \n"
  "> > > > _______________________________________________\n"
  "> > > > Intel-wired-lan mailing list\n"
- "> > > > Intel-wired-lan at lists.osuosl.org\n"
+ "> > > > Intel-wired-lan@lists.osuosl.org\n"
  "> > > > http://lists.osuosl.org/mailman/listinfo/intel-wired-lan\n"
  "> > > \n"
  "> > > Hello,\n"
@@ -94,7 +104,7 @@
  "> > No, it's not the same functionality because dev_get_stats() does a\n"
  "> > memset on the rtnl_link_stats64 struct.\n"
  "> > \n"
- "> > > 5928) calls 'memset' with 0's before update statistics.? Local\n"
+ "> > > 5928) calls 'memset' with 0's before update statistics.\302\240 Local\n"
  "> > > sanity check\n"
  "> > \n"
  "> > I don't see any memset in e1000e_get_stats64(). What kernel version\n"
@@ -106,13 +116,13 @@
  "> -----------------\n"
  "> commit 5944701df90d9577658e2354cc27c4ceaeca30fe\n"
  "> Author: stephen hemminger <stephen@networkplumber.org>\n"
- "> Date:?? Fri Jan 6 19:12:53 2017 -0800\n"
+ "> Date:\302\240\302\240 Fri Jan 6 19:12:53 2017 -0800\n"
  "> \n"
- "> ??? net: remove useless memset's in drivers get_stats64\n"
+ "> \302\240\302\240\302\240 net: remove useless memset's in drivers get_stats64\n"
  "> \n"
- "> ??? In dev_get_stats() the statistic structure storage has already\n"
+ "> \302\240\302\240\302\240 In dev_get_stats() the statistic structure storage has already\n"
  "> been\n"
- "> ??? zeroed. Therefore network drivers do not need to call memset()\n"
+ "> \302\240\302\240\302\240 zeroed. Therefore network drivers do not need to call memset()\n"
  "> again.\n"
  "> ...\n"
  "> < changes to other drivers snipped out >\n"
@@ -124,21 +134,21 @@
  "> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n"
  "> @@ -5925,7 +5925,6 @@ void e1000e_get_stats64(struct net_device\n"
  "> *netdev,\n"
- "> ?{\n"
- "> ??????? struct e1000_adapter *adapter = netdev_priv(netdev);\n"
+ "> \302\240{\n"
+ "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240 struct e1000_adapter *adapter = netdev_priv(netdev);\n"
  "> \n"
- "> -?????? memset(stats, 0, sizeof(struct rtnl_link_stats64));\n"
- "> ??????? spin_lock(&adapter->stats64_lock);\n"
- "> ??????? e1000e_update_stats(adapter);\n"
- "> ??????? /* Fill out the OS statistics structure */\n"
+ "> -\302\240\302\240\302\240\302\240\302\240\302\240 memset(stats, 0, sizeof(struct rtnl_link_stats64));\n"
+ "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240 spin_lock(&adapter->stats64_lock);\n"
+ "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240 e1000e_update_stats(adapter);\n"
+ "> \302\240\302\240\302\240\302\240\302\240\302\240\302\240 /* Fill out the OS statistics structure */\n"
  "> -------------------------------------------------------------------\n"
  "> -----------------\n"
  "> \n"
  "> This also is where the bad counters start to show up for e1000e for\n"
- "> my test systems.? From this driver on I see (very) large values for\n"
+ "> my test systems.\302\240 From this driver on I see (very) large values for\n"
  "> tx_dropped, rx_over_errors and tx_fifo_errors on driver load (even\n"
- "> before bringing the interface up.? It seems the memset is not so\n"
- "> useless for this driver after all.? Would simply reverting the e1000e\n"
+ "> before bringing the interface up.\302\240 It seems the memset is not so\n"
+ "> useless for this driver after all.\302\240 Would simply reverting the e1000e\n"
  "> portion of this patch resolve the issue?\n"
  "\n"
  "Looks like Aaron beat me to the punch on pointing out that we had this\n"
@@ -150,13 +160,26 @@
  "pursue why the stats structure is not zero'd out and resolve that\n"
  "instead.  Either way, just want to make sure we are all on the same\n"
  "page as to the right solution so that we do not end up repeating this\n"
- "in the future.\n"
- "-------------- next part --------------\n"
- "A non-text attachment was scrubbed...\n"
- "Name: signature.asc\n"
- "Type: application/pgp-signature\n"
- "Size: 833 bytes\n"
- "Desc: This is a digitally signed message part\n"
- URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20170425/81a30234/attachment.asc>
+ in the future.
+ "\01:2\0"
+ "fn\0signature.asc\0"
+ "d\0This is a digitally signed message part\0"
+ "b\0"
+ "-----BEGIN PGP SIGNATURE-----\n"
+ "\n"
+ "iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlj/EegACgkQ5W/vlVpL\n"
+ "7c76Tw//ZoHhqhoM89YYWhFZd/v/Xx6NKulBEvqX922fUyWXUxxtYKX/mPa0rj5V\n"
+ "VZ2Ui3Ev+oANLSA5F4C51uC+NfvujM0igVovwqDacyb8tqKmepUjqjauQHV/bQ3p\n"
+ "S8hiGzM+I3AlMOSUF2igHkbGoO5NP0W+ryOQzrA/8xjXWlifvv0jGYSoAW0O5TbZ\n"
+ "ege2GmC9L7mPaaVR8j3Ii/Le8T8a6ujtFCyvE1DXAg959KzTB4mpbXusVQh9WeAm\n"
+ "2PBFfpCPRwToziLYAV+1FHwNYmaHc0Ek1tiEnTFBDyPA7NOC973PWrKRuhNhZ7B8\n"
+ "DBh2t0yfSfNeFo7QCF6DSfcXpVAPnO59DM4N29BI3GcC9BDWpulW1KWYqao25kVV\n"
+ "ctdw7B3kAWPku1PutMH+H1+YNufBlYMyZBXfCIiZrgaMHI3FglZT5bZMRCv1FlVX\n"
+ "XIhqHjpV9oKysoC9YxoxO5iCr/AZQ0DqA+E7VXyO2n5b+lbQhMK6kXgfSbZ5whIV\n"
+ "H9q+kFmVra1OW/Ba5vAeelCIMIYV2W946sANUEK4O4D61Xazro4o2J8Z5msM8Jie\n"
+ "oawaZCwbZ1pG9rx/ykIjlL0mwnFWFn4BwatYOkvrRrJaI+C7+WMtlJz1YsOIxyjr\n"
+ "UPKfc4tsOp+QGPGhCjFxLbbRQfByV9EpNNUUqlgfL1j1LkhV/6g=\n"
+ "=eOkx\n"
+ "-----END PGP SIGNATURE-----\n"
 
-0874abbcc7dec08ac868f57b6299a05307d985a315218ba3ac087d974eabfe54
+32e17408c93726b17d50f3e06df3712ba86ad5bf32fe25248b51ae35b6cdd411

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.