From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34830 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1430172AbdDYMXS (ORCPT ); Tue, 25 Apr 2017 08:23:18 -0400 Subject: Patch "hv: don't reset hv_context.tsc_page on crash" has been added to the 4.4-stable tree To: vkuznets@redhat.com, gregkh@linuxfoundation.org, kys@microsoft.com, sumit.semwal@linaro.org Cc: , From: Date: Tue, 25 Apr 2017 13:20:49 +0100 Message-ID: <14931228492544@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled hv: don't reset hv_context.tsc_page on crash to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: hv-don-t-reset-hv_context.tsc_page-on-crash.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 56ef6718a1d8d77745033c5291e025ce18504159 Mon Sep 17 00:00:00 2001 From: Vitaly Kuznetsov Date: Wed, 7 Dec 2016 01:16:27 -0800 Subject: hv: don't reset hv_context.tsc_page on crash From: Vitaly Kuznetsov commit 56ef6718a1d8d77745033c5291e025ce18504159 upstream. It may happen that secondary CPUs are still alive and resetting hv_context.tsc_page will cause a consequent crash in read_hv_clock_tsc() as we don't check for it being not NULL there. It is safe as we're not freeing this page anyways. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Sumit Semwal Signed-off-by: Greg Kroah-Hartman --- drivers/hv/hv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/hv/hv.c +++ b/drivers/hv/hv.c @@ -305,9 +305,10 @@ void hv_cleanup(bool crash) hypercall_msr.as_uint64 = 0; wrmsrl(HV_X64_MSR_REFERENCE_TSC, hypercall_msr.as_uint64); - if (!crash) + if (!crash) { vfree(hv_context.tsc_page); - hv_context.tsc_page = NULL; + hv_context.tsc_page = NULL; + } } #endif } Patches currently in stable-queue which might be from vkuznets@redhat.com are queue-4.4/drivers-hv-balloon-keep-track-of-where-ha_region-starts.patch queue-4.4/drivers-hv-get-rid-of-timeout-in-vmbus_open.patch queue-4.4/hv-don-t-reset-hv_context.tsc_page-on-crash.patch queue-4.4/drivers-hv-don-t-leak-memory-in-vmbus_establish_gpadl.patch queue-4.4/tools-hv-kvp-ensure-kvp-device-fd-is-closed-on-exec.patch queue-4.4/drivers-hv-balloon-account-for-gaps-in-hot-add-regions.patch