From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:34870 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1430187AbdDYMYK (ORCPT ); Tue, 25 Apr 2017 08:24:10 -0400 Subject: Patch "Tools: hv: kvp: ensure kvp device fd is closed on exec" has been added to the 4.4-stable tree To: vkuznets@redhat.com, gregkh@linuxfoundation.org, kys@microsoft.com, sumit.semwal@linaro.org Cc: , From: Date: Tue, 25 Apr 2017 13:20:51 +0100 Message-ID: <1493122851149206@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled Tools: hv: kvp: ensure kvp device fd is closed on exec to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: tools-hv-kvp-ensure-kvp-device-fd-is-closed-on-exec.patch and it can be found in the queue-4.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From 26840437cbd6d3625ea6ab34e17cd34bb810c861 Mon Sep 17 00:00:00 2001 From: Vitaly Kuznetsov Date: Wed, 6 Jul 2016 18:24:10 -0700 Subject: Tools: hv: kvp: ensure kvp device fd is closed on exec From: Vitaly Kuznetsov commit 26840437cbd6d3625ea6ab34e17cd34bb810c861 upstream. KVP daemon does fork()/exec() (with popen()) so we need to close our fds to avoid sharing them with child processes. The immediate implication of not doing so I see is SELinux complaining about 'ip' trying to access '/dev/vmbus/hv_kvp'. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Sumit Semwal Signed-off-by: Greg Kroah-Hartman --- tools/hv/hv_kvp_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1433,7 +1433,7 @@ int main(int argc, char *argv[]) openlog("KVP", 0, LOG_USER); syslog(LOG_INFO, "KVP starting; pid is:%d", getpid()); - kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR); + kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC); if (kvp_fd < 0) { syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s", Patches currently in stable-queue which might be from vkuznets@redhat.com are queue-4.4/drivers-hv-balloon-keep-track-of-where-ha_region-starts.patch queue-4.4/drivers-hv-get-rid-of-timeout-in-vmbus_open.patch queue-4.4/hv-don-t-reset-hv_context.tsc_page-on-crash.patch queue-4.4/drivers-hv-don-t-leak-memory-in-vmbus_establish_gpadl.patch queue-4.4/tools-hv-kvp-ensure-kvp-device-fd-is-closed-on-exec.patch queue-4.4/drivers-hv-balloon-account-for-gaps-in-hot-add-regions.patch