From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>, Jouni Malinen <j@w1.fi>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params
Date: Tue, 25 Apr 2017 16:40:10 +0200 [thread overview]
Message-ID: <1493131210.2609.2.camel@sipsolutions.net> (raw)
In-Reply-To: <1492808507-31224-1-git-send-email-arend.vanspriel@broadcom.com>
On Fri, 2017-04-21 at 22:01 +0100, Arend van Spriel wrote:
> I have been working on 4-way handshake offloading and one of the
> things discussed was the addition of PORT_AUTHORIZED flag. So
> this is what I came up with, but I suppose wpa_supplicant wants
> to know whether it can expect this attribute or not. One option
> is to have PORT_UNAUTHORIZED flag instead. Another option would
> be introducing it as nl80211 protocol feature although not sure
> if it could be considered as such. What do you guys think?
I think it could be, but I'm not really sure it matters?
> + (cr->port_state != CONTROL_PORT_STATE_UNAUTHORIZED &&
> + nla_put_flag(msg, NL80211_ATTR_PORT_AUTHORIZED)) ||
> (cr->req_ie &&
>
This doesn't really make sense - why does unspecified equal authorized?
johannes
next prev parent reply other threads:[~2017-04-25 14:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 21:01 [RFC] cfg80211: add control port state to struct cfg80211_connect_resp_params Arend van Spriel
2017-04-25 14:40 ` Johannes Berg [this message]
2017-04-25 18:34 ` Arend Van Spriel
2017-04-25 18:36 ` Johannes Berg
2017-04-25 18:56 ` Arend Van Spriel
2017-04-26 7:20 ` Johannes Berg
2017-04-26 18:46 ` Arend Van Spriel
2017-04-28 12:02 ` Johannes Berg
2017-04-28 12:46 ` Arend Van Spriel
2017-04-28 12:53 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493131210.2609.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.