From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1431751AbdDYQ21 (ORCPT ); Tue, 25 Apr 2017 12:28:27 -0400 Received: from smtprelay0157.hostedemail.com ([216.40.44.157]:53422 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1170578AbdDYQ2Q (ORCPT ); Tue, 25 Apr 2017 12:28:16 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:2895:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3872:3874:4043:4321:4385:5007:7901:9010:10004:10400:10848:11232:11658:11914:12048:12295:12740:12760:12895:13069:13311:13357:13439:14096:14097:14659:21080:30054:30070:30079:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: boy04_64cb12da37058 X-Filterd-Recvd-Size: 2077 Message-ID: <1493137691.18659.1.camel@perches.com> Subject: Re: [PATCH 20/22] tools arch: Sync arch/x86/lib/memcpy_64.S with the kernel From: Joe Perches To: "Luck, Tony" , Arnaldo Carvalho de Melo , Andy Whitcroft Cc: Ingo Molnar , "linux-kernel@vger.kernel.org" , Arnaldo Carvalho de Melo Date: Tue, 25 Apr 2017 09:28:11 -0700 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F6127AEF9@ORSMSX114.amr.corp.intel.com> References: <20170424195439.29875-1-acme@kernel.org> <20170424195439.29875-21-acme@kernel.org> <20170424203630.GA18000@intel.com> <1493089177.31620.3.camel@perches.com> <3908561D78D1C84285E8C5FCA982C28F6127AEF9@ORSMSX114.amr.corp.intel.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.22.6-1ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2017-04-25 at 16:18 +0000, Luck, Tony wrote: > > > If we are going to have all these copies of kernel files below > > > "tools/...", perhaps checkpatch could warn people touching one > > > that the other needs the same update? > > > > How would checkpatch know tools hasn't already updated the other? > > If checkpatch had a list of all the tools copies, it could warn if a patch > touched a file without touching the copy. I rather doubt these files are modified simultaneously. A quick and no doubt incomplete git log -- "tools/*/kernel.h" seems to show little simultaneity. > Not completely ideal because people might update the two files in > separate patches in a series (in which case they would see warnings > from both patches). > > Also means that checkpatch needs the list of copied files ... not sure > how often that changes. Nor I. Anyway, feel free to propose an actual patch.