Re: [meta-baryon][PATCH 2/2] webmin: remove nfsd check from exports-lib.pl

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Kevin,

Thanks for tracking this one down! A couple of minor stylistic issues though:

On Wednesday 01 August 2012 14:25:02 Kevin Strasser wrote:
> YOCTO #1719: Webmin expects the userspace version of nsfd and
> attempts to find its pid when applying a new set of nfs exports.
> This check fails because baryon is configured to install the
> kernelspace version. In result the command that is assigned to
> apply_cmd will never be executed, and the contents of /exports
> are not successfully exported.

The bug reference needs to be in square brackets i.e. [YOCTO #1719], and 
typically (at least the way I use it) appears after the main body of the 
commit message.

> Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
> ---
>  recipes-extended/webmin/files/exports-lib.pl.patch |   32
> ++++++++++++++++++++ recipes-extended/webmin/webmin_1.570.bb            |  
>  3 +-
>  2 files changed, 34 insertions(+), 1 deletion(-)
>  create mode 100644 recipes-extended/webmin/files/exports-lib.pl.patch
> 
> diff --git a/recipes-extended/webmin/files/exports-lib.pl.patch
> b/recipes-extended/webmin/files/exports-lib.pl.patch new file mode 100644
> index 0000000..cdee355
> --- /dev/null
> +++ b/recipes-extended/webmin/files/exports-lib.pl.patch
> @@ -0,0 +1,32 @@
> +From 7eba4c98c6953fa6ea76c1620d19524bcfa3a576 Mon Sep 17 00:00:00 2001
> +From: Kevin Strasser <kevin.strasser@linux.intel.com>
> +Date: Wed, 1 Aug 2012 11:51:26 -0700
> +Subject: [PATCH] nfs export: remove nfsd check
> +
> +nfsd runs as a kernel process and does not have a pid. This means
> +that the command assigned to apply_cmd will never be executed when
> +the user tries to apply changes to nfs exports.
> +
> +Upstream-Status: Not appropriate [config]

Technically this should be "Inappropriate [config]".

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre