From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "snitzer@redhat.com" <snitzer@redhat.com>
Cc: "dm-devel@redhat.com" <dm-devel@redhat.com>, "hch@lst.de" <hch@lst.de>
Subject: Re: [PATCH v2 04/13] dm-rq: Adjust requeuing delays
Date: Thu, 27 Apr 2017 19:52:44 +0000 [thread overview]
Message-ID: <1493322763.2625.10.camel@sandisk.com> (raw)
In-Reply-To: <20170427191610.GA67119@redhat.com>
On Thu, 2017-04-27 at 15:16 -0400, Mike Snitzer wrote:
> This call toblk_mq_delay_run_hw_queue(), while unconvincing and suspect,
> is being introduced via block core during the 4.12 merge.
>
> But in general, this tweaking of the timeouts in such a short period
> speaks to indecision and leaves me unconvinced of what the _best_ values
> to use are.
>
> Let's revisit this after the merge window closes, we can tweak the 100ms
> up to 500ms in both locations if you _really_ prefer that.
Hello Mike,
The 100ms was a copy/paste from the SCSI initiator code. Later I realized
that that is too fast in the dm core, e.g. when the underlying paths are
busy due to SCSI error handling.
Bart.
next prev parent reply other threads:[~2017-04-27 19:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 17:11 [PATCH v2 00/13] Device mapper and dm-mpath patches Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 01/13] dm-mpath: Split activate_path() Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche
2017-04-28 5:59 ` [dm-devel] " Hannes Reinecke
2017-04-28 5:59 ` Hannes Reinecke
2017-04-27 17:11 ` [PATCH v2 02/13] dm-mpath: Avoid that path removal can trigger an infinite loop Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche
2017-04-28 5:59 ` [dm-devel] " Hannes Reinecke
2017-04-28 5:59 ` Hannes Reinecke
2017-04-27 17:11 ` [PATCH v2 03/13] dm-mpath: Delay requeuing while path initialization is in progress Bart Van Assche
2017-04-27 17:11 ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 04/13] dm-rq: Adjust requeuing delays Bart Van Assche
2017-04-27 19:16 ` Mike Snitzer
2017-04-27 19:52 ` Bart Van Assche [this message]
2017-04-27 17:11 ` [PATCH v2 05/13] dm-mpath: Make it easier to analyze requeuing behavior Bart Van Assche
2017-04-27 19:29 ` Mike Snitzer
2017-04-27 19:57 ` Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 06/13] dm-rq: Check blk_mq_register_dev() return value Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 07/13] dm, persistence: Remove an unused argument from dm_block_manager_create() Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 08/13] dm: Verify suspend_locking assumptions at runtime Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 09/13] dm-mpath: Verify locking " Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 10/13] dm: Introduce enum dm_queue_mode Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 11/13] dm-mpath: Micro-optimize the hot path Bart Van Assche
2017-04-27 20:39 ` Mike Snitzer
2017-04-27 17:11 ` [PATCH v2 12/13] dm-mpath: Introduce assign_bit() Bart Van Assche
2017-04-27 17:11 ` [PATCH v2 13/13] dm, dm-mpath: Make it easier to detect unintended I/O request flushes Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493322763.2625.10.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.