From: Johannes Berg <johannes@sipsolutions.net>
To: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>,
linux-wireless@vger.kernel.org
Cc: mohammed@codeaurora.org, Michal Kazior <michal.kazior@tieto.com>
Subject: Re: [PATCH] mac80211: Fix possible sband related NULL pointer de-reference
Date: Fri, 28 Apr 2017 11:19:00 +0200 [thread overview]
Message-ID: <1493371140.2431.6.camel@sipsolutions.net> (raw)
In-Reply-To: <1493277338-25726-1-git-send-email-mohammed@qca.qualcomm.com>
On Thu, 2017-04-27 at 12:45 +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mohammed@qti.qualcomm.com>
>
> Existing API 'ieee80211_get_sdata_band' returns default 2 GHz band
> even
> if the channel context configuration is NULL. This crashes for
> chipsets
> which support 5 Ghz alone when it tries to access members of 'sband'.
> Channel context configuration can be NULL in multivif case and when
> channel switch is in progress (or) when it fails. Fix this by
> replacing
> the API 'ieee80211_get_sdata_band' with 'ieee80211_get_sband' which
> returns a NULL pointer for sband when the channel configuration is
> NULL.
Makes sense.
Applied, but could you point to the one that actually crashed?
johannes
next prev parent reply other threads:[~2017-04-28 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 7:15 [PATCH] mac80211: Fix possible sband related NULL pointer de-reference Mohammed Shafi Shajakhan
2017-04-28 9:19 ` Johannes Berg [this message]
2017-04-28 10:38 ` Mohammed Shafi Shajakhan (Mohammed Shafi)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493371140.2431.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=mohammed@codeaurora.org \
--cc=mohammed@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.