diff for duplicates of <1493393758.2767.3.camel@sandisk.com> diff --git a/a/1.txt b/N1/1.txt index 26d1122..01ff157 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,19 +6,18 @@ On Fri, 2017-04-28 at 10:00 +0800, Ming Lei wrote: > > - cancel_delayed_work(&hctx->delay_work); > > + cancel_work_sync(&hctx->run_work); > > + cancel_delayed_work_sync(&hctx->delay_work); ->=20 +> > Could you explain it a bit why we need the sync version? -Because the purpose of this patch is to make blk_mq_quiesce_queue() wait fo= -r +Because the purpose of this patch is to make blk_mq_quiesce_queue() wait for all .queue_rq() calls. > So I suggest to unity both .run_work and .dealyed_run_work > into one work, just as what Jens did in the following link: ->=20 -> http://marc.info/?t=3D149183989800010&r=3D1&w=3D2 +> +> http://marc.info/?t=149183989800010&r=1&w=2 That should be done after this patch is upstream otherwise this patch won't apply to the stable trees. -Bart.= +Bart. diff --git a/a/content_digest b/N1/content_digest index 2daba66..134e7bb 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -20,21 +20,20 @@ "> > -\tcancel_delayed_work(&hctx->delay_work);\n" "> > +\tcancel_work_sync(&hctx->run_work);\n" "> > +\tcancel_delayed_work_sync(&hctx->delay_work);\n" - ">=20\n" + "> \n" "> Could you explain it a bit why we need the sync version?\n" "\n" - "Because the purpose of this patch is to make blk_mq_quiesce_queue() wait fo=\n" - "r\n" + "Because the purpose of this patch is to make blk_mq_quiesce_queue() wait for\n" "all .queue_rq() calls.\n" "\n" "> So I suggest to unity both .run_work and .dealyed_run_work\n" "> into one work, just as what Jens did in the following link:\n" - ">=20\n" - "> \thttp://marc.info/?t=3D149183989800010&r=3D1&w=3D2\n" + "> \n" + "> \thttp://marc.info/?t=149183989800010&r=1&w=2\n" "\n" "That should be done after this patch is upstream otherwise this\n" "patch won't apply to the stable trees.\n" "\n" - Bart.= + Bart. -87be9615f16d5aa65e14cf6c35e16cf35d733226592e393ebef6c21f976d2d3f +55037000ac490da357e6e6794e7d6ba1dca97753d7c960c07fb08a138bd70cc1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.